From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Skim.app support for org-mac-link-grabber.el Date: Tue, 14 May 2013 06:33:44 +0200 Message-ID: <541E4CA0-F2FD-4870-9CE6-52C18567C1B4@gmail.com> References: <171D50FA-314D-4233-9F7E-AD07D8B1B902@gmail.com> <5D9D77F4-F343-45D1-8B06-70550EE83E2B@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([208.118.235.92]:58497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uc6vt-0007cg-3Y for emacs-orgmode@gnu.org; Tue, 14 May 2013 00:33:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uc6vr-0008Ou-0F for emacs-orgmode@gnu.org; Tue, 14 May 2013 00:33:49 -0400 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:50091) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uc6vq-0008Od-Oq for emacs-orgmode@gnu.org; Tue, 14 May 2013 00:33:46 -0400 Received: by mail-wi0-f174.google.com with SMTP id c10so1602410wiw.1 for ; Mon, 13 May 2013 21:33:45 -0700 (PDT) In-Reply-To: <5D9D77F4-F343-45D1-8B06-70550EE83E2B@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Daniil Frumin Cc: "emacs-orgmode@gnu.org Mode" , anthony.lander@gmail.com On 13.5.2013, at 22:35, Daniil Frumin wrote: > So I've been researching this problem and it seems that there is no = sane way to re-select a text.=20 OK, thanks for looking into it. >=20 > The problem is that `(do-applescript ..)' only interacts with = AppleScript well if the return type of the string is either a number or = a string. If I try to convert the selection object (which is not really = an object but a list of specifiers) it just returns the selected text.=20= >=20 > There is also `selection bounds' but it only covers rectangle = selections. >=20 > It's possible to save the selected text and try to `find' it later, = but that won't work well (e.g.: there are several repetitions of the = same text on one page).=20 >=20 > I've also tried to implement an auto-scrolling to the selected text, = but to no avail. >=20 > The option that seems to me the most reasonable is to add a highlight = note to the selected text (which is actually possible). What do you = think?=20 Interesting idea! I think this should be implemented, but with a user = option to turn it off. >=20 > For now, the patch to the problem mentioned by Ivan. > I have actually fixed a small bug in the code for getting links from = Firefox: > Prior to the fix the firefox link grabber won't work correctly if a = cursor has been already positioned in the URL field. The fix works by = adding an additional keystore for selecting all the text in that field. >=20 > The problem is that I've committed it before committing the stuff that = Ivan told us about, so I am not sure what to do in this case. So you mean the patch you would like to send to me is several commits? = That is no problem, just specify with git which range of commits should = be part of the patch, for example git diff HEAD^^ will include the changes from two commits. You could also amend the = previous commit if it has not yet been push to another repository - = there are many ways to deal with this. - Carsten >=20 > Thanks >=20 > -- Daniil >=20 > = <0002-Fixing-a-bug-in-as-mac-firefox-get-frontmost-url.patch><0003-Automat= ic-detection-of-the-presence-of-Skim.app.patch> >=20 >=20 > On May 13, 2013, at 10:34 AM, Carsten Dominik = wrote: >=20 >> Hi Daniil, >>=20 >> I like this a lot and would like to take the patch after you have = taken Ivans feedback, and maybe more feedback if you get any. >>=20 >> I would like it even more if following the link would rehighlight the = selected text. Is there any way to achieve this? >>=20 >> I have another question, this would maybe be for the original author, = Anthony Lander? I see that there are functions with prefixes that are = not "org-". This is dangerous because there might be packages around = that use that name space. I also think it violates coding rules in = Emacs. I think this should be changed - unless you know of a convention = that all functions dealing with applescripts are supposed to have an = "as-" prefix. >>=20 >> I can fix this - but I wanted your feedback first. >>=20 >> Thanks. >>=20 >> - Carsten >>=20 >> On 12 mei 2013, at 20:29, Daniil Frumin wrote: >>=20 >>> Hi, all! >>>=20 >>> I use org-mac-link-grabber.el = almost = every day. However, it lacks support for an app that I'd like to use = together with org-mode.=20 >>>=20 >>> Skim.app is a light and fast PDF reader for Mac OS X with a = note-taking ability. I wrote a little patch for org-mac-link-grabber.el = to support grabbing links to documents. >>>=20 >>> What it does: >>>=20 >>> * Grabs not just the link to file, but a page >>>=20 >>> * Inserts the selected text as a description, if present. Otherwise >>> inserts ", p. " >>>=20 >>> * The shortcut is set to [S] >>>=20 >>> * Defines a new "skim" link type >>>=20 >>> It would be interesting to also add some support for importing notes = from Skim to org. >>>=20 >>> Since Skim.app is not present in clean OS X installs, by default = support for grabbing links from it is disabled. You can enable it by = customizing group `org-mac-link-grabber'. >>>=20 >>> So, maybe it's possible to get this patch into the tree? It's my = first time hacking on org (or even any major elisp extension), so it's = probably that I've messed up somewhere with a commit format or whatnot. >>>=20 >>> Cheers. >>>=20 >>> -- Daniil Frumin >>> <0001-Adding-Skim.app-support-to-org-mac-link-grabber.el.patch> >>=20 >=20