From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Banel Subject: Re: babel: ob-C with Visual C++ and compilation-mode Date: Wed, 13 Aug 2014 00:03:23 +0200 Message-ID: <53EA8F2B.7010205@free.fr> References: <878un4ut6c.fsf@gmail.com> <53E91C32.4000002@free.fr> <87lhqt6b0w.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHKAA-0008E4-SA for emacs-orgmode@gnu.org; Tue, 12 Aug 2014 18:03:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHKA9-0001l3-Qo for emacs-orgmode@gnu.org; Tue, 12 Aug 2014 18:03:26 -0400 Received: from smtp2-g21.free.fr ([2a01:e0c:1:1599::11]:27935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHKA9-0001kj-KP for emacs-orgmode@gnu.org; Tue, 12 Aug 2014 18:03:25 -0400 Received: from [IPv6:2a01:e35:2e21:def0:b425:737d:9428:4f58] (unknown [IPv6:2a01:e35:2e21:def0:b425:737d:9428:4f58]) by smtp2-g21.free.fr (Postfix) with ESMTP id 0697D4B002F for ; Wed, 13 Aug 2014 00:03:23 +0200 (CEST) In-Reply-To: <87lhqt6b0w.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Le 12/08/2014 16:24, Ernesto Durante a =C3=A9crit : > Hi Thierry, > > Thanks you but I don't know who is responsible to apply the patch. I have been in touch with Eric Schulte and Bastien Guerry who are both maintainers. Probably Eric is the right person, as he is very involved in all Babel subjects. I am not aware of any criteria for accepting a contribution. Contributions are always welcome. Sending them to the mailing list (as you did) is the best way to discuss them. > As you are a contributor and author of ob-C, maybe you know how to proc= eed.=20 You may want to read this page: http://orgmode.org/worg/org-contribute.ht= ml Your patch seems to change less than 15 lines. If this is confirmed, then your proposal falls in the "tiny change" category. "Tiny changes" do not need the "assignment contract with the FSF". However you may want to sign the assignment with the FSF anyway if you intend to contribute more. (The Free Software Foundation holds the copyright for Gnu Emacs, Org-mode being part of Emacs). I signed the assignment. It took several weeks. It covers any future contribution I may submit. Technically, the best way to submit your patch is to generate a file with the "git format-patch" command, then send it to the mailing list. Obviously you are familiar with Git. Otherwise, read the explanations in the aforementioned page. You will need to pay attention to the commit message you will write, in order to be consistent with all other commit messages. > > I have identified a minor bug. When a source code block has the mode > cpp, we cannot expand the code or more precisely the code is not > expanded in the correct way because the following function is missing =20 > > (defun org-babel-expand-body:cpp (body params) > "Execute BODY according to PARAMS.This function calls `org-babel-expa= nd-body:C++'." > (org-babel-expand-body:C++ body params)) Thanks for reporting this ! You may consider submitting a patch for this bug. The comment "Execute BODY ..." should be changed to "Expand BODY ...= ". > > Best > Ernesto You are very welcome Thierry