From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?U3RldmVuIFLDqW1vdA==?= <steven.remot@gmail.com>
Subject: Re: [PATCH] Add support for :dbhost, :dbuser and :database
 parameters for poastgresql in ob-sql.el
Date: Sat, 09 Aug 2014 12:04:05 +0200
Message-ID: <53E5F215.10103@gmail.com>
References: <53E52F05.3040106@gmail.com> <m2d2cacxa5.fsf@tsdye.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46825)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <steven.remot@gmail.com>) id 1XG3VV-00046T-On
	for emacs-orgmode@gnu.org; Sat, 09 Aug 2014 06:04:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <steven.remot@gmail.com>) id 1XG3VP-0007jD-UG
	for emacs-orgmode@gnu.org; Sat, 09 Aug 2014 06:04:13 -0400
Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:40473)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <steven.remot@gmail.com>) id 1XG3VP-0007j3-OU
	for emacs-orgmode@gnu.org; Sat, 09 Aug 2014 06:04:07 -0400
Received: by mail-wg0-f42.google.com with SMTP id l18so6528244wgh.1
	for <emacs-orgmode@gnu.org>; Sat, 09 Aug 2014 03:04:07 -0700 (PDT)
In-Reply-To: <m2d2cacxa5.fsf@tsdye.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: "Thomas S. Dye" <tsd@tsdye.com>
Cc: emacs-orgmode@gnu.org

Le 09/08/2014 02:38, Thomas S. Dye a écrit :
> Aloha Steven,
>
> Steven Rémot <steven.remot@gmail.com> writes:
>
>> Hi,
>>
>> I did some changes to support :dbname, :dbhost and :database in SQL
>> code blocks when using postgresql engine.
>>
>> Even if it was possible to specify this information using :cmdline
>> parameter, I thought it was a bit cleaner to be able to provide this
>> information in a way independent from the command line.
>>
>> I will gladly accept any remark / comment on this patch.
>>
>> Regards,
>> Steven Rémot
> I'm not certain who is maintaining ob-sql.el, so I'm not replying in any
> directly useful way.  However, this patch looks straightforward and
> good to me.
>
> Have you signed FSF papers?  If so, the maintainer can accept (or
> reject) your patch.  If not, then you'll need to identify it as a tiny
> change (see http://orgmode.org/worg/org-contribute.html).
>
> Thanks for this contribution to Org mode.
>
> All the best,
> Tom
This is my only contribution to Emacs code, and it changes only 12 lines 
that impact a very tiny fragment of org, so I though I could send it 
without signing papers. If I was wrong, I don't mind signing papers at all.

Regards,
Steven Rémot