From: Anders Johansson <mejlaandersj@gmail.com>
To: Eric Abrahamsen <eric@ericabrahamsen.net>, emacs-orgmode@gnu.org
Subject: Re: Bug? org-set-tags never uses ido
Date: Tue, 04 Mar 2014 23:22:58 +0100 [thread overview]
Message-ID: <53165242.2060704@gmail.com> (raw)
In-Reply-To: <87d2mknbwh.fsf@ericabrahamsen.net>
Looking at this again I realize that the reason for this behavior is
that we want completion of possibly several tags. This is what the
"org-tags-completion-function" does when supplied as the second argument
of "completing-read". As "ido-completing-read" and
"org-iswitchb-completing-read" doesn't support this, they are not used.
I don't know if there would be a way of getting both ido and multiple
input. As it is now though, it's pretty meaningless to have that call to
org-icompleting-read there as it never gets activated. It could as well be:
(completing-read "Tags: "
'org-tags-completion-function
nil nil current 'org-tags-history)))))
Cheers,
Anders Johansson
2013-11-01 02:33, Eric Abrahamsen skrev:
> Anders Johansson <mejlaandersj@gmail.com> writes:
>
>> Greetings,
>> I want to use ido everywhere and wanted to know why this doesn't seem
>> to work for setting org-mode tags (it never has for me).
>>
>> Using edebug to step through the call to org-icompleting-read which
>> org-set-tags does I can see that it never gets to using ido since the
>> last condition below is false:
>> org.el:10147-10150 (package repository version 20131028):
>> (if (and org-completion-use-ido
>> (fboundp 'ido-completing-read)
>> (boundp 'ido-mode) ido-mode
>> (listp (second args)))
>>
>> This is not strange, since org-icompleting-read is called like this in
>> org-set-tags:
>>
>> org.el:14519-14521
>> (org-icompleting-read "Tags: "
>> 'org-tags-completion-function
>> nil nil current 'org-tags-history))))))
> Hmm, shouldn't that 'org-tags-completion-function be replaced with
> org-last-tags-completion-table? A quick test shows that works, and from
> glancing at the code it seems like org-last-tags-completion-table should
> hold the proper assortment of tags...
>
> E
>
>> ido apparently needs a list of possible completions, not a single symbol.
>>
>> I don't understand much more of this really.
>> Is it a bug? Have I misunderstood something?
>>
>> Greetings,
>> Anders Johansson
>
next prev parent reply other threads:[~2014-03-04 22:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 16:39 Bug? org-set-tags never uses ido Anders Johansson
2013-11-01 1:33 ` Eric Abrahamsen
2014-03-04 22:22 ` Anders Johansson [this message]
2014-03-05 0:20 ` Samuel Wales
2014-03-05 0:31 ` Anders Johansson
2014-03-05 0:47 ` Samuel Wales
2014-03-05 1:49 ` Eric Abrahamsen
2014-04-02 17:37 ` Anders Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53165242.2060704@gmail.com \
--to=mejlaandersj@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).