emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Lee Hinman <lee@writequit.org>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: ob-clojure tangling does not handle comments correctly [8.2.5h (8.2.5h-6-g8e1386-elpa @ /usr/local/Cellar/emacs/HEAD/share/emacs/24.3.50/lisp/org/)]
Date: Thu, 6 Feb 2014 10:08:56 -0700	[thread overview]
Message-ID: <52F3C187.9040908@writequit.org> (raw)
In-Reply-To: <87k3d8i4m0.fsf@bzg.ath.cx>

On 2/6/14, 9:32 AM, Bastien wrote:
> Can you try with latest ob-clojure.el from the master branch?
> We fixed a few things recently, and the example works fine for
> me.

I tried it running from git (org-version returns "Org-mode version
8.2.3a (release_8.2.3a @ /Users/hinmanm/src/elisp/org-mode/lisp/)")

I'm still getting it tangled as

(let [org-mode-print-catcher (java.io.StringWriter.)]
(clojure.pprint/with-pprint-dispatch clojure.pprint/code-dispatch
(clojure.pprint/pprint (do (println "foo")
;; My comment) org-mode-print-catcher) (str org-mode-print-catcher)))

I did some bisecting on my dotfiles and determined it was caused by this
line:

(setq org-babel-default-header-args
      (cons '(:results . "code")
            (assq-delete-all :results org-babel-default-header-args)))


Which seems very strange to me, once I comment out that line the text is
tangled as just

(println "foo")
;; My comment

  reply	other threads:[~2014-02-06 17:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-06  6:03 Bug: ob-clojure tangling does not handle comments correctly [8.2.5h (8.2.5h-6-g8e1386-elpa @ /usr/local/Cellar/emacs/HEAD/share/emacs/24.3.50/lisp/org/)] Lee Hinman
2014-02-06 16:32 ` Bastien
2014-02-06 17:08   ` Lee Hinman [this message]
2014-02-06 21:46     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F3C187.9040908@writequit.org \
    --to=lee@writequit.org \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).