From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kodi Arfer <kodi@arfer.net>
Subject: Re: [PATCH] ox-html: Restore wrongly omitted table attributes under
 HTML5.
Date: Sat, 29 Jun 2013 19:30:42 -0400
Message-ID: <51CF6E22.4040202@arfer.net>
References: <51CEF804.8070608@arfer.net> <8761wwk0gi.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38396)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kodi@arfer.net>) id 1Ut4bQ-00049O-5b
	for emacs-orgmode@gnu.org; Sat, 29 Jun 2013 19:30:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kodi@arfer.net>) id 1Ut4bN-0007kv-BE
	for emacs-orgmode@gnu.org; Sat, 29 Jun 2013 19:30:47 -0400
Received: from mxout-08.mxes.net ([216.86.168.183]:58351)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kodi@arfer.net>) id 1Ut4bN-0007kl-6L
	for emacs-orgmode@gnu.org; Sat, 29 Jun 2013 19:30:45 -0400
In-Reply-To: <8761wwk0gi.fsf@gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: emacs-orgmode@gnu.org

On 2013 Jun 29 Sat 6:37:33 PM -0400, Nicolas Goaziou 
<n.goaziou@gmail.com> wrote:
> Kodi Arfer <kodi@arfer.net> writes:
>
>>  From edd97671641e28c3e240efe6ea8fa8d77b4b7eae Mon Sep 17 00:00:00 2001
>> From: Kodi Arfer <git@arfer.net>
>> Date: Sat, 29 Jun 2013 10:43:07 -0400
>> Subject: [PATCH] ox-html: Restore wrongly omitted table attributes under
>>   HTML5.
>>
>> * lisp/ox-html.el (org-html-table): For HTML5,
>>    omit :html-table-attributes but not :id or :attr_html.
>
> Thank you for your patch. Could you rebase it against "maint"? I cannot
> apply it at the moment.

I don't think I can. I'm not clear about the relationship between maint 
and master in general, but it looks like maint doesn't have the bug my 
patch is supposed to fix, because it doesn't treat an HTML5 doctype 
specially at all.

>> +	       (unless (org-html-html5-p info)
>> +		 (plist-get info :html-table-attributes))
>
> One nitpick. It is more explicit to use:
>
>    (and (not (org-html-html5-p info))
>         (plist-get info :html-table-attributes))
>
> since you are using the returned value.

Sure, I can change that. Should I base the patch off master again?