emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Marc Ihm <marc@ihm.name>
To: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] choices in org-id-find for handling missing ids
Date: Sun, 13 Jun 2021 07:51:31 +0200	[thread overview]
Message-ID: <518afd8c-c1e3-3250-6d84-92f46d1d4a2b@ihm.name> (raw)
In-Reply-To: <1607921150.924467.1623507388932@www.ud-mail.de>

Hi once more,
well after sending this patch I noticed, that org-id-update-id-locations 
has become orders of magnitude faster on my system; with org 9.4 it 
takes seconds instead of minutes as with org 9.3. Which is great news :-)
This alone may dratically reduce the need for changing the behaviour of 
org-id-find as contained in my patch.
So you may feel free to ignore it ...
Best Marc

Am 12.06.2021 um 16:16 schrieb Marc-Oliver Ihm:
> Hi,
> please find attached a patch to allow more flexible handling of missing ids in org-id-find; some people (like me) tend to lose ids now and then and may benefit from more choices.
> The current behaviour of calling org-id-update-id-locations is pretty perfect for situations where the id has been moved to another file (which will be the case in most situations, I guess). However, sometimes an id has simply been deleted and then searching for it in all files can not be helpful. Especially lisp-code calling org-id-find might want to handle things on its own.
> To this goal, a new custom org-id-action-on-missing-id has been added; reproducing its description from the patch:
>> (defcustom org-id-action-on-missing-id 'update
>>    "Special action to be taken, if `org-id-find' cannot find an id.
>> With 'update (default), org-id-find will silently call
>> `org-id-update-id-locations' and try again; this will help,
>> e.g. if you have moved the id to another file.
>> With 'exception, the exception 'not-found will be thrown, which
>> can be useful, if `org-id-find' is called from within lisp and
>> the caller wants to handle the situation.
>> With 'error, a descriptive error will be raised, causing the
>> current command to terminate."
>>    :group 'org-id
>>    :type '(choice
>> 	  (const :tag "Run `org-id-update-id-locations' if an id cannot be found" update)
>> 	  (const :tag "Throw exception `not-found'" exception)
>> 	  (const :tag "Raise an error" error)
>>            ))
> the handling in org-id-find is straightforward.
> The default corresponds to the current behaviour.
> I would like to ask for opinions/discussion on this patch and maybe see it applied if found fit.
> Best regards
> Marc Ihm

  reply	other threads:[~2021-06-13  5:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-12 14:16 [PATCH] choices in org-id-find for handling missing ids Marc-Oliver Ihm
2021-06-13  5:51 ` Marc Ihm [this message]
2021-09-26  6:24   ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=518afd8c-c1e3-3250-6d84-92f46d1d4a2b@ihm.name \
    --to=marc@ihm.name \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).