From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Andreas_R=F6hler?= Subject: Re: [PATCH] session with python-mode.el complains of void py-toggle-shells Date: Thu, 21 Feb 2013 21:08:15 +0100 Message-ID: <51267EAF.3020404@easy-emacs.de> References: <87ham8y5rw.fsf@gmail.com> <3314.1358914289@alphaville> <87fw1sxe15.fsf@gmail.com> <87pq0w2gq6.fsf@bzg.ath.cx> <51002599.6000404@online.de> <87mwvy659o.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------030907080208070705060009" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:59918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8cQw-000396-Uk for emacs-orgmode@gnu.org; Thu, 21 Feb 2013 15:08:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U8cQu-0001QZ-QR for emacs-orgmode@gnu.org; Thu, 21 Feb 2013 15:07:58 -0500 Received: from moutng.kundenserver.de ([212.227.17.8]:54601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8cQu-0001PT-Gp for emacs-orgmode@gnu.org; Thu, 21 Feb 2013 15:07:56 -0500 In-Reply-To: <87mwvy659o.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org This is a multi-part message in MIME format. --------------030907080208070705060009 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Am 24.01.2013 15:10, schrieb Bastien: > Hi Andreas, > > Andreas Röhler writes: > >> Okay, I'll dig into. >> >> For the moment: assume this code should not be needed, >> python-mode.el should act that all. But let me have a closer look, > > Great, thanks a lot! > So let's start with this... BTW, being deeply impressed by org-mode and babel in special. --------------030907080208070705060009 Content-Type: text/x-patch; name="ob-python.el.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="ob-python.el.diff" commit e7a5839b5a10d0a27e26b8f1d16296f4c20a1350 Author: Andreas Roehler Date: Thu Feb 21 20:46:49 2013 +0100 Depend default python-mode from existing feature The former (if (featurep 'xemacs) 'python-mode 'python) makes a wrong assumption, as python-mode.el provides 'python-mode which does not depend from use of XEmacs A next step should enable users to choose environment via defcustom diff --git a/lisp/ob-python.el b/lisp/ob-python.el index 02d762c..1b3b892 100644 --- a/lisp/ob-python.el +++ b/lisp/ob-python.el @@ -43,7 +43,7 @@ (defvar org-babel-python-command "python" "Name of the command for executing Python code.") -(defvar org-babel-python-mode (if (featurep 'xemacs) 'python-mode 'python) +(defvar org-babel-python-mode (if (featurep 'python-mode) 'python-mode 'python) "Preferred python mode for use in running python interactively. This will typically be either 'python or 'python-mode.") --------------030907080208070705060009--