From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rainer Stengele Subject: Re: commenting out a SCHEDULED line does not remove todo from agenda. Date: Thu, 17 Jan 2013 10:44:57 +0100 Message-ID: <50F7C819.70305@online.de> References: <8696.1358358500@alphaville> <16014.1358398925@alphaville> <717C030F-136F-46CA-B0C0-5F9CB3560921@gmail.com> <17512.1358412853@alphaville> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:57400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvm1s-0006wH-Ey for emacs-orgmode@gnu.org; Thu, 17 Jan 2013 04:45:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tvm1r-0003St-Ap for emacs-orgmode@gnu.org; Thu, 17 Jan 2013 04:45:00 -0500 Received: from ns.diplan.de ([212.34.188.4]:39650 helo=mail.diplan.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvm1q-0003Sd-Ve for emacs-orgmode@gnu.org; Thu, 17 Jan 2013 04:44:59 -0500 In-Reply-To: <17512.1358412853@alphaville> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: nicholas.dokos@hp.com Cc: emacs-orgmode@gnu.org, Carsten Dominik Am 17.01.2013 09:54, schrieb Nick Dokos: > Carsten Dominik wrote: > >> >> On 17.1.2013, at 06:02, Nick Dokos wrote: >> >>> ... >>> It sets p to the point at the beginning of the line and then >>> checks if the character after it is '#'. Only then does it skip >>> the entry. >> >> And this is done for speed. Maybe Moore's law has progressed enough to relax this assumption? >> > > For me, probably yes: my agenda is fairly simple. More complicated > agendas still seem to take a fairly substantial time to construct > however - Bastien spent considerable effort recently to speed up the > agenda and might look askance at any attempt to slow it down :-) > > But actual numbers would carry more weight than any guesses I might > make. Here is a (probably stupid) implementation of the generalized > mechanism. In org-agenda-skip, replace > > (if (equal (char-after p) ?#) (throw :skip t)) > > with > > (save-excursion > (goto-char p) > (skip-chars-forward "[:blank:]") > (if (equal (char-after) ?#) (throw :skip t))) > > Assuming it's correct (and no better implementation is suggested), maybe > somebody with a time-consuming agenda can try profiling with and without > the generalized mechanism and let us know. > > I tried with my agenda which calls org-agenda-skip 5768 times. Without > the mod, they took 0.13s; with the mod, they took 0.19s, so that's a 50% > increase - but the overall time was actually shorter in the second case: > 1.64s vs 1.72s. The data look noisy however (I only tried it once in > each case) so it's hard to say anything meaningful. I'd need to run many > more experiments before I'd trust these numbers. > > Nick Hi, setting '#" at bol works. As my agenda was and is slow and only became faster after Bastiens optimisations lately I do not want to motivate changes which makes the agenda creation slower again. I am happy with setting a '#' at bol. Thanks for investigating. If I find time I will test your org-agenda-skip modifikation and measure performance. Rainer