From: Robert Klein <kleinrob@mpip-mainz.mpg.de>
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Patch: HTML body onload/onunload attribute support for new exporter
Date: Thu, 18 Oct 2012 11:42:11 +0200 [thread overview]
Message-ID: <507FCEF3.4010609@mpip-mainz.mpg.de> (raw)
In-Reply-To: <87vce9mcmc.fsf@gmail.com>
Hallo,
On 10/17/2012 03:50 PM, Nicolas Goaziou wrote:
> Hello,
>
> Robert Klein<kleinrob@mpip-mainz.mpg.de> writes:
>
>> I created a patch for the new exporter, so I can adding onload and
>> onunload attributes to the body tag in HTML export.
>>
>>
>> I'm rather new to emacs lisp, please check if this is to be included
>> in org-mode.
>
> Before reviewing the patch, I'd like to know if the onload and onunload
> attributes are common enough to justify the creation of a variable.
> Indeed, it's already quite easy to achieve the same using personal
> filters. I.e.:
>
> #+begin_src emacs-lisp
> (defun my-html-body-onload-filter (output backend info)
> "Add my onload attribute to<body> tag, if any."
> (when (and (eq backend 'e-html)
> (string-match "<body>\n" output))
> (replace-match "<body onLoad=\"anything\">\n" nil nil output)))
>
> (add-to-list 'org-export-filter-final-output-functions
> 'my-html-body-onload-filter)
> #+end_src
>
> If you think it's still worth adding variables in order to make it a tad
> bit easier, I'll review the patch.
>
> Thanks for your work.
>
The onload/onunload attributes probably aren't that much used. If
you're doing a lot of javascript on a web page they are useful.
Better not to include this in org-mode. I'll investigate the use of a
filter for myself.
Thanks and best regards
Robert
prev parent reply other threads:[~2012-10-18 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 13:20 Patch: HTML body onload/onunload attribute support for new exporter Robert Klein
2012-10-17 13:50 ` Nicolas Goaziou
2012-10-18 9:42 ` Robert Klein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507FCEF3.4010609@mpip-mainz.mpg.de \
--to=kleinrob@mpip-mainz.mpg.de \
--cc=emacs-orgmode@gnu.org \
--cc=n.goaziou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).