emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Mats Kindahl <mats.kindahl@oracle.com>
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Resolve regexp ambiguity for item headers
Date: Mon, 10 Sep 2012 21:35:52 +0200	[thread overview]
Message-ID: <504E4118.3040700@oracle.com> (raw)
In-Reply-To: <87ehm93fd7.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1292 bytes --]


On 09/10/2012 08:24 PM, Nicolas Goaziou wrote:
> Hello,
>
> Mats Kindahl <mats.kindahl@oracle.com> writes:
>
>> I solved this issue by requiring that there should always be a headline
>> text (this is after all an assumption made in the code) and rewrote the
>> org-complex-heading-regexp accordingly.
> Actually, I have recently committed a change going exactly the opposite
> way. I'm not certain which solution is better, but I tend to think empty
> headlines should be valid and parts of Org choking on empty headlines
> should be fixed.

Hi Nicolas,

Interesting. :)

Well... the most important point for me is that it shouldn't choke on
these lines, but otherwise I'm open to suggestions.

My rationale for doing it this way was:

  * The code I looked at assumes that the headline text is there, so
    it's likely that it's the common assumption.
  * It is clearly the case that todo keywords are optional.
  * It is not so clear that the headline text is optional

However:

  * The regular expression matches completely empty headlines, so maybe
    the intention is to allow matching items with just a todo keyword?

I would be very interested if anybody could shed some light on this.

Best wishes,
Mats Kindahl

-- 
Senior Principal Software Developer
Oracle, MySQL Department


[-- Attachment #2: Type: text/html, Size: 2089 bytes --]

  reply	other threads:[~2012-09-10 19:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-10 13:20 [PATCH] Resolve regexp ambiguity for item headers Mats Kindahl
2012-09-10 18:24 ` Nicolas Goaziou
2012-09-10 19:35   ` Mats Kindahl [this message]
2012-09-12 14:49     ` Nicolas Goaziou
2012-09-19  9:14       ` Bastien
2012-09-19  9:19         ` Mats Kindahl
2012-09-19 13:58           ` Nicolas Goaziou
2012-09-19 16:51             ` Bastien
2012-09-19 18:14               ` Nick Dokos
2012-09-21  8:56                 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504E4118.3040700@oracle.com \
    --to=mats.kindahl@oracle.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=n.goaziou@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).