From: Simon Thum <simon.thum@gmx.de>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Org-babel: Maxima invocation fix
Date: Tue, 08 May 2012 13:38:18 +0200 [thread overview]
Message-ID: <4FA905AA.3080502@gmx.de> (raw)
In-Reply-To: <87r4uvbt86.fsf@Rainer.invalid>
[-- Attachment #1: Type: text/plain, Size: 571 bytes --]
Hi,
attached the new fix. Does the "v2" line count as changelog?
Cheers,
Simon
On 05/07/2012 11:02 PM, Achim Gratz wrote:
> Simon Thum writes:
>> I'm sure there is a better way to fix this, but the attached patch
>> helps me to not get something like "Warning: argument nil not
>> recognized" spoiling every maxima result.
>
> I'd rather do this directly in the let form:
>
> - (let* ((cmdline (cdr (assoc :cmdline params)))
> + (let* ((cmdline (or (cdr (assoc :cmdline params)) ""))
>
> And please provide a changelog with your patch.
>
>
> Regards,
> Achim.
[-- Attachment #2: 0001-Org-Babel-fix-maxima-invocation-without-explicit-par.patch --]
[-- Type: text/x-patch, Size: 1017 bytes --]
From 63e9747d81f07abdc05db2f7754c8f7adbb1b2c6 Mon Sep 17 00:00:00 2001
From: Simon Thum <simon.thum@gmx.de>
Date: Tue, 8 May 2012 13:31:11 +0200
Subject: [PATCH] Org-Babel: fix maxima invocation without explicit parameters
v2: fix in the let form as suggested by Achim Gratz
Signed-off-by: Simon Thum <simon.thum@gmx.de>
---
lisp/ob-maxima.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lisp/ob-maxima.el b/lisp/ob-maxima.el
index b092e13..21bae78 100644
--- a/lisp/ob-maxima.el
+++ b/lisp/ob-maxima.el
@@ -70,7 +70,7 @@ called by `org-babel-execute-src-block'."
(message "executing Maxima source code block")
(let ((result-params (split-string (or (cdr (assoc :results params)) "")))
(result
- (let* ((cmdline (cdr (assoc :cmdline params)))
+ (let* ((cmdline (or (cdr (assoc :cmdline params)) ""))
(in-file (org-babel-temp-file "maxima-" ".max"))
(cmd (format "%s --very-quiet -r 'batchload(%S)$' %s"
org-babel-maxima-command in-file cmdline)))
--
1.7.3.4
next prev parent reply other threads:[~2012-05-08 11:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 19:12 Org-babel: Maxima invocation fix Simon Thum
2012-05-07 21:02 ` Achim Gratz
2012-05-08 11:38 ` Simon Thum [this message]
2012-05-08 12:15 ` Bastien
2012-05-08 15:19 ` Simon Thum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA905AA.3080502@gmx.de \
--to=simon.thum@gmx.de \
--cc=Stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).