emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Rainer Stengele <rainer.stengele@online.de>
Cc: bernt@norang.ca, emacs-orgmode@gnu.org
Subject: Re: Sticky agenda branch merged
Date: Tue, 17 Apr 2012 21:02:57 +0200	[thread overview]
Message-ID: <4F8DBE61.7080405@online.de> (raw)
In-Reply-To: <4F8D4164.1070207@online.de>

Am 17.04.2012 12:09, schrieb Rainer Stengele:
> Am 16.04.2012 11:47, schrieb Max Mikhanosha:
>> I had just pushed a merge of max-sticky-agenda branch to master, let
>> me know if there are any problems, also feel free to hack/iterate on
>> it, if you have question as to why something was done, I'll do my best
>> to answer.
>>
>> In particular I just seen a new commit introducing filter on
>> categories, and org-agenda-filtered-by-top-category probably needs to
>> be included into local variable list to have it work per agenda
>> buffer.
>>
>> Also the individual calls to org-todo-list and such, do not work right
>> with sticky agenda as there is nothing to catch the 'exit tag, that is
>> thrown by `org-prepare-agenda' when it finds cached buffer. I'm not
>> sure there is more elegant way of fixing it, other then wrapping all
>> the individual scanner pieces with (catch) blocks, that re-throw if
>> they had detected that they been called from (org-agenda) command
>>
>> Regards,
>>    Max
>>
>>
> Hi,
>
> I see a strange behaviour when clocking in with C-c C-x C-i.
> Sometimes (!) there is no new CLOCK: entry created.
> The TODO state changes as expected, but no new CLOCK: line is created, even when clocking out.
> Looks like this happens when the initial TODO state is set.
>
> Maybe I missed a change in the behaviour?
>
> Regards,
> Rainer
>
>
Hi Max,

I found the culprit:


(defun bh/mark-parent-tasks-started ()
   "Visit each parent task and change TODO states to STARTED"
   (unless bh/mark-parent-tasks-started
     (when (equal state "INARBEIT")
       (let ((bh/mark-parent-tasks-started t))
         (save-excursion
           (while (org-up-heading-safe)
             (when (member (nth 2 (org-heading-components)) (list "TODO" "INARBEIT" "WARTEN"))
               (org-todo "INARBEIT"))))))))

(add-hook 'org-after-todo-state-change-hook 'bh/mark-parent-tasks-started 'append)


something seems to have changed conecerning the "state" variable. The function fails and stops the clockin process.
Deactivating the hook brings back the right behaviour.
Sorry for that.

Bernt, that function of yours does seem to have stopped working?

Thanks and regards,
Rainer

  parent reply	other threads:[~2012-04-17 19:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16  9:47 Sticky agenda branch merged Max Mikhanosha
2012-04-16 17:44 ` Tassilo Horn
2012-04-16 18:27   ` Charles Philip Chan
2012-04-16 22:59   ` Max Mikhanosha
2012-04-16 23:23     ` Charles Philip Chan
2012-04-17  6:14     ` Tassilo Horn
2012-04-17 10:09 ` Rainer Stengele
2012-04-17 12:29   ` Max Mikhanosha
2012-04-17 13:23     ` Rainer Stengele
2012-04-17 15:32       ` Max Mikhanosha
2012-04-17 15:58         ` Rainer Stengele
2012-04-17 16:28           ` BUG: Agenda clock related "v" for multi-block agendas Max Mikhanosha
2012-04-17 17:41         ` Sticky agenda branch merged Rainer Stengele
2012-04-17 19:02   ` Rainer Stengele [this message]
2012-04-17 19:35     ` Nick Dokos
2012-04-17 20:06       ` Rainer Stengele
2012-04-17 22:33     ` Bernt Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8DBE61.7080405@online.de \
    --to=rainer.stengele@online.de \
    --cc=bernt@norang.ca \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).