emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Avoiding div from special blocks to be in <p>…
@ 2011-12-04 16:01 Jonathan BISSON
  2011-12-04 18:57 ` Christian Moe
  0 siblings, 1 reply; 5+ messages in thread
From: Jonathan BISSON @ 2011-12-04 16:01 UTC (permalink / raw)
  To: emacs-orgmode


[-- Attachment #1.1: Type: text/plain, Size: 269 bytes --]

Hi,

I just uncommented a line in org-special-blocks.el that made div special
blocks (like #+begin_foo) in html export to be between <p>…</p>…
It seems to work well like this (and now the produced documents are W3C
valid).

Any clue on why it was commented ?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: no_divs_in_p.patch --]
[-- Type: text/x-patch; name="no_divs_in_p.patch", Size: 622 bytes --]

diff --git a/lisp/org-special-blocks.el b/lisp/org-special-blocks.el
index 2da57f0..d55e255 100644
--- a/lisp/org-special-blocks.el
+++ b/lisp/org-special-blocks.el
@@ -81,7 +81,7 @@ seen.  This is run after a few special cases are taken care of."
   "Converts the special cookies into div blocks."
   ;; Uses the dynamically-bound variable `line'.
   (when (string-match "^ORG-\\(.*\\)-\\(START\\|END\\)$" line)
-;    (org-close-par-maybe)
+    (org-close-par-maybe)
     (message "%s" (match-string 1))
     (if (equal (match-string 2 line) "START")
 	(insert "<div class=\"" (match-string 1 line) "\">\n")

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 230 bytes --]

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: Avoiding div from special blocks to be in <p>…
  2011-12-04 16:01 Avoiding div from special blocks to be in <p>… Jonathan BISSON
@ 2011-12-04 18:57 ` Christian Moe
  2011-12-04 19:41   ` Jonathan BISSON
  2011-12-11 13:11   ` Bastien
  0 siblings, 2 replies; 5+ messages in thread
From: Christian Moe @ 2011-12-04 18:57 UTC (permalink / raw)
  To: Jonathan BISSON; +Cc: emacs-orgmode

Hi,

I submitted a patch to this effect a month and a half back.

http://patchwork.newartisans.com/patch/979/

Apart from uncommenting that line, I put in an org-open-par after the 
div and rearranged a few lines to follow the same structure as other 
similar bits of code.


Yours,
Christian


On 12/4/11 5:01 PM, Jonathan BISSON wrote:
> Hi,
>
> I just uncommented a line in org-special-blocks.el that made div special
> blocks (like #+begin_foo) in html export to be between<p>…</p>…
> It seems to work well like this (and now the produced documents are W3C
> valid).
>
> Any clue on why it was commented ?
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Avoiding div from special blocks to be in <p>…
  2011-12-04 18:57 ` Christian Moe
@ 2011-12-04 19:41   ` Jonathan BISSON
  2011-12-11 13:11   ` Bastien
  1 sibling, 0 replies; 5+ messages in thread
From: Jonathan BISSON @ 2011-12-04 19:41 UTC (permalink / raw)
  To: mail, emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

On 12/04/2011 07:57 PM, Christian Moe wrote:
> Hi,
> 
> I submitted a patch to this effect a month and a half back.
> 
> http://patchwork.newartisans.com/patch/979/
> 
> Apart from uncommenting that line, I put in an org-open-par after the
> div and rearranged a few lines to follow the same structure as other
> similar bits of code.
> 
> 
> Yours,
> Christian
> 

Neater implementation, I vote for it :)

Jonathan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 230 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Avoiding div from special blocks to be in <p>…
  2011-12-04 18:57 ` Christian Moe
  2011-12-04 19:41   ` Jonathan BISSON
@ 2011-12-11 13:11   ` Bastien
  2011-12-11 13:38     ` Christian Moe
  1 sibling, 1 reply; 5+ messages in thread
From: Bastien @ 2011-12-11 13:11 UTC (permalink / raw)
  To: mail; +Cc: emacs-orgmode, Jonathan BISSON

Hi Christian,

Christian Moe <mail@christianmoe.com> writes:

> I submitted a patch to this effect a month and a half back.
>
> http://patchwork.newartisans.com/patch/979/
>
> Apart from uncommenting that line, I put in an org-open-par after the div
> and rearranged a few lines to follow the same structure as other similar
> bits of code.

I just applied it.  Sorry for the delay and thanks for this.

Best,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Avoiding div from special blocks to be in <p>…
  2011-12-11 13:11   ` Bastien
@ 2011-12-11 13:38     ` Christian Moe
  0 siblings, 0 replies; 5+ messages in thread
From: Christian Moe @ 2011-12-11 13:38 UTC (permalink / raw)
  To: Bastien; +Cc: emacs-orgmode, Jonathan BISSON

Thanks!

Yours,
Christian

On 12/11/11 2:11 PM, Bastien wrote:
> Hi Christian,
>
> Christian Moe<mail@christianmoe.com>  writes:
>
>> I submitted a patch to this effect a month and a half back.
>>
>> http://patchwork.newartisans.com/patch/979/
>>
>> Apart from uncommenting that line, I put in an org-open-par after the div
>> and rearranged a few lines to follow the same structure as other similar
>> bits of code.
>
> I just applied it.  Sorry for the delay and thanks for this.
>
> Best,
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-12-11 13:33 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-04 16:01 Avoiding div from special blocks to be in <p>… Jonathan BISSON
2011-12-04 18:57 ` Christian Moe
2011-12-04 19:41   ` Jonathan BISSON
2011-12-11 13:11   ` Bastien
2011-12-11 13:38     ` Christian Moe

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).