From mboxrd@z Thu Jan  1 00:00:00 1970
From: Robert Goldman <rpgoldman@sift.info>
Subject: Re: [Accepted] Make the latex export preprocessor rewrite #+INDEX to
 \index.
Date: Wed, 04 May 2011 10:08:28 -0500
Message-ID: <4DC16BEC.7090609@sift.info>
References: <1303991243-30731-2-git-send-email-rpgoldman@sift.info>
	<20110504075943.46A1743B538@u016822.science.uva.nl>
Reply-To: rpgoldman@sift.info
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([140.186.70.92]:51910)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rpgoldman@sift.info>) id 1QHdgr-0000aV-Ly
	for emacs-orgmode@gnu.org; Wed, 04 May 2011 11:08:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rpgoldman@sift.info>) id 1QHdgq-0000tA-ES
	for emacs-orgmode@gnu.org; Wed, 04 May 2011 11:08:37 -0400
Received: from mpls.sift.info ([75.146.46.193]:45470)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rpgoldman@sift.info>) id 1QHdgq-0000t0-9Z
	for emacs-orgmode@gnu.org; Wed, 04 May 2011 11:08:36 -0400
In-Reply-To: <20110504075943.46A1743B538@u016822.science.uva.nl>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: </archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Carsten Dominik <cdominik@newartisans.com>
Cc: emacs-orgmode@gnu.org

On 5/4/11 May 4 -2:59 AM, Carsten Dominik wrote:
> Patch 767 (http://patchwork.newartisans.com/patch/767/) is now "Accepted".
> 
> Maintainer comment: Pushed with modifications.  Some optimization, and the original patch would have stopped at the first #+index line that was missing the entry...  Please verify that it still works
> 
> This relates to the following submission:
> 
> http://mid.gmane.org/%3C1303991243-30731-2-git-send-email-rpgoldman%40sift.info%3E

I think there's a minor problem with the patch.  AFAICT, it binds the
local variable 'entry' but does not read it (instead it uses the match
text directly).

As an aside, it might be desirable to handle the empty index case that
you identified.  E.g.,

(if (> (match-end 1) (match-beginning 1))
    ...rewrite the index entry...
    ;; else
    emit a warning
    rewrite the index entry as the empty string
)

Hope that helps,
Robert