emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* full production use of org-mode: time to say thanks again!
@ 2010-10-09 10:46 Eric S Fraga
  2010-10-09 15:26 ` Carsten Dominik
  2010-10-09 16:48 ` Christian Moe
  0 siblings, 2 replies; 25+ messages in thread
From: Eric S Fraga @ 2010-10-09 10:46 UTC (permalink / raw)
  To: org-mode mailing list

[-- Attachment #1: Type: text/plain, Size: 2140 bytes --]

Hi,

I have spent the last 2 months (or more) working on a serious project
proposal which required the production of a 30+ page document,
including tables, figures, footnotes and cross-references.  The
preparation required working with 20+ people and managing a large
number of tasks.  I used org for the whole process and for the
creation of the actual document.

I just want to say *thanks* to all (Carsten, of course, but also all
the others that have contributed to org and babel) as it made the
whole process as painless as something like this can be!

I used the following features:

- outlining, obviously!  very necessary as the document had a
  pre-defined structure imposed by an external party.
- todo items, including in-line todos [1].
- babel for figures and some in-line calculations
- exporting, including to HTML (for conversion to Word via OOo) for
  allowing colleagues to edit text and to PDF for the actual delivery
  of the document (with very strict page formatting requirements).
- version control, obviously, but not part of org, of course

Everything worked (except for maybe the texi2dvi blip in the past few
days) and did so incredibly smoothly!  Org didn't get in the way and I
could really concentrate on the content instead of the formatting
etc.  Brilliant!

As an aside, I also had to prepare a new set of lecture slides for a
course I teach.  I used org, of course, with beamer support.  Again,
everything worked well.  What was particularly nice this time was that
this particular course requires showing Octave code and the outputs of
such code.  Babel, in combination with the listings latex package, is
an ideal tool for this!  My slides look (in my obviously biased
opinion) incredibly professional.

So, thanks all!

eric

PS - I now need to sleep for the next month or two... ;-)

Footnotes: 
[1]  If I have one niggle to report it is that indenting text after an
     in-line todo doesn't seem to work properly: it indents any
     subsequent paragraphs much too far, lining up with the headline
     text for the in-line todo.  This seems conceptually wrong to me.
     Not a big deal, mind you.


[-- Attachment #2: Type: text/plain, Size: 75 bytes --]

-- 
Eric S Fraga
GnuPG: 8F5C 279D 3907 E14A 5C29  570D C891 93D8 FFFC F67D

[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-09 10:46 full production use of org-mode: time to say thanks again! Eric S Fraga
@ 2010-10-09 15:26 ` Carsten Dominik
  2010-10-09 17:00   ` Nicolas Goaziou
  2010-10-10 17:56   ` Eric S Fraga
  2010-10-09 16:48 ` Christian Moe
  1 sibling, 2 replies; 25+ messages in thread
From: Carsten Dominik @ 2010-10-09 15:26 UTC (permalink / raw)
  To: Eric S Fraga, Nicolas Goaziou; +Cc: org-mode mailing list


On Oct 9, 2010, at 12:46 PM, Eric S Fraga wrote:

> Hi,
>
> I have spent the last 2 months (or more) working on a serious project
> proposal which required the production of a 30+ page document,
> including tables, figures, footnotes and cross-references.  The
> preparation required working with 20+ people and managing a large
> number of tasks.  I used org for the whole process and for the
> creation of the actual document.
>
> I just want to say *thanks* to all (Carsten, of course, but also all
> the others that have contributed to org and babel) as it made the
> whole process as painless as something like this can be!
>
> I used the following features:
>
> - outlining, obviously!  very necessary as the document had a
> pre-defined structure imposed by an external party.
> - todo items, including in-line todos [1].
> - babel for figures and some in-line calculations
> - exporting, including to HTML (for conversion to Word via OOo) for
> allowing colleagues to edit text and to PDF for the actual delivery
> of the document (with very strict page formatting requirements).
> - version control, obviously, but not part of org, of course
>
> Everything worked (except for maybe the texi2dvi blip in the past few
> days) and did so incredibly smoothly!  Org didn't get in the way and I
> could really concentrate on the content instead of the formatting
> etc.  Brilliant!
>
> As an aside, I also had to prepare a new set of lecture slides for a
> course I teach.  I used org, of course, with beamer support.  Again,
> everything worked well.  What was particularly nice this time was that
> this particular course requires showing Octave code and the outputs of
> such code.  Babel, in combination with the listings latex package, is
> an ideal tool for this!  My slides look (in my obviously biased
> opinion) incredibly professional.

Can you publish the slides?  I'd like to take a look!
Maybe even with the source?

Cheers

- Carsten

>
> So, thanks all!
>
> eric
>
> PS - I now need to sleep for the next month or two... ;-)
>
> Footnotes:
> [1]  If I have one niggle to report it is that indenting text after an
>    in-line todo doesn't seem to work properly: it indents any
>    subsequent paragraphs much too far, lining up with the headline
>    text for the in-line todo.  This seems conceptually wrong to me.
>    Not a big deal, mind you.

This is clearly a bug.  Nicolas, could you be persuaded to have a look  
at that?  You have worked on the indentation code reently in  
connection with the plain lists.

If not, let me know and I will take a look at that.

- Carsten

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-09 10:46 full production use of org-mode: time to say thanks again! Eric S Fraga
  2010-10-09 15:26 ` Carsten Dominik
@ 2010-10-09 16:48 ` Christian Moe
  2010-10-09 17:15   ` Nick Dokos
  1 sibling, 1 reply; 25+ messages in thread
From: Christian Moe @ 2010-10-09 16:48 UTC (permalink / raw)
  Cc: org-mode mailing list

What's an inline todo?

Just curious,
Christian

Eric S. Fraga wrote:
> - todo items, including in-line todos [1].
(...)
> Footnotes:
> [1]  If I have one niggle to report it is that indenting text after an
>       in-line todo doesn't seem to work properly: it indents any
>       subsequent paragraphs much too far, lining up with the headline
>       text for the in-line todo.  This seems conceptually wrong to me.
>       Not a big deal, mind you.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-09 15:26 ` Carsten Dominik
@ 2010-10-09 17:00   ` Nicolas Goaziou
  2010-10-10 18:01     ` Eric S Fraga
  2010-10-10 17:56   ` Eric S Fraga
  1 sibling, 1 reply; 25+ messages in thread
From: Nicolas Goaziou @ 2010-10-09 17:00 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: org-mode mailing list

Hello,

>>>>> Carsten Dominik writes:

> On Oct 9, 2010, at 12:46 PM, Eric S Fraga wrote:

>> Footnotes: [1] If I have one niggle to report it is that indenting
>> text after an in-line todo doesn't seem to work properly: it
>> indents any subsequent paragraphs much too far, lining up with the
>> headline text for the in-line todo. This seems conceptually wrong
>> to me. Not a big deal, mind you.

> This is clearly a bug. Nicolas, could you be persuaded to have a
> look at that? You have worked on the indentation code reently in
> connection with the plain lists.

I can have a look at it, but I would need an example to work on as I
never use "inline todo". I don't want to sound too lazy, but could
Eric provide a minimal example to get me started ?

Regards,

-- Nicolas

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-09 16:48 ` Christian Moe
@ 2010-10-09 17:15   ` Nick Dokos
  2010-10-09 19:03     ` Christian Moe
  0 siblings, 1 reply; 25+ messages in thread
From: Nick Dokos @ 2010-10-09 17:15 UTC (permalink / raw)
  To: mail; +Cc: nicholas.dokos, org-mode mailing list

Christian Moe <mail@christianmoe.com> wrote:

> What's an inline todo?
> 
> Just curious,
> Christian
> 

See the commentary in lisp/org-inlinetask.el.

Nick

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-09 17:15   ` Nick Dokos
@ 2010-10-09 19:03     ` Christian Moe
  2010-10-11 19:33       ` Jeff Horn
  0 siblings, 1 reply; 25+ messages in thread
From: Christian Moe @ 2010-10-09 19:03 UTC (permalink / raw)
  To: nicholas.dokos; +Cc: org-mode mailing list

I see. Thanks.

Christian

On 10/9/10 7:15 PM, Nick Dokos wrote:
> Christian Moe<mail@christianmoe.com>  wrote:
>
>> What's an inline todo?
>>
>> Just curious,
>> Christian
>>
>
> See the commentary in lisp/org-inlinetask.el.
>
> Nick
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>


-- 

Christian Moe
E-mail:  mail@christianmoe.com
Website: http://christianmoe.com

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-09 15:26 ` Carsten Dominik
  2010-10-09 17:00   ` Nicolas Goaziou
@ 2010-10-10 17:56   ` Eric S Fraga
  2010-10-11  8:01     ` Carsten Dominik
  1 sibling, 1 reply; 25+ messages in thread
From: Eric S Fraga @ 2010-10-10 17:56 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: org-mode mailing list

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

On Sat, 9 Oct 2010 17:26:43 +0200, Carsten Dominik <carsten.dominik@gmail.com> wrote:
> On Oct 9, 2010, at 12:46 PM, Eric S Fraga wrote:

[...]

> > As an aside, I also had to prepare a new set of lecture slides for a
> > course I teach.  I used org, of course, with beamer support.  Again,
> > everything worked well.  What was particularly nice this time was that
> > this particular course requires showing Octave code and the outputs of
> > such code.  Babel, in combination with the listings latex package, is
> > an ideal tool for this!  My slides look (in my obviously biased
> > opinion) incredibly professional.
> 
> Can you publish the slides?  I'd like to take a look!
> Maybe even with the source?

I can't as such (some copyright material) but I can give an
illustration of the type of slide (attached) that babel now allows me
to do every so easily!  From a pedagogical point of view, having code
which runs and automatically creates the content to be presented is
fantastic.  No errors in transcription etc.


[-- Attachment #2: octave.pdf --]
[-- Type: application/pdf, Size: 94788 bytes --]

[-- Attachment #3: Type: text/plain, Size: 2913 bytes --]

#+ -*- coding: iso-8859-1; -*-
#+TITLE:     Numerical methods with Octave
#+AUTHOR:    Eric S Fraga
#+EMAIL:     e.fraga@ucl.ac.uk
#+DATE:      2010.10.10 18:54:55

* COMMENT Preamble						   :noexport:
#+DESCRIPTION: 
#+KEYWORDS: 
#+LANGUAGE:  en
#+OPTIONS:   H:3 num:t toc:nil \n:nil @:t ::t |:t ^:t -:t f:t *:t <:t
#+OPTIONS:   TeX:t LaTeX:t skip:nil d:nil todo:t pri:nil tags:not-in-toc
#+INFOJS_OPT: view:nil toc:nil ltoc:t mouse:underline buttons:0 path:http://orgmode.org/org-info.js
#+EXPORT_SELECT_TAGS: export
#+EXPORT_EXCLUDE_TAGS: noexport
#+LINK_UP:   
#+LINK_HOME: 
#+XSLT: 

#+startup: beamer
#+LaTeX_CLASS: beamer
#+LaTeX_CLASS_OPTIONS: [bigger,t]

#+BEAMER_FRAME_LEVEL: 2

#+latex_header: \definecolor{verylightgray}{rgb}{0.93,0.93,1.0}
#+latex_header: \mode<beamer>{\usetheme{progressbar}}
#+latex_header: \mode<handout>{\usecolortheme[rgb={0.5,0.5,0.5}]{structure}\usetheme[secheader]{Boadilla}\usepackage{pgfpages}\pgfpagesuselayout{4 on 1}[a4paper,landscape,border shrink=5mm]}
#+latex_header: \usepackage[absolute,overlay]{textpos}\setlength{\TPHorizModule}{1mm}\setlength{\TPVertModule}{1mm}\newcommand{\UCL}{\begin{textblock}{14}(120.0,0.0)\pgfuseimage{ucllogo}\end{textblock}}
#+ latex_header: \AtBeginSection[]{\begin{frame}<beamer>\frametitle{Topic}\tableofcontents[currentsection]\end{frame}}

#+latex_header: \usepackage{algorithm}
#+latex_header: \usepackage{algorithmic} %[noend] option possible
#+latex_header: \renewcommand{\algorithmicrequire}{\textbf{Given:}}
#+latex_header: \renewcommand{\algorithmicensure}{\textbf{Outputs:}}
#+latex_header: \usepackage{alltt}
#+latex_header: \usepackage{cancel}

#+ ------------------------ COMMANDS -------------------------
#+latex_header: \newcommand{\D}{{\mbox{d}}}
#+latex_header: \newcommand{\Diff}[2]{\frac{\D }{\D #2}#1}
#+latex_header: \newcommand{\diff}[2]{\frac{\D #1}{\D #2}}
#+latex_header: \newcommand{\HS}{\hspace*{1cm}}

#+latex_header: \date{$Revision: 1.7 $}\renewcommand{\date}[1]{}

#+ ------------------------ LISTINGS -------------------------
#+latex_header: \lstset{keywordstyle=\color{blue},commentstyle=\color{black!50!white},identifierstyle=\color{red!60!black}}

#+COLUMNS: %20ITEM %13BEAMER_env(Env) %6BEAMER_envargs(Args) %4BEAMER_col(Col) %7BEAMER_extra(Extra)

* Octave

*** Newton's method
***** The code						      :BMCOL:B_block:
      :PROPERTIES:
      :BEAMER_col: 0.5
      :BEAMER_env: block
      :END:
#+source: newtons-method
#+begin_src octave :exports both :results output
f = @(x) x^2 - 2;
df = @(x) 2*x;
x = 2 % initial guess
y = f(x)
while abs(y)>1e-5
  dy = df(x);
  x = x - y/dy
  y = f(x)
end
#+end_src
***** The output					      :BMCOL:B_block:
      :PROPERTIES:
      :BEAMER_col: 0.5
      :BEAMER_env: block
      :BEAMER_envargs: <2->
      :END:
#+results: newtons-method
: x =  2
: y =  2
: x =  1.5000
: y =  0.25000
: x =  1.4167
: y =  0.0069444
: x =  1.4142
: y =  6.0073e-06

[-- Attachment #4: Type: text/plain, Size: 1 bytes --]



[-- Attachment #5: Type: text/plain, Size: 75 bytes --]

-- 
Eric S Fraga
GnuPG: 8F5C 279D 3907 E14A 5C29  570D C891 93D8 FFFC F67D

[-- Attachment #6: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-09 17:00   ` Nicolas Goaziou
@ 2010-10-10 18:01     ` Eric S Fraga
  2010-10-11  6:34       ` Nicolas Goaziou
  0 siblings, 1 reply; 25+ messages in thread
From: Eric S Fraga @ 2010-10-10 18:01 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: org-mode mailing list, Carsten Dominik

[-- Attachment #1: Type: text/plain, Size: 971 bytes --]

On Sat, 09 Oct 2010 19:00:29 +0200, Nicolas Goaziou <n.goaziou@gmail.com> wrote:
> 
> Hello,
> 
> >>>>> Carsten Dominik writes:
> 
> > On Oct 9, 2010, at 12:46 PM, Eric S Fraga wrote:
> 
> >> Footnotes: [1] If I have one niggle to report it is that indenting
> >> text after an in-line todo doesn't seem to work properly: it
> >> indents any subsequent paragraphs much too far, lining up with the
> >> headline text for the in-line todo. This seems conceptually wrong
> >> to me. Not a big deal, mind you.
> 
> > This is clearly a bug. Nicolas, could you be persuaded to have a
> > look at that? You have worked on the indentation code reently in
> > connection with the plain lists.
> 
> I can have a look at it, but I would need an example to work on as I
> never use "inline todo". I don't want to sound too lazy, but could
> Eric provide a minimal example to get me started ?
> 
> Regards,
> 
> -- Nicolas

Gladly.  Attached is a very small example, self-documented!

[-- Attachment #2: Type: text/plain, Size: 1015 bytes --]

# -*- mode: org; mode: auto-fill; -*-
#+TITLE:     test.org
#+AUTHOR:    Eric S Fraga
#+EMAIL:     e.fraga@ucl.ac.uk
#+DATE:      2010.10.10 19:00:34
#+LANGUAGE:  en
#+OPTIONS:   H:3 num:t toc:t \n:nil @:t ::t |:t ^:t -:t f:t *:t TeX:t LaTeX:t skip:nil d:nil tags:not-in-toc
#+INFOJS_OPT: view:nil toc:nil ltoc:t mouse:underline buttons:0 path:http://orgmode.org/org-info.js
#+EXPORT_SELECT_TAGS: export
#+EXPORT_EXCUDE_TAGS: noexport
#+LINK_UP:
#+LINK_HOME:
#+DRAWERS: HIDDEN hidden extra details
#+STARTUP: lognotedone lognoteclock-out

#+ STARTUP: indent

* Introduction
The introduction, most obviously introduces
material in an introductory manner.
***************************** TODO Remember to expand this section
***************************** END

			      The following text is indented to line
			      up with the in-line todo heading which
			      it should not be.  The whole point of an
			      in-line todo is that it is not meant to
			      disrupt the flow of the rest of the
			      document.

[-- Attachment #3: Type: text/plain, Size: 75 bytes --]

-- 
Eric S Fraga
GnuPG: 8F5C 279D 3907 E14A 5C29  570D C891 93D8 FFFC F67D

[-- Attachment #4: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-10 18:01     ` Eric S Fraga
@ 2010-10-11  6:34       ` Nicolas Goaziou
  2010-10-11  8:04         ` Carsten Dominik
                           ` (2 more replies)
  0 siblings, 3 replies; 25+ messages in thread
From: Nicolas Goaziou @ 2010-10-11  6:34 UTC (permalink / raw)
  To: Eric S Fraga; +Cc: Eric S Fraga, org-mode mailing list, Carsten Dominik

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

Hello,

Could you try the following patch and tell me if it fixes your issue?

As a side note (to maintainers), the second patch isn't really needed,
but I thought, while I was at it, that it would make sense
(`org-inlinetask-min-level' doesn't need to be a boolean).

Regards,

-- Nicolas


[-- Attachment #2: 0001-Fix-indentation-of-text-after-an-inline-task.patch --]
[-- Type: text/plain, Size: 3467 bytes --]

From ab4b86b56654887be564d0519dd9e4407d9fc732 Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <n.goaziou@gmail.com>
Date: Mon, 11 Oct 2010 08:10:31 +0200
Subject: [PATCH 1/2] Fix indentation of text after an inline task.

* org.el (org-indent-line-function): Conditionnaly indent text inside
  and outside indented tasks. Also skip any list above point.
* org-inlinetask.el (org-inlinetask-in-task-p): new function.
---
 lisp/org-inlinetask.el |   16 ++++++++++++++++
 lisp/org.el            |   21 ++++++++++-----------
 2 files changed, 26 insertions(+), 11 deletions(-)

diff --git a/lisp/org-inlinetask.el b/lisp/org-inlinetask.el
index fce515d..e18dce8 100644
--- a/lisp/org-inlinetask.el
+++ b/lisp/org-inlinetask.el
@@ -129,6 +129,22 @@ If prefix arg NO-STATE is set, ignore `org-inlinetask-defaut-state'."
   (end-of-line -1))
 (define-key org-mode-map "\C-c\C-xt" 'org-inlinetask-insert-task)
 
+(defun org-inlinetask-in-task-p ()
+  "Return true if point is inside an inline task."
+  (save-excursion
+    (let* ((nstars (if org-odd-levels-only
+		       (1- (* 2 (or org-inlinetask-min-level 200)))
+		     (or org-inlinetask-min-level 200)))
+	   (stars-re (concat "^\\(?:\\*\\{"
+			     (format "%d" (- nstars 1))
+			     ",\\}\\)[ \t]+"))
+	   (task-beg-re (concat stars-re "\\(?:.*\\)"))
+	   (task-end-re (concat stars-re "\\(?:END\\|end\\)")))
+      (beginning-of-line)
+      (or (looking-at task-beg-re)
+	  (and (re-search-forward "^\\*+[ \t]+" nil t)
+	       (progn (beginning-of-line) (looking-at task-end-re)))))))
+
 (defvar htmlp)  ; dynamically scoped into the next function
 (defvar latexp) ; dynamically scoped into the next function
 (defun org-inlinetask-export-handler ()
diff --git a/lisp/org.el b/lisp/org.el
index a80286f..d9e26e9 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -18601,6 +18601,8 @@ which make use of the date at the cursor."
 	 (itemp (org-at-item-p))
 	 (case-fold-search t)
 	 (org-drawer-regexp (or org-drawer-regexp "\000"))
+	 (inline-task-p (and (featurep 'org-inlinetask)
+			     (org-inlinetask-in-task-p)))
 	 column bpos bcol tpos tcol bullet btype bullet-type)
     ;; Find the previous relevant line
     (beginning-of-line 1)
@@ -18656,7 +18658,14 @@ which make use of the date at the cursor."
      ;; what to do.
      (t
       (beginning-of-line 0)
-      (while (and (not (bobp)) (looking-at "[ \t]*[\n:#|]")
+      (while (and (not (bobp))
+		  ;; skip comments, verbatim, empty lines, tables,
+		  ;; inline tasks
+		  (or (looking-at "[ \t]*[\n:#|]")
+		      (and (org-in-item-p) (goto-char (org-list-top-point)))
+		      (and (not inline-task-p)
+			   (featurep 'org-inlinetask)
+			   (org-inlinetask-in-task-p)))
       		  (not (looking-at "[ \t]*:END:"))
       		  (not (looking-at org-drawer-regexp)))
       	(beginning-of-line 0))
@@ -18675,16 +18684,6 @@ which make use of the date at the cursor."
        ((looking-at "\\([ \t]*\\):END:")
 	(goto-char (match-end 1))
 	(setq column (current-column)))
-       ;; There was a list that since ended: indent relatively to
-       ;; current heading.
-       ((org-in-item-p)
-	(outline-previous-heading)
-	(if (and org-adapt-indentation
-		 (looking-at "\\*+[ \t]+"))
-	    (progn
-	      (goto-char (match-end 0))
-	      (setq column (current-column)))
-	  (setq column 0)))
        ;; Else, nothing noticeable found: get indentation and go on.
        (t (setq column (org-get-indentation))))))
     (goto-char pos)
-- 
1.7.3.1


[-- Attachment #3: 0002-inlinetask-Make-org-inlinetask-min-level-an-integer-.patch --]
[-- Type: text/plain, Size: 3753 bytes --]

From 89caeaa34fb2e76626954226e51f29590ecaba91 Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <n.goaziou@gmail.com>
Date: Mon, 11 Oct 2010 08:25:53 +0200
Subject: [PATCH 2/2] inlinetask: Make `org-inlinetask-min-level' an integer instead of a boolean.

* org-footnote.el (org-footnote-normalize): Remove unnecessary check
  for org-inlinetask-min-level.
* org-inlinetask.el (org-inlinetask-min-level): Variable is now of
  type integer.
* org-inlinetask.el (org-inlinetask-in-task-p): Remove unnecessary check
  for org-inlinetask-min-level.
* org-inlinetask.el (org-inlinetask-export-handler): Remove unnecessary check
  for org-inlinetask-min-level.
* org-inlinetask.el (org-inlinetask-fontify): Remove unnecessary check
  for org-inlinetask-min-level.
---
 lisp/org-footnote.el   |    1 -
 lisp/org-inlinetask.el |   14 +++++++-------
 lisp/org.el            |    1 -
 3 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/lisp/org-footnote.el b/lisp/org-footnote.el
index 36fcfb2..55c7665 100644
--- a/lisp/org-footnote.el
+++ b/lisp/org-footnote.el
@@ -358,7 +358,6 @@ referenced sequence."
   ;; This is based on Paul's function, but rewritten.
   (let* ((limit-level
 	  (and (boundp 'org-inlinetask-min-level)
-	       org-inlinetask-min-level
 	       (1- org-inlinetask-min-level)))
 	 (nstars (and limit-level
 		      (if org-odd-levels-only
diff --git a/lisp/org-inlinetask.el b/lisp/org-inlinetask.el
index e18dce8..54b997e 100644
--- a/lisp/org-inlinetask.el
+++ b/lisp/org-inlinetask.el
@@ -90,7 +90,7 @@ or to a number smaller than this one.  In fact, when `org-cycle-max-level' is
 not set, it will be assumed to be one less than the value of smaller than
 the value of this variable."
   :group 'org-inlinetask
-  :type 'boolean)
+  :type 'integer)
 
 (defcustom org-inlinetask-export t
   "Non-nil means export inline tasks.
@@ -133,8 +133,8 @@ If prefix arg NO-STATE is set, ignore `org-inlinetask-defaut-state'."
   "Return true if point is inside an inline task."
   (save-excursion
     (let* ((nstars (if org-odd-levels-only
-		       (1- (* 2 (or org-inlinetask-min-level 200)))
-		     (or org-inlinetask-min-level 200)))
+		       (1- (* 2 org-inlinetask-min-level))
+		     org-inlinetask-min-level))
 	   (stars-re (concat "^\\(?:\\*\\{"
 			     (format "%d" (- nstars 1))
 			     ",\\}\\)[ \t]+"))
@@ -152,8 +152,8 @@ If prefix arg NO-STATE is set, ignore `org-inlinetask-defaut-state'."
 Either remove headline and meta data, or do special formatting."
   (goto-char (point-min))
   (let* ((nstars (if org-odd-levels-only
-		     (1- (* 2 (or org-inlinetask-min-level 200)))
-		   (or org-inlinetask-min-level 200)))
+		     (1- (* 2 org-inlinetask-min-level))
+		   org-inlinetask-min-level))
 	 (re1 (format "^\\(\\*\\{%d,\\}\\) .*\n" nstars))
 	 (re2 (concat "^[ \t]*" org-keyword-time-regexp))
 	 headline beg end stars content indent)
@@ -226,8 +226,8 @@ Either remove headline and meta data, or do special formatting."
 (defun org-inlinetask-fontify (limit)
   "Fontify the inline tasks."
   (let* ((nstars (if org-odd-levels-only
-		     (1- (* 2 (or org-inlinetask-min-level 200)))
-		   (or org-inlinetask-min-level 200)))
+		     (1- (* 2 org-inlinetask-min-level))
+		   org-inlinetask-min-level))
 	 (re (concat "^\\(\\*\\)\\(\\*\\{"
 		    (format "%d" (- nstars 3))
 		    ",\\}\\)\\(\\*\\* .*\\)")))
diff --git a/lisp/org.el b/lisp/org.el
index d9e26e9..b6805cc 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -5768,7 +5768,6 @@ in special contexts.
     (let* ((limit-level
 	    (or org-cycle-max-level
 		(and (boundp 'org-inlinetask-min-level)
-		     org-inlinetask-min-level
 		     (1- org-inlinetask-min-level))))
 	   (nstars (and limit-level
 		      (if org-odd-levels-only
-- 
1.7.3.1


[-- Attachment #4: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-10 17:56   ` Eric S Fraga
@ 2010-10-11  8:01     ` Carsten Dominik
  2010-10-11  9:01       ` Eric S Fraga
  0 siblings, 1 reply; 25+ messages in thread
From: Carsten Dominik @ 2010-10-11  8:01 UTC (permalink / raw)
  To: Eric S Fraga; +Cc: org-mode mailing list


On Oct 10, 2010, at 7:56 PM, Eric S Fraga wrote:

> On Sat, 9 Oct 2010 17:26:43 +0200, Carsten Dominik <carsten.dominik@gmail.com 
> > wrote:
>> On Oct 9, 2010, at 12:46 PM, Eric S Fraga wrote:
>
> [...]
>
>>> As an aside, I also had to prepare a new set of lecture slides for a
>>> course I teach.  I used org, of course, with beamer support.  Again,
>>> everything worked well.  What was particularly nice this time was  
>>> that
>>> this particular course requires showing Octave code and the  
>>> outputs of
>>> such code.  Babel, in combination with the listings latex package,  
>>> is
>>> an ideal tool for this!  My slides look (in my obviously biased
>>> opinion) incredibly professional.
>>
>> Can you publish the slides?  I'd like to take a look!
>> Maybe even with the source?
>
> I can't as such (some copyright material) but I can give an
> illustration of the type of slide (attached) that babel now allows me
> to do every so easily!  From a pedagogical point of view, having code
> which runs and automatically creates the content to be presented is
> fantastic.  No errors in transcription etc.

Thanks, this looks really good.  I am wondering if I can recruit you  
to add such an example including the required babel setup to your  
BEAMER tutorial?

- Carsten

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-11  6:34       ` Nicolas Goaziou
@ 2010-10-11  8:04         ` Carsten Dominik
  2010-10-11 11:15           ` Paul Mead
                             ` (4 more replies)
  2010-10-11 15:33         ` indenting after inline task (was Re: full production use of org-mode: time to say thanks again!) Eric S Fraga
  2010-10-14  8:16         ` full production use of org-mode: time to say thanks again! Carsten Dominik
  2 siblings, 5 replies; 25+ messages in thread
From: Carsten Dominik @ 2010-10-11  8:04 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: Eric S Fraga, org-mode mailing list

Hi,

On Oct 11, 2010, at 8:34 AM, Nicolas Goaziou wrote:

> Hello,
>
> Could you try the following patch and tell me if it fixes your issue?

A quick test shows that things seem to work well in inlinetasks which  
are properly ended with an END line.

There is also a dirty form of inline tasks which allows
only a planning line (SCHEDULED etc) and one or several
drawers directly after the task line, and then no
END line is necessary.  But I guess it is fair
to force the END line if you do want to have
proper indentation.

Eric Fraga, have you tested the patch yet?  Please do
so when you wake up from your two-week sleep, so that
we can check this in.

Thanks Nicolas!

I am seeing now two things that should be added:

   - M-RET after inline tasks should ignore the inline task
     and make a new entry with normal indentation
   - Maybe I should treat inline tasks with proper END
     statement as a drawer and fold it?  Comments?


>
> As a side note (to maintainers), the second patch isn't really needed,
> but I thought, while I was at it, that it would make sense
> (`org-inlinetask-min-level' doesn't need to be a boolean).

Hmmm, what happens is a user has customized this variable and it has a  
value nil.  I guess then your patch will break things?

So I think we need to keep testing the value in the code, but it is OK  
to change the customize type.

>
> Regards,
>
> -- Nicolas
>
> <0001-Fix-indentation-of-text-after-an-inline-task.patch><0002- 
> inlinetask-Make-org-inlinetask-min-level-an-integer-.patch>

- Carsten

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-11  8:01     ` Carsten Dominik
@ 2010-10-11  9:01       ` Eric S Fraga
  0 siblings, 0 replies; 25+ messages in thread
From: Eric S Fraga @ 2010-10-11  9:01 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: org-mode mailing list

[-- Attachment #1: Type: text/plain, Size: 716 bytes --]

On Mon, 11 Oct 2010 10:01:53 +0200, Carsten Dominik <carsten.dominik@gmail.com> wrote:
> 
> 
> On Oct 10, 2010, at 7:56 PM, Eric S Fraga wrote:

[...]

> >
> > I can't as such (some copyright material) but I can give an
> > illustration of the type of slide (attached) that babel now allows me
> > to do every so easily!  From a pedagogical point of view, having code
> > which runs and automatically creates the content to be presented is
> > fantastic.  No errors in transcription etc.
> 
> Thanks, this looks really good.  I am wondering if I can recruit you
> to add such an example including the required babel setup to your
> BEAMER tutorial?
> 
> - Carsten
> 
> 
> 

I'd be happy to!  On my todo list now ;-)

[-- Attachment #2: Type: text/plain, Size: 75 bytes --]

-- 
Eric S Fraga
GnuPG: 8F5C 279D 3907 E14A 5C29  570D C891 93D8 FFFC F67D

[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-11  8:04         ` Carsten Dominik
@ 2010-10-11 11:15           ` Paul Mead
  2010-10-11 15:12           ` Nicolas Goaziou
                             ` (3 subsequent siblings)
  4 siblings, 0 replies; 25+ messages in thread
From: Paul Mead @ 2010-10-11 11:15 UTC (permalink / raw)
  To: emacs-orgmode

Carsten Dominik <carsten.dominik@gmail.com> writes:

> I am seeing now two things that should be added:
>
>   - M-RET after inline tasks should ignore the inline task
>     and make a new entry with normal indentation
>   - Maybe I should treat inline tasks with proper END
>     statement as a drawer and fold it?  Comments?

I was thinking the other day that this would be a useful change - I was
wondering why it didn't work the same as other similar structures, so a
vote from me for this change.

Paul

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-11  8:04         ` Carsten Dominik
  2010-10-11 11:15           ` Paul Mead
@ 2010-10-11 15:12           ` Nicolas Goaziou
  2010-10-11 15:16           ` Nicolas Goaziou
                             ` (2 subsequent siblings)
  4 siblings, 0 replies; 25+ messages in thread
From: Nicolas Goaziou @ 2010-10-11 15:12 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: Eric S Fraga, org-mode mailing list

>>>>> Carsten Dominik writes:

>> As a side note (to maintainers), the second patch isn't really
>> needed, but I thought, while I was at it, that it would make sense
>> (`org-inlinetask-min-level' doesn't need to be a boolean).

> Hmmm, what happens is a user has customized this variable and it has
> a value nil. I guess then your patch will break things?

Probably. I wasn't sure a nil value would have any meaning and thus
that anyone would set it so.

Regards,

-- Nicolas

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-11  8:04         ` Carsten Dominik
  2010-10-11 11:15           ` Paul Mead
  2010-10-11 15:12           ` Nicolas Goaziou
@ 2010-10-11 15:16           ` Nicolas Goaziou
  2010-10-11 15:37           ` Eric S Fraga
  2010-10-14  8:32           ` Carsten Dominik
  4 siblings, 0 replies; 25+ messages in thread
From: Nicolas Goaziou @ 2010-10-11 15:16 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: Eric S Fraga, org-mode mailing list

>>>>> Carsten Dominik writes:

>> As a side note (to maintainers), the second patch isn't really
>> needed, but I thought, while I was at it, that it would make sense
>> (`org-inlinetask-min-level' doesn't need to be a boolean).

> Hmmm, what happens is a user has customized this variable and it has
> a value nil. I guess then your patch will break things?

Probably. I wasn't sure a nil value would have any meaning and thus
that anyone would set it so.

Regards,

-- Nicolas

^ permalink raw reply	[flat|nested] 25+ messages in thread

* indenting after inline task (was Re: full production use of org-mode: time to say thanks again!)
  2010-10-11  6:34       ` Nicolas Goaziou
  2010-10-11  8:04         ` Carsten Dominik
@ 2010-10-11 15:33         ` Eric S Fraga
  2010-10-14  8:16         ` full production use of org-mode: time to say thanks again! Carsten Dominik
  2 siblings, 0 replies; 25+ messages in thread
From: Eric S Fraga @ 2010-10-11 15:33 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: org-mode mailing list, Carsten Dominik

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

On Mon, 11 Oct 2010 08:34:53 +0200, Nicolas Goaziou <n.goaziou@gmail.com> wrote:
> 
> Hello,
> 
> Could you try the following patch and tell me if it fixes your issue?

Works perfectly.  Thanks!

[-- Attachment #2: Type: text/plain, Size: 75 bytes --]

-- 
Eric S Fraga
GnuPG: 8F5C 279D 3907 E14A 5C29  570D C891 93D8 FFFC F67D

[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-11  8:04         ` Carsten Dominik
                             ` (2 preceding siblings ...)
  2010-10-11 15:16           ` Nicolas Goaziou
@ 2010-10-11 15:37           ` Eric S Fraga
  2010-10-14  8:32           ` Carsten Dominik
  4 siblings, 0 replies; 25+ messages in thread
From: Eric S Fraga @ 2010-10-11 15:37 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: org-mode mailing list, Nicolas Goaziou

[-- Attachment #1: Type: text/plain, Size: 1734 bytes --]

On Mon, 11 Oct 2010 10:04:15 +0200, Carsten Dominik <carsten.dominik@gmail.com> wrote:
> 
> Hi,
> 
> On Oct 11, 2010, at 8:34 AM, Nicolas Goaziou wrote:
> 
> > Hello,
> >
> > Could you try the following patch and tell me if it fixes your issue?
> 
> A quick test shows that things seem to work well in inlinetasks which
> are properly ended with an END line.
> 
> There is also a dirty form of inline tasks which allows
> only a planning line (SCHEDULED etc) and one or several
> drawers directly after the task line, and then no
> END line is necessary.  But I guess it is fair
> to force the END line if you do want to have
> proper indentation.

That requirement would seem to make sense.

> Eric Fraga, have you tested the patch yet?  Please do
> so when you wake up from your two-week sleep, so that
> we can check this in.

I have tested it and it seems to work fine.  I've not seen anything
major break but I haven't done a thorough test.

> I am seeing now two things that should be added:
> 
>   - M-RET after inline tasks should ignore the inline task
>     and make a new entry with normal indentation

Yes, that would be nice especially as it takes quite a few TABs to get
back to a proper level and sometimes I cannot tell what that level
should have been...  Actually, it might be nice if the TAB immediately
after a M-RET would go back to the next previously used level in the
hierarchy?  Although this might be tricky...

>   - Maybe I should treat inline tasks with proper END
>     statement as a drawer and fold it?  Comments?

Could be useful but it's not critical for me: I don't tend to put too
much text between the start and end of inline tasks so it's not too
intrusive.

Thanks to both you and Nicolas,
eric

[-- Attachment #2: Type: text/plain, Size: 75 bytes --]

-- 
Eric S Fraga
GnuPG: 8F5C 279D 3907 E14A 5C29  570D C891 93D8 FFFC F67D

[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-09 19:03     ` Christian Moe
@ 2010-10-11 19:33       ` Jeff Horn
  2010-10-12  8:04         ` Carsten Dominik
                           ` (2 more replies)
  0 siblings, 3 replies; 25+ messages in thread
From: Jeff Horn @ 2010-10-11 19:33 UTC (permalink / raw)
  To: mail; +Cc: nicholas.dokos, org-mode mailing list

Christian and Nick,

I suppose the advantage of inline tasks is that they appear even when
the document is folded? So far I've been moving/refiling todos into a
top-level Tasks header in each document to get this sort of behavior.
But this sounds like less overhead, so it is a plus in that regard.

Jeff

On Sat, Oct 9, 2010 at 3:03 PM, Christian Moe <mail@christianmoe.com> wrote:
> I see. Thanks.
>
> Christian
>
> On 10/9/10 7:15 PM, Nick Dokos wrote:
>>
>> Christian Moe<mail@christianmoe.com>  wrote:
>>
>>> What's an inline todo?
>>>
>>> Just curious,
>>> Christian
>>>
>>
>> See the commentary in lisp/org-inlinetask.el.
>>
>> Nick
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Please use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>
>
>
> --
>
> Christian Moe
> E-mail:  mail@christianmoe.com
> Website: http://christianmoe.com
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>



-- 
Jeffrey Horn
Graduate Lecturer and PhD Student in Economics
George Mason University

(704) 271-4797
jhorn@gmu.edu
jrhorn424@gmail.com

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-11 19:33       ` Jeff Horn
@ 2010-10-12  8:04         ` Carsten Dominik
  2010-10-12  8:08         ` Eric S Fraga
  2010-10-19  8:27         ` Sébastien Vauban
  2 siblings, 0 replies; 25+ messages in thread
From: Carsten Dominik @ 2010-10-12  8:04 UTC (permalink / raw)
  To: Jeff Horn; +Cc: nicholas.dokos, org-mode mailing list, mail


On Oct 11, 2010, at 9:33 PM, Jeff Horn wrote:

> Christian and Nick,
>
> I suppose the advantage of inline tasks is that they appear even when
> the document is folded?

The main advantage is that you can note a task without forcing changes  
to the document structure.

- Carsten

> So far I've been moving/refiling todos into a
> top-level Tasks header in each document to get this sort of behavior.
> But this sounds like less overhead, so it is a plus in that regard.
>
> Jeff
>
> On Sat, Oct 9, 2010 at 3:03 PM, Christian Moe  
> <mail@christianmoe.com> wrote:
>> I see. Thanks.
>>
>> Christian
>>
>> On 10/9/10 7:15 PM, Nick Dokos wrote:
>>>
>>> Christian Moe<mail@christianmoe.com>  wrote:
>>>
>>>> What's an inline todo?
>>>>
>>>> Just curious,
>>>> Christian
>>>>
>>>
>>> See the commentary in lisp/org-inlinetask.el.
>>>
>>> Nick
>>>
>>> _______________________________________________
>>> Emacs-orgmode mailing list
>>> Please use `Reply All' to send replies to the list.
>>> Emacs-orgmode@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>>
>>
>>
>> --
>>
>> Christian Moe
>> E-mail:  mail@christianmoe.com
>> Website: http://christianmoe.com
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Please use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>
>
>
>
> -- 
> Jeffrey Horn
> Graduate Lecturer and PhD Student in Economics
> George Mason University
>
> (704) 271-4797
> jhorn@gmu.edu
> jrhorn424@gmail.com
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-11 19:33       ` Jeff Horn
  2010-10-12  8:04         ` Carsten Dominik
@ 2010-10-12  8:08         ` Eric S Fraga
  2010-10-19  8:27         ` Sébastien Vauban
  2 siblings, 0 replies; 25+ messages in thread
From: Eric S Fraga @ 2010-10-12  8:08 UTC (permalink / raw)
  To: Jeff Horn; +Cc: org-mode mailing list

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

On Mon, 11 Oct 2010 15:33:37 -0400, Jeff Horn <jrhorn424@gmail.com> wrote:
> 
> Christian and Nick,
> 
> I suppose the advantage of inline tasks is that they appear even when
> the document is folded? So far I've been moving/refiling todos into a
> top-level Tasks header in each document to get this sort of behavior.
> But this sounds like less overhead, so it is a plus in that regard.

The main advantage for me is simply one of not having to interrupt my
flow of writing.

[-- Attachment #2: Type: text/plain, Size: 75 bytes --]

-- 
Eric S Fraga
GnuPG: 8F5C 279D 3907 E14A 5C29  570D C891 93D8 FFFC F67D

[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-11  6:34       ` Nicolas Goaziou
  2010-10-11  8:04         ` Carsten Dominik
  2010-10-11 15:33         ` indenting after inline task (was Re: full production use of org-mode: time to say thanks again!) Eric S Fraga
@ 2010-10-14  8:16         ` Carsten Dominik
  2 siblings, 0 replies; 25+ messages in thread
From: Carsten Dominik @ 2010-10-14  8:16 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: Eric S Fraga, org-mode mailing list

I have now applied the first of the two patches, but not the second.   
Thanks Nicolas!

- Carsten

On Oct 11, 2010, at 8:34 AM, Nicolas Goaziou wrote:

> Hello,
>
> Could you try the following patch and tell me if it fixes your issue?
>
> As a side note (to maintainers), the second patch isn't really needed,
> but I thought, while I was at it, that it would make sense
> (`org-inlinetask-min-level' doesn't need to be a boolean).
>
> Regards,
>
> -- Nicolas
>
> <0001-Fix-indentation-of-text-after-an-inline-task.patch><0002- 
> inlinetask-Make-org-inlinetask-min-level-an-integer-.patch>

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-11  8:04         ` Carsten Dominik
                             ` (3 preceding siblings ...)
  2010-10-11 15:37           ` Eric S Fraga
@ 2010-10-14  8:32           ` Carsten Dominik
  4 siblings, 0 replies; 25+ messages in thread
From: Carsten Dominik @ 2010-10-14  8:32 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: org-mode mailing list, Eric S Fraga, Nicolas Goaziou


On Oct 11, 2010, at 10:04 AM, Carsten Dominik wrote:

> Hi,
>
> On Oct 11, 2010, at 8:34 AM, Nicolas Goaziou wrote:
>
>> Hello,
>>
>> Could you try the following patch and tell me if it fixes your issue?
>
> A quick test shows that things seem to work well in inlinetasks  
> which are properly ended with an END line.
>
> There is also a dirty form of inline tasks which allows
> only a planning line (SCHEDULED etc) and one or several
> drawers directly after the task line, and then no
> END line is necessary.  But I guess it is fair
> to force the END line if you do want to have
> proper indentation.
>
> Eric Fraga, have you tested the patch yet?  Please do
> so when you wake up from your two-week sleep, so that
> we can check this in.
>
> Thanks Nicolas!
>
> I am seeing now two things that should be added:
>
>  - M-RET after inline tasks should ignore the inline task
>    and make a new entry with normal indentation


This I have now implemented

>  - Maybe I should treat inline tasks with proper END
>    statement as a drawer and fold it?  Comments?

This not yet - is more complicated....

- Carsten

>
>
>>
>> As a side note (to maintainers), the second patch isn't really  
>> needed,
>> but I thought, while I was at it, that it would make sense
>> (`org-inlinetask-min-level' doesn't need to be a boolean).
>
> Hmmm, what happens is a user has customized this variable and it has  
> a value nil.  I guess then your patch will break things?
>
> So I think we need to keep testing the value in the code, but it is  
> OK to change the customize type.
>
>>
>> Regards,
>>
>> -- Nicolas
>>
>> <0001-Fix-indentation-of-text-after-an-inline-task.patch><0002- 
>> inlinetask-Make-org-inlinetask-min-level-an-integer-.patch>
>
> - Carsten
>
>
>

- Carsten

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-11 19:33       ` Jeff Horn
  2010-10-12  8:04         ` Carsten Dominik
  2010-10-12  8:08         ` Eric S Fraga
@ 2010-10-19  8:27         ` Sébastien Vauban
  2010-10-20  2:45           ` Jeff Horn
  2 siblings, 1 reply; 25+ messages in thread
From: Sébastien Vauban @ 2010-10-19  8:27 UTC (permalink / raw)
  To: emacs-orgmode-mXXj517/zsQ

Hi,

Jeff Horn wrote:
>>>> What's an inline todo?
>>>
>>> See the commentary in lisp/org-inlinetask.el.
>
> I suppose the advantage of inline tasks is that they appear even when the
> document is folded?

I don't have that behavior. When folded, I only see:

- all level-1 headlines, or
- all headlines (after second S-TAB)

Did I miss some customization?

As well, on Org from yesterday, I just exported a small document to *LaTeX*.

#+begin_src org
*************** TODO Vérifier qu'il n'y a pas d'autres impacts
*************** END
#+end_src

That gives:

#+begin_src latex
\begin{itemize}
\item[@<span class="todo TODO"> TODO Vérifier qu'il n'y a pas d'autres impacts]
\end{itemize}
#+end_src

The =span class= seems HTML into LaTeX, doesn't it?

Anyway, it's quite weirdly exported (when I look at the resulting PDF). I'll
try to customize that part, though.

Best regards,
  Seb

-- 
Sébastien Vauban


_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode-mXXj517/zsQ@public.gmane.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: Re: full production use of org-mode: time to say thanks again!
  2010-10-19  8:27         ` Sébastien Vauban
@ 2010-10-20  2:45           ` Jeff Horn
  2010-10-20  8:01             ` Sébastien Vauban
  0 siblings, 1 reply; 25+ messages in thread
From: Jeff Horn @ 2010-10-20  2:45 UTC (permalink / raw)
  To: Sébastien Vauban; +Cc: emacs-orgmode

>>>> See the commentary in lisp/org-inlinetask.el.
>>
>> I suppose the advantage of inline tasks is that they appear even when the
>> document is folded?
>
> I don't have that behavior. When folded, I only see:
>
> - all level-1 headlines, or
> - all headlines (after second S-TAB)
>
> Did I miss some customization?

No, I think I just misunderstood the quoted commentary from org-inlinetask.el:

------------------------------------------------------------------------------
;; Visibility cycling exempts these nodes from cycling.  So whenever their
;; parent is opened, so are these tasks.  This will only work with
;; `org-cycle', so if you are also using other commands to show/hide
;; entries, you will occasionally find these tasks to behave like
;; all other outline nodes, seemingly splitting the text of the parent
;; into children.
------------------------------------------------------------------------------

It is clearer to me now. I would watch an FAQ or short tutorial, if
one were to be produced.

-- 
Jeffrey Horn
Graduate Lecturer and PhD Student in Economics
George Mason University

(704) 271-4797
jhorn@gmu.edu
jrhorn424@gmail.com

http://www.failuretorefrain.com/jeff/

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: full production use of org-mode: time to say thanks again!
  2010-10-20  2:45           ` Jeff Horn
@ 2010-10-20  8:01             ` Sébastien Vauban
  0 siblings, 0 replies; 25+ messages in thread
From: Sébastien Vauban @ 2010-10-20  8:01 UTC (permalink / raw)
  To: emacs-orgmode-mXXj517/zsQ

Hi Jeff,

Jeff Horn wrote:
>>>>> See the commentary in lisp/org-inlinetask.el.
>>>
>>> I suppose the advantage of inline tasks is that they appear even when the
>>> document is folded?
>>
>> I don't have that behavior. When folded, I only see:
>>
>> - all level-1 headlines, or
>> - all headlines (after second S-TAB)
>>
>> Did I miss some customization?
>
> No, I think I just misunderstood the quoted commentary from org-inlinetask.el:
>
> ------------------------------------------------------------------------------
> ;; Visibility cycling exempts these nodes from cycling.  So whenever their
> ;; parent is opened, so are these tasks.  This will only work with
> ;; `org-cycle', so if you are also using other commands to show/hide
> ;; entries, you will occasionally find these tasks to behave like
> ;; all other outline nodes, seemingly splitting the text of the parent
> ;; into children.
> ------------------------------------------------------------------------------
>
> It is clearer to me now. I would watch an FAQ or short tutorial, if
> one were to be produced.

OK. That's clear to me as well now. Thanks.

Best regards,
  Seb

-- 
Sébastien Vauban


_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode-mXXj517/zsQ@public.gmane.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2010-10-20  8:01 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-09 10:46 full production use of org-mode: time to say thanks again! Eric S Fraga
2010-10-09 15:26 ` Carsten Dominik
2010-10-09 17:00   ` Nicolas Goaziou
2010-10-10 18:01     ` Eric S Fraga
2010-10-11  6:34       ` Nicolas Goaziou
2010-10-11  8:04         ` Carsten Dominik
2010-10-11 11:15           ` Paul Mead
2010-10-11 15:12           ` Nicolas Goaziou
2010-10-11 15:16           ` Nicolas Goaziou
2010-10-11 15:37           ` Eric S Fraga
2010-10-14  8:32           ` Carsten Dominik
2010-10-11 15:33         ` indenting after inline task (was Re: full production use of org-mode: time to say thanks again!) Eric S Fraga
2010-10-14  8:16         ` full production use of org-mode: time to say thanks again! Carsten Dominik
2010-10-10 17:56   ` Eric S Fraga
2010-10-11  8:01     ` Carsten Dominik
2010-10-11  9:01       ` Eric S Fraga
2010-10-09 16:48 ` Christian Moe
2010-10-09 17:15   ` Nick Dokos
2010-10-09 19:03     ` Christian Moe
2010-10-11 19:33       ` Jeff Horn
2010-10-12  8:04         ` Carsten Dominik
2010-10-12  8:08         ` Eric S Fraga
2010-10-19  8:27         ` Sébastien Vauban
2010-10-20  2:45           ` Jeff Horn
2010-10-20  8:01             ` Sébastien Vauban

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).