Re: [PATCH 2/3] Add a way to display names for tag groups in fast tag selection.

From: Carsten Dominik <carsten.dominik@gmail.com>
To: James TD Smith <ahktenzero@mohorovi.cc>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH 2/3] Add a way to display names for tag groups in fast tag selection.
Date: Wed, 21 Oct 2009 10:43:04 +0200	[thread overview]
Message-ID: <4A124840-988B-43D8-A887-49750F4DDE29@gmail.com> (raw)
In-Reply-To: <1256007090-32050-3-git-send-email-ahktenzero@mohorovi.cc>

Applied, thanks.

- Carsten

On Oct 20, 2009, at 4:51 AM, James TD Smith wrote:

> If the nil term in the start or end group cells are replaced by  
> strings, these
> are displayed before or after the brackets for the group.
> ---
> lisp/ChangeLog |    6 ++++++
> lisp/org.el    |   12 ++++++------
> 2 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/lisp/ChangeLog b/lisp/ChangeLog
> index 47b44cd..83af7a4 100755
> --- a/lisp/ChangeLog
> +++ b/lisp/ChangeLog
> @@ -29,6 +29,12 @@
> 	(org-mobile-create-index-file): Sort the files to be listed in
> 	index.org.
>
> +2009-10-17  James TD Smith  <ahktenzero@mohorovi.cc>
> +
> +	* org.el (org-fast-tag-selection): Add a way to display a
> +	description for a tag group. This is done by adding a string to
> +	either the startgroup or endgroup cell.
> +
> 2009-10-17  Carsten Dominik  <carsten.dominik@gmail.com>
>
> 	* org-clock.el (org-clock-resolve, org-resolve-clocks)
> diff --git a/lisp/org.el b/lisp/org.el
> index a394443..3f8bbee 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -11542,15 +11542,15 @@ Returns the new tags string, or nil to not  
> change the current settings."
>       (setq tbl fulltable char ?a cnt 0)
>       (while (setq e (pop tbl))
> 	(cond
> -	 ((equal e '(:startgroup))
> +	 ((equal (car e) :startgroup)
> 	  (push '() groups) (setq ingroup t)
> 	  (when (not (= cnt 0))
> 	    (setq cnt 0)
> 	    (insert "\n"))
> -	  (insert "{ "))
> -	 ((equal e '(:endgroup))
> +	  (insert (if (cdr e) (format "%s: " (cdr e)) "") "{ "))
> +	 ((equal (car e) :endgroup)
> 	  (setq ingroup nil cnt 0)
> -	  (insert "}\n"))
> +	  (insert "}" (if (cdr e) (format " (%s) " (cdr e)) "") "\n"))
> 	 ((equal e '(:newline))
> 	  (when (not (= cnt 0))
> 	    (setq cnt 0)
> @@ -11595,8 +11595,8 @@ Returns the new tags string, or nil to not  
> change the current settings."
>       (setq rtn
> 	    (catch 'exit
> 	      (while t
> -		(message "[a-z..]:Toggle [SPC]:clear [RET]:accept [TAB]:free%s%s"
> -			 (if groups " [!] no groups" " [!]groups")
> +		(message "[a-z..]:Toggle [SPC]:clear [RET]:accept [TAB]:free [!]  
> %sgroups%s"
> +			 (if (not groups) "no " "")
> 			 (if expert " [C-c]:window" (if exit-after-next " [C-c]:single"  
> " [C-c]:multi")))
> 		(setq c (let ((inhibit-quit t)) (read-char-exclusive)))
> 		(cond
> -- 
> 1.6.3.3
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten