Re: Some css issues in org-export

From: Carsten Dominik <dominik@science.uva.nl>
To: Sebastian Rose <sebastian_rose@gmx.de>
Cc: Rustom Mody <rustompmody@gmail.com>,
	emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Some css issues in org-export
Date: Mon, 2 Feb 2009 12:20:32 +0100	[thread overview]
Message-ID: <49F6A245-6DC7-4E42-9633-777A66A13F77@uva.nl> (raw)
In-Reply-To: <873aexnpyd.fsf@kassiopeya.MSHEIMNETZ>

I have implemented a different fix for the problem Sebastian mentions.
Hopefully it will work correctly, please test.

- Carsten

On Feb 2, 2009, at 10:33 AM, Sebastian Rose wrote:

> Hi,
>
>
>
> This solves the problem with the <div> inside a <p>. That <div> is  
> only
> created when images are included using `org-export-html-format-image'.
>
>
>
>
>
> diff --git a/lisp/org-exp.el b/lisp/org-exp.el
> index 760c83f..4f035a4 100644
> --- a/lisp/org-exp.el
> +++ b/lisp/org-exp.el
> @@ -3638,8 +3638,10 @@ lang=\"%s\" xml:lang=\"%s\">
>                           (and org-export-html-inline-images (not  
> descp)))
>                       (org-file-image-p
>                        path org-export-html-inline-image-extensions))
> +                       (progn
> +                       (org-close-par-maybe)
>                  (setq rpl (org-export-html-format-image
> -                            (concat type ":" path)))
> +                            (concat type ":" path))))
>                (setq link (concat type ":" path))
>                (setq rpl (concat "<a href=\""
>                                  (org-export-html-format-href link)
> @@ -3706,7 +3708,9 @@ lang=\"%s\" xml:lang=\"%s\">
>                                   (or (eq t org-export-html-inline- 
> images)
>                                       (and org-export-html-inline- 
> images
>                                            (not descp))))
> -                             (org-export-html-format-image thefile)
> +                             (progn
> +                               (org-close-par-maybe)
> +                             (org-export-html-format-image thefile))
>                            (concat "<a href=\"" thefile "\"" attr ">"
>                                    (org-export-html-format-desc desc)
>                                    "</a>")))
> </#part>
>
>
>
> Regards,
>
>
>
> Rustom Mody <rustompmody@gmail.com> writes:
>> I tried validating this at http://validator.w3.org/
>> and its not valid XHTML.
>>
>> Dont know more HTML to comment :-)
>>
>>
>> On Mon, Jan 19, 2009 at 8:43 PM, Sebastian Rose <sebastian_rose@gmx.de 
>> > wrote:
>>> Hi Rustom,
>>>
>>>
>>> "Rustom Mody" <rustompmody@gmail.com> writes:
>>>> On Mon, Jan 19, 2009 at 6:29 PM, Sebastian Rose <sebastian_rose@gmx.de 
>>>> > wrote:
>>>>>
>>>>> Hm - we do not provide a special stylesheet for printing. But  
>>>>> since
>>>> <snipped>
>>>>>
>>>>> Maybe we should add this line to the very top of the document:
>>>>>
>>>>> <?xml version="1.0" encoding="utf-8" ?>
>>>>
>>>> I tried adding this by hand (using emacs) it made no difference  
>>>> to the printout
>>>> The boxes show the digits like this:
>>>>
>>>> 0 0
>>>> 2 0
>>>>
>>>> Also I noticed that emacs shows (Unix) in the modeline but it shows
>>>> ^Ms at EOLs in the buffer.
>>>>
>>>> I understand too little of unicode etc to even claim that this is
>>>> 'not-as-it-should-be' -- just mentioning it in case it gives any
>>>> clues...
>>>
>>>
>>> Hmmm. In the modeline I have either an `U' (for utf-8) or `1' or
>>> iso-8859-1 and other single byte encodings. OrgMode seems to set the
>>> charset correctly on export here. If I do a `save file as' in  
>>> Firefox
>>> and open it in emacs, I see the encoding is exactly what's in the  
>>> line
>>> with the `charset'.  You should change the `utf-8' to what's in  
>>> that line
>>> with the `charset':
>>>
>>>  <meta http-equiv="Content-Type" content="text/ 
>>> html;charset=iso-8859-1"/>
>>>
>>> in case of
>>> http://orgmode.org/worg/org-tutorials/org-custom-agenda- 
>>> commands.php.
>>>
>>>
>>> If you add the `<?xml....' line, make shure that
>>>  a) the encoding is the same as the one in the `charset' line and
>>>  b) the file is indeed written to disk using that encoding. See
>>>     `C-h k C-x RET f' or ust do `C-x RET f TAB TAB'.
>>>
>>>
>>>
>>> Anyway, I believe it's a question of your browsers configuration  
>>> since
>>> no one else has that problem.
>>>
>>>
>>>
>>> The line endings have nothing to do with encoding. Their bit-wise
>>> representation is the same for all single byte encodings and utf-8.
>>>
>>>
>>>
>>> Good luck,
>>>
>>>
>>>
>>> --
>>> Sebastian Rose, EMMA STIL - mediendesign, Niemeyerstr.6, 30449  
>>> Hannover
>>> Tel.:  +49 (0)511 - 36 58 472
>>> Fax:   +49 (0)1805 - 233633 - 11044
>>> mobil: +49 (0)173 - 83 93 417
>>> Http:  www.emma-stil.de
>>>
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Remember: use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>
>
> -- 
> Sebastian Rose, EMMA STIL - mediendesign, Niemeyerstr.6, 30449  
> Hannover
> Tel.:  +49 (0)511 - 36 58 472
> Fax:   +49 (0)1805 - 233633 - 11044
> mobil: +49 (0)173 - 83 93 417
> Email: s.rose@emma-stil.de, sebastian_rose@gmx.de
> Http:  www.emma-stil.de
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode