From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Goldman Subject: Re: Org-menu "Set Items" not bound Date: Thu, 18 Dec 2008 12:24:35 -0600 Message-ID: <494A9563.4010103@sift.info> References: <494922D0.3020807@sift.info> <811717A9-751A-4D17-B1A9-25EB74F606B5@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000505040900020807090007" Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LDNbO-0007Nv-EE for emacs-orgmode@gnu.org; Thu, 18 Dec 2008 13:28:02 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LDNbM-0007N7-Tu for emacs-orgmode@gnu.org; Thu, 18 Dec 2008 13:28:02 -0500 Received: from [199.232.76.173] (port=34990 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LDNbM-0007N0-IS for emacs-orgmode@gnu.org; Thu, 18 Dec 2008 13:28:00 -0500 Received: from outbound-mail-32.bluehost.com ([69.89.18.152]:34913) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1LDNbL-0005nJ-S1 for emacs-orgmode@gnu.org; Thu, 18 Dec 2008 13:28:00 -0500 In-Reply-To: <811717A9-751A-4D17-B1A9-25EB74F606B5@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org, Carsten Dominik Cc: David Reitter , "aquamacs-bugs@aquamacs.org Bugs" , emacs-pretest-bug@gnu.org This is a multi-part message in MIME format. --------------000505040900020807090007 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Backgrond: I have been finding that the Set Tags menu command didn't work for me (on aquamacs). I reported that to aquamacs-bugs, but David Reitter there found that it was an org-mode bug. I don't believe he reported it to orgmode list --- went to emacs-pretest-bug instead. Here's the analysis and a proposed patch. I just looked at the output of help-variable on org-org-menu and I see: (TAGS\ and\ Properties menu-item "TAGS and Properties" (keymap "TAGS and Properties" (Set\ Tags menu-item "Set Tags" menu-function-16 :key-sequence nil) (Change\ tag\ in\ region menu-item "Change tag in region" menu-function-17 :key-sequence nil :enable (org-region-active-p)) (nil menu-item "--") (Set\ property menu-item "Set property" menu-function-18 :key-sequence nil) (Column\ view\ of\ properties menu-item "Column view of properties" org-columns) (Insert\ Column\ View\ DBlock menu-item "Insert Column View DBlock" org-insert-columns-dblock))) So I confirm what David reports, if you look about you'll see that the keymap entries for "Set Tags" and "Set Property" aren't properly initialized. I find that the following are also not initialized: Sparse\ trees\ open\ ARCHIVE\ trees Cycling\ opens\ ARCHIVE\ trees Set\ property Record\ DONE\ time Edit\ File\ List Descriptive\ Links Literal\ Links Export\ LaTeX\ fragments\ as\ images and all of the entries for my org agenda files. Looking at the org.el code, I see that these correspond to entries in the org-org-mode menu that are quoted. For example, I see: ["Set Tags" 'org-set-tags-command t] which doesn't work, but we also see ["Priority Down" org-shiftdown t] which does work. When I cut out these quotes, the menu items work for me. I'm attaching a patch file. --------------000505040900020807090007 Content-Type: text/plain; x-mac-type="0"; x-mac-creator="0"; name="menu.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="menu.patch" diff --git a/lisp/org.el b/lisp/org.el index 3df04e2..2461267 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -13342,10 +13342,10 @@ See the individual commands for more information." ["Priority Up" org-shiftup t] ["Priority Down" org-shiftdown t]) ("TAGS and Properties" - ["Set Tags" 'org-set-tags-command t] - ["Change tag in region" 'org-change-tag-in-region (org-region-active-p)] + ["Set Tags" org-set-tags-command t] + ["Change tag in region" org-change-tag-in-region (org-region-active-p)] "--" - ["Set property" 'org-set-property t] + ["Set property" org-set-property t] ["Column view of properties" org-columns t] ["Insert Column View DBlock" org-insert-columns-dblock t]) ("Dates and Scheduling" --------------000505040900020807090007 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --------------000505040900020807090007--