From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: Unable to clock in on task Date: Tue, 27 Oct 2009 11:06:42 -0400 Message-ID: <4882.1256656002@gamaville.dokosmarshall.org> References: <3949.1256654208@gamaville.dokosmarshall.org> <2FA5AF81-C2CA-4318-AA04-FF734ACC5B76@acm.org> Reply-To: nicholas.dokos@hp.com Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N2nek-00037X-B4 for emacs-orgmode@gnu.org; Tue, 27 Oct 2009 11:08:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N2nef-00035L-E9 for emacs-orgmode@gnu.org; Tue, 27 Oct 2009 11:08:17 -0400 Received: from [199.232.76.173] (port=34358 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N2nef-00035G-7v for emacs-orgmode@gnu.org; Tue, 27 Oct 2009 11:08:13 -0400 Received: from vms173015pub.verizon.net ([206.46.173.15]:62786) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N2nee-0004TS-RU for emacs-orgmode@gnu.org; Tue, 27 Oct 2009 11:08:13 -0400 Received: from gamaville.dokosmarshall.org ([173.76.32.106]) by vms173015.mailsrvcs.net (Sun Java(tm) System Messaging Server 6.3-7.04 (built Sep 26 2008; 32bit)) with ESMTPA id <0KS6006ONHYT1O8M@vms173015.mailsrvcs.net> for emacs-orgmode@gnu.org; Tue, 27 Oct 2009 10:06:30 -0500 (CDT) In-reply-to: Message from Keith Lancaster of "Tue, 27 Oct 2009 09:48:35 CDT." <2FA5AF81-C2CA-4318-AA04-FF734ACC5B76@acm.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Keith Lancaster Cc: Org Mode List Keith Lancaster wrote: > That did it! The patch fixes the problem - it now handles all the > dangling clocks and then clocks in correctly. Thanks! > > Keith > > On Oct 27, 2009, at 9:36 AM, Nick Dokos wrote: > > > Phil Rooke wrote: > > > >> Keith Lancaster writes: > >> > >>> I updated to 6.32 this morning and am now unable to clock in on > >>> tasks. ... > >> > >> I too upgraded this morning and am also having problems clocking in > >> (using "I" on a task in the daily agenda). My symptoms are > >> different, > >> Emacs doesn't crash but I do consistently get the following: > >> > >> Debugger entered--Lisp error: (wrong-type-argument stringp 126) > >> expand-file-name(126) > >> mapcar(expand-file-name "~/Documents/Org/org-agenda-files") > >> org-files-list() > >> org-resolve-clocks() > >> byte-code.... > >> org-clock-in(nil) > >> org-agenda-clock-in(nil) > >> call-interactively(org-agenda-clock-in nil nil) > >> > > > > This does look like a bug: org-resolve-clock calls org-files-list > > which > > does not know about the "agenda files list in a file" convention. It > > should probably call the function org-agenda-files instead of > > org-files-list. org-files-list is only used in this one place and > > should > > probably be deleted. > > > > Try this patch: > > > > diff --git a/lisp/org-clock.el b/lisp/org-clock.el > > index ea23a8d..2ce2f22 100644 > > --- a/lisp/org-clock.el > > +++ b/lisp/org-clock.el > > @@ -737,7 +737,7 @@ non-dangling (i.e., currently open and valid) > > clocks." > > (interactive "P") > > (unless org-clock-resolving-clocks > > (let ((org-clock-resolving-clocks t)) > > - (dolist (file (org-files-list)) > > + (dolist (file (org-agenda-files)) > > (let ((clocks (org-find-open-clocks file))) > > (dolist (clock clocks) > > (let ((dangling (or (not (org-clock-is-active)) > > > > Thanks, > > Nick > > > Let me point out that the difference between Keith's original report and Phil's report is that Phil included the backtrace - given that, the patch was easy. So, Keith, you know what to do next time :-) Even better, using org-submit-bug-report would have shown us that the "agenda file list in a file" convention was being used - as you can imagine, that's not the setting I use, so when I tried clocking in yesterday, things worked without a problem for me. Moralizingly-but-I-hope-not-overbearingly-so yours, Nick