Re: Re: org-indent mode not indenting free text?

From: Carsten Dominik <carsten.dominik@gmail.com>
To: Erik Iverson <eriki@ccbr.umn.edu>
Cc: Achim Gratz <Stromeko@nexgo.de>,
	emacs-orgmode@gnu.org, Antti Kaihola <akaihola@gmail.com>
Subject: Re: Re: org-indent mode not indenting free text?
Date: Fri, 3 Dec 2010 20:57:22 +0100	[thread overview]
Message-ID: <47210110-87A0-4895-9194-F6ACC1B4EF16@gmail.com> (raw)
In-Reply-To: <4CF91853.9090001@ccbr.umn.edu>

Hi Erik,

On Dec 3, 2010, at 5:18 PM, Erik Iverson wrote:

> Just a guess here: This may be some weirdness
> because the check in org-indent *will* allow
> people using GNU Emacs 23.1.50 to turn on
> org-indent, as far as I can tell.

org-indent-mode should work in 23.1.50, this is the
release where the fix was made.

>
> The message "org-indent-mode can crash Emacs 23.1"
> does not fully explain if it can also crash 23.1.50.

Yes, may be this is not so clear.  The current setup forbids it
before 23.1.50, and allows it from 23.1.50.  At least that is
what I meant.  Is there a bug?

[...]
>
> Antti Kaihola wrote:
>> 2010/12/2 Achim Gratz <Stromeko@nexgo.de>:
>>> What version of Emacs are you running?
>> This is:
>> GNU Emacs 23.1.50.1 (i486-pc-linux-gnu, GTK+ Version 2.18.0) of
>> 2009-09-27 on palmer, modified by Debian
>>> What does C-h f with-silent-modifications result in?
>> with-silent-modifications is a Lisp macro in `org-macs.el'.
>> (with-silent-modifications ORG-UNMODIFIED)
>> Not documented.
>>> Could you back out the change
>>> (most likely the defmacro for with-silent-modifications in org- 
>>> macs.el,
>>> even though I have no clue why this would interact with org-indent- 
>>> mode
>>> as it should not be defined for versions >23.1) and tell us if that
>>> solves your problem (which I can't test because org-indent-mode  
>>> doesn't
>>> even start on Emacs 23.1)?
>> Yes it does! I commented out:
>> ;;(if (or (< emacs-major-version 23)
>> ;;	(and (<= emacs-major-version 23)
>> ;;	     (< emacs-minor-version 2)))
>> ;;    (defmacro with-silent-modifications
>> ;;      (org-unmodified)))
>> and it now works correctly. Thanks a lot!

I have now changed the definition like this:

(if (and (not (fboundp 'with-silent-modifications))
	 (or (< emacs-major-version 23)
	     (and (= emacs-major-version 23)
		  (< emacs-minor-version 2))))
     (defmacro with-silent-modifications (&rest body)
       `(org-unmodified ,@body)))

May I ask you to pull and check if this is
working for you out of the box?

Thank you.

- Carsten

>> _______________________________________________
>> Emacs-orgmode mailing list
>> Please use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode