* Columns view for org-tags-view
@ 2011-10-28 10:59 Ilya Zonov
2011-10-28 12:48 ` Carsten Dominik
0 siblings, 1 reply; 2+ messages in thread
From: Ilya Zonov @ 2011-10-28 10:59 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 1879 bytes --]
Hello!
First of all I want say thank you for great emacs mode, which I using for
planning my life and job. Org-mode is the best!
I used 7.7 version with some patches from development version. For example,
patch<http://orgmode.org/w/?p=org-mode.git;a=blobdiff;f=lisp/org-colview.el;h=f0585193c6a3c843eeed98fa581f1d0ba099cf7d;hp=2ad5f95616447b43bdd32e56e671ae1fa3e96d82;hb=2edd05eaac6c62ce76572c469415602e6de94cda;hpb=8c3ecbe39a0c99e3724246d1eb460495a53721b6>which
adds ability to cleanup items in agenda view (org-columns-cleanup-item
function).
I very like columns view, which I'm using for agenda views. So, I found that
%ITEM is not cleaned for agenda views are generated by org-tags-view. After
debuging and some investigation of org-tags-view code, I found that items in
agenda view generated by org-tags-view have no text-property
'org-complex-heading-regexp. In this case org-columns-cleanup-item does not
clean items.
Then I found that properties for item are coped in org-scan-tags function.
But org-complex-heading-regexp property is not coped here. I suggest to add
this property in this function. Please, could you check my correction? I
have no big experience in lisp codding. So, maybe this change have some
impact to other parts of org-mode. Here is little patch for version 7.7:
*** /usr/share/emacs/site-lisp/org-mode/org.el
--- Buffer org.el
***************
*** 12514,12519 ****
--- 12514,12520 ----
'mouse-face 'highlight
'org-not-done-regexp org-not-done-regexp
'org-todo-regexp org-todo-regexp
+ 'org-complex-heading-regexp org-complex-heading-regexp
'help-echo
(format "mouse-2 or RET jump to org file %s"
(abbreviate-file-name
--
Илья Зонов (Ilya Zonov) aka puzan
Nizhny Novgorod, Russia
[-- Attachment #2: Type: text/html, Size: 3961 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Columns view for org-tags-view
2011-10-28 10:59 Columns view for org-tags-view Ilya Zonov
@ 2011-10-28 12:48 ` Carsten Dominik
0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2011-10-28 12:48 UTC (permalink / raw)
To: Ilya Zonov; +Cc: emacs-orgmode
Hello Ilya,
correct analysis, thanks, this is fixed in the git repo.
- Carsten
On 28.10.2011, at 12:59, Ilya Zonov wrote:
> Hello!
>
> First of all I want say thank you for great emacs mode, which I using for planning my life and job. Org-mode is the best!
>
> I used 7.7 version with some patches from development version. For example, patch which adds ability to cleanup items in agenda view (org-columns-cleanup-item function).
>
> I very like columns view, which I'm using for agenda views. So, I found that %ITEM is not cleaned for agenda views are generated by org-tags-view. After debuging and some investigation of org-tags-view code, I found that items in agenda view generated by org-tags-view have no text-property 'org-complex-heading-regexp. In this case org-columns-cleanup-item does not clean items.
>
> Then I found that properties for item are coped in org-scan-tags function. But org-complex-heading-regexp property is not coped here. I suggest to add this property in this function. Please, could you check my correction? I have no big experience in lisp codding. So, maybe this change have some impact to other parts of org-mode. Here is little patch for version 7.7:
>
> *** /usr/share/emacs/site-lisp/org-mode/org.el
> --- Buffer org.el
> ***************
> *** 12514,12519 ****
> --- 12514,12520 ----
> 'mouse-face 'highlight
> 'org-not-done-regexp org-not-done-regexp
> 'org-todo-regexp org-todo-regexp
> + 'org-complex-heading-regexp org-complex-heading-regexp
> 'help-echo
> (format "mouse-2 or RET jump to org file %s"
> (abbreviate-file-name
>
> --
> Илья Зонов (Ilya Zonov) aka puzan
> Nizhny Novgorod, Russia
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-28 12:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-28 10:59 Columns view for org-tags-view Ilya Zonov
2011-10-28 12:48 ` Carsten Dominik
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).