Right now making a timeline agenda of an indirect buffer causes a crash. I think it's because buffer-file-name is null for such buffers, so in the call (org-prepare-agenda (concat "Timeline " (file-name-nondirectory buffer-file-name))) the file-name-nondirectory call fails.
Fixed, thanks.
- Carsten
On Aug 5, 2010, at 7:16 PM, Ilya Shlyakhter wrote:
> Right now making a timeline agenda of an indirect buffer causes a
> crash.
> I think it's because buffer-file-name is null for such buffers,
> so in the call
> (org-prepare-agenda (concat "Timeline "
> (file-name-nondirectory buffer-file-
> name)))
> the file-name-nondirectory call fails.
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[-- Attachment #1.1: Type: text/plain, Size: 547 bytes --] On Thu, Aug 5, 2010 at 10:46 PM, Ilya Shlyakhter <ilya_shl@alum.mit.edu>wrote: > Right now making a timeline agenda of an indirect buffer causes a crash. > I think it's because buffer-file-name is null for such buffers, > so in the call > (org-prepare-agenda (concat "Timeline " > (file-name-nondirectory buffer-file-name))) > the file-name-nondirectory call fails. > I am trying to understand what do you mean by indirect buffer in this context. Can you please explain the steps to reproduce this? Thanks Noorul [-- Attachment #1.2: Type: text/html, Size: 882 bytes --] [-- Attachment #2: Type: text/plain, Size: 201 bytes --] _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[-- Attachment #1.1: Type: text/plain, Size: 744 bytes --] Carsten, Does commit 5188f71ee85aee753db07d0fccea4a9217eb8a4d fix this issue? Thanks Noorul On Sat, Aug 7, 2010 at 2:43 PM, Noorul Islam <noorul@noorul.com> wrote: > > > On Thu, Aug 5, 2010 at 10:46 PM, Ilya Shlyakhter <ilya_shl@alum.mit.edu>wrote: > >> Right now making a timeline agenda of an indirect buffer causes a crash. >> I think it's because buffer-file-name is null for such buffers, >> so in the call >> (org-prepare-agenda (concat "Timeline " >> (file-name-nondirectory buffer-file-name))) >> the file-name-nondirectory call fails. >> > > I am trying to understand what do you mean by indirect buffer in this > context. Can you please explain the steps to reproduce this? > > Thanks > Noorul > > [-- Attachment #1.2: Type: text/html, Size: 1391 bytes --] [-- Attachment #2: Type: text/plain, Size: 201 bytes --] _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
On Aug 7, 2010, at 11:28 AM, Noorul Islam wrote: > Carsten, > > Does commit 5188f71ee85aee753db07d0fccea4a9217eb8a4d fix this issue? I think so, yes. - Carsten > > Thanks > Noorul > > > On Sat, Aug 7, 2010 at 2:43 PM, Noorul Islam <noorul@noorul.com> > wrote: > > > On Thu, Aug 5, 2010 at 10:46 PM, Ilya Shlyakhter <ilya_shl@alum.mit.edu > > wrote: > Right now making a timeline agenda of an indirect buffer causes a > crash. > I think it's because buffer-file-name is null for such buffers, > so in the call > (org-prepare-agenda (concat "Timeline " > (file-name-nondirectory buffer-file- > name))) > the file-name-nondirectory call fails. > > I am trying to understand what do you mean by indirect buffer in > this context. Can you please explain the steps to reproduce this? > > Thanks > Noorul > > - Carsten
[-- Attachment #1.1: Type: text/plain, Size: 664 bytes --] Ilya Shlyakhter wrote: >Right now making a timeline agenda of an indirect buffer causes a crash. >I think it's because buffer-file-name is null for such buffers, >so in the call >(org-prepare-agenda (concat "Timeline " > (file-name-nondirectory buffer-file-name))) >the file-name-nondirectory call fails. Thanks, this has been fixed: ,---- | commit 5188f71ee85aee753db07d0fccea4a9217eb8a4d | Author: Carsten Dominik <carsten.dominik@gmail.com> | Date: Sat Aug 7 08:23:33 2010 +0200 | | Timeline: Allow the buffer to be an indirect one | | * lisp/org-agenda.el (org-timeline): Allow indirect buffer. `---- Best, -- David [-- Attachment #1.2: Type: application/pgp-signature, Size: 230 bytes --] [-- Attachment #2: Type: text/plain, Size: 201 bytes --] _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Noorul Islam <noorul@noorul.com> wrote:
> On Thu, Aug 5, 2010 at 10:46 PM, Ilya Shlyakhter <ilya_shl@alum.mit.edu> wrote:
>
> Right now making a timeline agenda of an indirect buffer causes a crash.
> I think it's because buffer-file-name is null for such buffers,
> so in the call
> (org-prepare-agenda (concat "Timeline "
> (file-name-nondirectory buffer-file-name)))
> the file-name-nondirectory call fails.
>
> I am trying to understand what do you mean by indirect buffer in this context. Can you please explain the steps to reproduce this?
>
See Section 27.11, "Indirect Buffers", of the Elisp manual.
If you are reading this in emacs, you can just evaluate the
following:
(info "(elisp) Indirect Buffers")
HTH,
Nick