From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Exporter interface question Date: Thu, 28 Feb 2013 12:50:49 +0100 Message-ID: <40E06D48-822F-4432-9D92-4F72AC866338@gmail.com> References: <871uc2t9z7.fsf@gmail.com> <8993D674-E5E6-4B8E-AE3C-75F694371459@gmail.com> <8738whsrx3.fsf@gmail.com> <87ip5cpwkx.fsf@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([208.118.235.92]:55535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UB20g-0003yn-SX for emacs-orgmode@gnu.org; Thu, 28 Feb 2013 06:50:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UB20f-0001VO-3Y for emacs-orgmode@gnu.org; Thu, 28 Feb 2013 06:50:50 -0500 Received: from mail-bk0-f53.google.com ([209.85.214.53]:60080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UB20e-0001Ti-M8 for emacs-orgmode@gnu.org; Thu, 28 Feb 2013 06:50:48 -0500 Received: by mail-bk0-f53.google.com with SMTP id j10so774544bkw.40 for ; Thu, 28 Feb 2013 03:50:47 -0800 (PST) In-Reply-To: <87ip5cpwkx.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: Org-mode List On 28.2.2013, at 11:22, Nicolas Goaziou wrote: > Hello, >=20 > Carsten Dominik writes: >=20 >> OK, I pushed this change, maybe it is good if you have a brief look, >> Nicolas. >=20 > Thanks for the patch. It looks good. I have one minor suggestion, > though. In the following snippet: >=20 > (eq (marker-buffer org-export-dispatch-last-position) > (current-buffer)) >=20 > wouldn't it be better to check equality with: >=20 > (org-base-buffer (current-buffer)) >=20 > instead or simply (current-buffer)? I agree, but I think then also setting the mark need to take care to set = the mark in the base buffer. Will do this. - Carsten=