From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id UN07LaO7GWQt5gAASxT56A (envelope-from ) for ; Tue, 21 Mar 2023 15:13:55 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EEImLaO7GWQWdwEA9RJhRA (envelope-from ) for ; Tue, 21 Mar 2023 15:13:55 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7469BDF9B for ; Tue, 21 Mar 2023 15:13:55 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="nGo/CBoq"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679408035; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=/cKBLtwsgEDt5AvyN+KEXes18HCdnq7q2u5X9OZ8ZzE=; b=E1ruextdTALt9rekaUpCVbVcXc/kyuIQLj4/20DOqFl19nL6Y0BWuE+5IXYmLMPpO/6ocN hwfgFKPEpEGYN967hqbuCStvUuxn/A+q/z0wLpDdR9xV7va6bInkRze3wALVYJ6mZDa/EJ dzdcUVsSSF88+SL2Uu1teMNfMOw94D30DoNoganvAQ90lSw8rtW6TzkBEgoWerdHSAwUbU A1q5tS/ff60KlPVLpGw5a/mZ1ERAzAKBSTg8EpyK+oX8cIMd1uhq/CFBxqD+1cK9f6rI5z v7Jvze1GYA7u7S5AJN0lPia1NhTw1EJB+emarvtEQ0lZEECScxEhdOmMaGIkRw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="nGo/CBoq"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679408035; a=rsa-sha256; cv=none; b=BywtDUNr+ze4mVl1grGNZcbs/dLlWclliNSYQxEylhvTj3nvJy6+WfdnVPxXPmQyoGhOdB /T1AIpeGJ9am9gKd1O7JucQWHY4v24w0LRMLGYg+/JQVev626KAdVVtfq5KUQYVisRDGVG f4irggcqExv0+xDwO3EurFgVLpz5iNfM1acbvEsvVCDDzEn4OIAwtTaIzNCQ/30JkvKB8M lwaq01Tf1j9X+V47Xjl3uoSipidovV3FMSuwmygsxWs7XPJToDAtdl/ispeArVhpULD/d5 YJmbaSn9sqlN8ASO7lJpI/blHL8heFeixljmGGgZ3cz3l3OjtQeT4p/ek3yGNA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pecja-0002Qo-Jw; Tue, 21 Mar 2023 10:13:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pecjY-0002Qb-QK for emacs-orgmode@gnu.org; Tue, 21 Mar 2023 10:13:04 -0400 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pecjS-0001E9-Rn for emacs-orgmode@gnu.org; Tue, 21 Mar 2023 10:13:04 -0400 Received: by mail-lj1-x22a.google.com with SMTP id t14so15648673ljd.5 for ; Tue, 21 Mar 2023 07:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679407977; h=content-transfer-encoding:in-reply-to:mail-followup-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=/cKBLtwsgEDt5AvyN+KEXes18HCdnq7q2u5X9OZ8ZzE=; b=nGo/CBoqKovcSQQdc/cJRcGZk4d6yI6Ku1OfWXN1reoUpLcpNxNCnHfMngIcihanU3 5diw+lzfTU9OSMZs9BCy9KQZM2RFDPVCX9c6iBQmGYrOl61S/tjdk7oWTu3fbcfaYY2F kDHKkxCe/9MlLEVPRFGgENQTwxIl5CctzVH+//sLQcf6jyLlBtRFbL9eJN0t/pwWEclh zDegTafirZKnhx7QvCUwUIFed6AjOcpTSUOFk6NI5mQ261VjS0HxVCBFvEpDlSJT/Aip jP13/rIElLOLZkbTHKs9v5lzArN7FOtC8/udn/wjfcDmq89skcdcB6d61Tl1DUoXHScI srJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679407977; h=content-transfer-encoding:in-reply-to:mail-followup-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/cKBLtwsgEDt5AvyN+KEXes18HCdnq7q2u5X9OZ8ZzE=; b=YNOSm2z5yvKVeywx8K1SeGPPh2DLnlq9dZ+mtbUFHD3DxaSbrDjSkLMiMtf3UPZfRO OlBISYBol39+sxI8UVcP1UW9uYhuVDyNlsFxkhpg5vEkBT2qF3r+kKMkpwgegTJ7IUnF goX4pPcZY52iJFyDeGX34Mw78SBejazHYtkCttzMxtg1s5taRx/jAoBmR5KUfWVVycgO djuyj338z1jhyn6u7kml1Cv5npyDSmvP5Gqv04UCx+28VQCdVGZvf3eDPGUi1kSDtGZJ xvOc4Ugifa3rkY6qn2DPFGQp79ezbt3nuCQY3nUoskSuiog5+Klbi5eade2IcJGIt0O2 pFAA== X-Gm-Message-State: AO0yUKUbWYijc7A6qTe21+ZXnWlpYyCQRkMl/3MdAoDHW3So4eKffbKJ UcLctFH799XOBF3/iqH5gEs= X-Google-Smtp-Source: AK7set/rTgp4gFxp3iIEaEgZ0yhnqAhCJQb+wdyYEJE+Ke7gpbiz0QtjngUw11+nHcPp/BChasRD2w== X-Received: by 2002:a05:651c:d0:b0:299:a55a:f66f with SMTP id 16-20020a05651c00d000b00299a55af66fmr1060797ljr.22.1679407975893; Tue, 21 Mar 2023 07:12:55 -0700 (PDT) Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id y2-20020a05651c020200b00295a33eda65sm2245421ljn.137.2023.03.21.07.12.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Mar 2023 07:12:55 -0700 (PDT) Message-ID: <3d51b11e-e53d-85a8-9ed7-eccc40d92b36@gmail.com> Date: Tue, 21 Mar 2023 21:12:53 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4] lisp/ob-screen.el: Support ~:var~ header args for babel blocks Content-Language: en-US To: Ken Mankoff Cc: emacs-orgmode@gnu.org References: <87pm9z8089.fsf@t480.home> <87y1om7w23.fsf@t480.home> <96a91a35-eeb6-55d3-683d-5d51ff6d496e@gmail.com> <877cw5aiab.fsf@t480.home> <87sfet7kul.fsf@t480.home> <0e841ec9-f770-4f4f-a5e6-eb15290ab8a7@gmail.com> <87k003swax.fsf@t480.home> <87a60yxec3.fsf@localhost> <874jqluyfp.fsf@t480.home> <87v8j1t2qf.fsf@localhost> <276112c4-c9bd-36a0-1e70-36a955b7d3c9@gmail.com> <874jqgreev.fsf@t480.home> From: Max Nikulin Mail-Followup-To: Ken Mankoff , emacs-orgmode@gnu.org In-Reply-To: <874jqgreev.fsf@t480.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::22a; envelope-from=manikulin@gmail.com; helo=mail-lj1-x22a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: 7469BDF9B X-Spam-Score: -2.45 X-Migadu-Spam-Score: -2.45 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: Yj7J93rF43qR On 19/03/2023 21:42, Ken Mankoff wrote: > Here is the other patch. Respect custom screen command. Thanks, Ken. > +++ b/lisp/ob-screen.el > @@ -98,7 +98,7 @@ In case you want to use a different screen than one selected by your $PATH") > > (defun org-babel-screen-session-socketname (session) > "Check if SESSION exists by parsing output of \"screen -ls\"." > - (let* ((screen-ls (shell-command-to-string "screen -ls")) > + (let* ((screen-ls (shell-command-to-string (concat org-babel-screen-location " -ls"))) Currently `org-babel-screen-location' is used as an argument of `start-process', so if the value contains spaces or other shell special characters they are not interpreted by shell. Since there is no convenience function like process-to-string that accepts command as list instead of string with a shell command, it is better to pass screen location through `shell-quote-argument'. You may try to create a directory with a space in its name, create a symlink from this directory to /usr/bin/srceen, and set `org-babel-screen-location' to the full path (with space).