emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Max Nikulin <manikulin@gmail.com>
To: Ken Mankoff <mankoff@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH v4] lisp/ob-screen.el: Support ~:var~ header args for babel blocks
Date: Tue, 21 Mar 2023 21:12:53 +0700	[thread overview]
Message-ID: <3d51b11e-e53d-85a8-9ed7-eccc40d92b36@gmail.com> (raw)
In-Reply-To: <874jqgreev.fsf@t480.home>

On 19/03/2023 21:42, Ken Mankoff wrote:
> Here is the other patch. Respect custom screen command.

Thanks, Ken.

> +++ b/lisp/ob-screen.el
> @@ -98,7 +98,7 @@ In case you want to use a different screen than one selected by your $PATH")
>   
>   (defun org-babel-screen-session-socketname (session)
>     "Check if SESSION exists by parsing output of \"screen -ls\"."
> -  (let* ((screen-ls (shell-command-to-string "screen -ls"))
> +  (let* ((screen-ls (shell-command-to-string (concat org-babel-screen-location " -ls")))

Currently `org-babel-screen-location' is used as an argument of 
`start-process', so if the value contains spaces or other shell special 
characters they are not interpreted by shell. Since there is no 
convenience function like process-to-string that accepts command as list 
instead of string with a shell command, it is better to pass screen 
location through `shell-quote-argument'.

You may try to create a directory with a space in its name, create a 
symlink from this directory to /usr/bin/srceen, and set 
`org-babel-screen-location' to the full path (with space).

next prev parent reply	other threads:[~2023-03-21 14:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-24 17:03 [PATCH] lisp/ob-screen.el: Support ~:var~ header args for babel blocks Ken Mankoff
2023-02-24 18:33 ` Ken Mankoff
2023-02-25  3:51   ` Max Nikulin
2023-02-25 15:14     ` Ken Mankoff
2023-02-25 15:19       ` Ken Mankoff
2023-02-25 16:05       ` Max Nikulin
2023-02-25 16:47         ` Ken Mankoff
2023-02-26 10:11           ` Max Nikulin
2023-02-27  1:59             ` Ken Mankoff
2023-02-28 10:40               ` Ihor Radchenko
2023-03-16  4:12                 ` Ken Mankoff
2023-03-16 10:22                   ` Ihor Radchenko
2023-03-16 15:09                     ` [PATCH v4] " Max Nikulin
2023-03-17 11:41                       ` Max Nikulin
2023-03-18 12:08                       ` Ihor Radchenko
2023-03-19 14:42                       ` Ken Mankoff
2023-03-21 14:12                         ` Max Nikulin [this message]
2023-03-02 13:38               ` [PATCH] " Max Nikulin
2023-02-26 12:18           ` Ihor Radchenko
2023-02-27  1:59             ` Ken Mankoff
2023-02-27 19:43               ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d51b11e-e53d-85a8-9ed7-eccc40d92b36@gmail.com \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mankoff@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).