From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Re: Latex Export: Place Caption Below Table Date: Mon, 10 Oct 2011 21:05:18 +0200 Message-ID: <3F050B9E-FA07-45BD-88BC-F4370D550100@gmail.com> References: <87zkhor9hb.fsf@ucl.ac.uk> <17486.1317238846@alphaville.dokosmarshall.org> <878vp2fqch.fsf@ucl.ac.uk> <701.1317652994@alphaville.dokosmarshall.org> <12B289CE-8698-4728-9911-EF945AB39D71@gmail.com> Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([140.186.70.92]:49786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDLAD-0008Ts-Em for emacs-orgmode@gnu.org; Mon, 10 Oct 2011 15:05:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RDLAA-0000su-V6 for emacs-orgmode@gnu.org; Mon, 10 Oct 2011 15:05:25 -0400 Received: from mail-ey0-f169.google.com ([209.85.215.169]:54623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDLAA-0000sg-KY for emacs-orgmode@gnu.org; Mon, 10 Oct 2011 15:05:22 -0400 Received: by eye4 with SMTP id 4so1075162eye.0 for ; Mon, 10 Oct 2011 12:05:21 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Thomas S. Dye" Cc: nicholas.dokos@hp.com, emacs-orgmode@gnu.org, Jakob Lombacher Applied, thanks. - Carsten On 10.10.2011, at 01:24, Thomas S. Dye wrote: > Carsten Dominik writes: >=20 >> On 3.10.2011, at 16:43, Nick Dokos wrote: >>=20 >>> Eric S Fraga wrote: >>>=20 >>>> tsd@tsdye.com (Thomas S. Dye) writes: >>>>=20 >>>>> Nick Dokos writes: >>>>=20 >>>>>> The following patch (deliberately hidden as a binary octet-stream = to keep it >>>>>> out of patchwork) will do that - but IMO, it would be better to = have yet another >>>>>> user-settable option to control the placement. >>>>>>=20 >>>>>> Nick >>>>>>=20 >>>>>>=20 >>>>>=20 >>>>> Aloha all, >>>>>=20 >>>>> The inlined patch introduces a variable >>>>> org-export-latex-table-caption-above to control the placement of = table >>>>> captions. Thanks to Nick Dokos for leading the way on this. >>>>>=20 >>>>> Tom >>>>=20 >>>>=20 >>>> thanks for doing this -- I was swamped last week so had no chance = of >>>> following the thread until today! >>>>=20 >>>> One comment on the last version of the patch: would it not be = better for >>>> the variable to be a defcustom variable instead of defvar? >>>=20 >>> I agree - being able to customize variables without resorting to = lisp is >>> generally preferable: it is friendlier to newcomers and it allows = even >>> experienced users to find the various knobs. >>=20 >> If you provide a new patch doing a defcustom, I think this patch = would be >> good to have. Please go ahead and check it in! >>=20 >> - Carsten >>=20 >=20 > Aloha Carsten, >=20 > The inlined patch changes the defvar to a defcustom. It is meant to = be > applied after the first patch. >=20 > All the best, > Tom >=20 > =46rom af153cdaa827903e4ada316b99adef25a735ada7 Mon Sep 17 00:00:00 = 2001 > From: Tom Dye > Date: Sun, 9 Oct 2011 13:09:02 -1000 > Subject: [PATCH 2/2] LaTeX export: Add switch to place captions above = or below tables >=20 > * lisp/org-latex.el (org-export-latex-tables): Add new variable > org-export-latex-table-caption-above >=20 > Modified from an idea suggested by Eric Fraga and fleshed out by Nick = Dokos. > --- > lisp/org-latex.el | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) >=20 > diff --git a/lisp/org-latex.el b/lisp/org-latex.el > index f91b93e..7957ffe 100644 > --- a/lisp/org-latex.el > +++ b/lisp/org-latex.el > @@ -73,7 +73,6 @@ > org-deadline-string "\\|" > org-closed-string"\\)") > "Regexp matching special time planning keywords plus the time after = it.") > -(defvar org-export-latex-table-caption-above t) > (defvar org-re-quote) ; dynamically scoped from org.el > (defvar org-commentsp) ; dynamically scoped from org.el >=20 > @@ -364,6 +363,12 @@ When nil, grouping causes only separation lines = between groups." > :group 'org-export-latex > :type 'boolean) >=20 > +(defcustom org-export-latex-table-caption-above t > + "When non-nil, the caption is set above the table. When nil, > +the caption is set below the table." > + :group 'org-export-latex > + :type 'boolean) > + > (defcustom org-export-latex-low-levels 'itemize > "How to convert sections below the current level of sectioning. > This is specified by the `org-export-headline-levels' option or the > --=20 > 1.7.1 >=20 >=20 >=20 >>>=20 >>> If the patch is deemed acceptable, it might also be nice to be able = to >>> set the variable per-file through the OPTIONS line, but that can >>> certainly wait. >>>=20 >>>> Otherwise, >>>> the patch looks fine to me although I'm unlikely to use the new >>>> functionality ;-) >>>=20 >>> Unless you try to publish an article in a journal with a perverse = layout >>> policy :-) >>>=20 >>> I applied the patch and took it for a short spin. git complained = about >>> trailing whitespace: >>>=20 >>> ,---- >>> | /home/nick/Mail/inbox/1021:197: trailing whitespace. >>> | (if (and floatp = org-export-latex-table-caption-above)=20 >>> | /home/nick/Mail/inbox/1021:212: trailing whitespace. >>> | (if (and floatp (not = org-export-latex-table-caption-above))=20 >>> | /home/nick/Mail/inbox/1021:225: trailing whitespace. >>> | (if (not org-export-latex-table-caption-above) = tbl)=20 >>> | /home/nick/Mail/inbox/1021:231: trailing whitespace. >>> | (if org-export-latex-table-caption-above tbl)=20 >>> | warning: 4 lines add whitespace errors. >>> `---- >>>=20 >>> but other than that the patch worked fine. >>>=20 >>> Thanks, Tom! >>> Nick >>>=20 >>>=20 >>>=20 >>=20 >>=20 >>=20 >=20 > --=20 > Thomas S. Dye > http://www.tsdye.com