From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Galen Menzel" <galen.menzel@utexas.edu>
Subject: Re: [PATCH] Fix two false failures in org's test suite
Date: Thu, 10 Aug 2017 10:58:00 -0700
Message-ID: <38D8B898-1E62-4916-AD55-DA42DE5D7CA7@utexas.edu>
References: <F30743AD-0F32-46D4-AA0D-BB3391C1A9C6@utexas.edu>
	<87y3qr9186.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; format=flowed
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58700)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <galen.menzel@utexas.edu>) id 1dfrih-0005RD-4g
	for emacs-orgmode@gnu.org; Thu, 10 Aug 2017 13:58:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <galen.menzel@utexas.edu>) id 1dfric-0001bd-VV
	for emacs-orgmode@gnu.org; Thu, 10 Aug 2017 13:58:07 -0400
Received: from mail-pg0-x22e.google.com ([2607:f8b0:400e:c05::22e]:36570)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <galen.menzel@utexas.edu>)
	id 1dfric-0001Z1-Mk
	for emacs-orgmode@gnu.org; Thu, 10 Aug 2017 13:58:02 -0400
Received: by mail-pg0-x22e.google.com with SMTP id v77so5795259pgb.3
	for <emacs-orgmode@gnu.org>; Thu, 10 Aug 2017 10:58:01 -0700 (PDT)
In-Reply-To: <87y3qr9186.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org

Hi Nicolas,

On 10 Aug 2017, at 3:16, Nicolas Goaziou wrote:

>> -	     (lambda () '(22353 6425 905205 644000))))
>> +	     (lambda ()
>> +	       (apply #'encode-time
>> +		      (org-parse-time-string "2016-06-03 Fri 01:43")))))
>
> Shouldn't this be
>
>   (org-parse-time-string "..." nil t)
>
> to force UTC?

I don't believe so.

org-deadline-close-p interprets its timestamp-string argument as being 
in the local time zone (i.e., the call to encode-time that results from 
calling org-deadline-close-p always has a nil zone argument). Since we 
are using "2016-06-03 Fri 01:43" as the ersatz current time to check if 
deadlines are close, then "2016-06-03 Fri 01:43" should be in the local 
time zone as well.

As I would expect, forcing UTC here makes the test fail on my machine.

Best,

Galen