From: Philipp Kiefer <phil.kiefer@gmail.com>
To: Ruijie Yu <ruijie@netyu.xyz>
Cc: emacs-orgmode@gnu.org
Subject: Re: [Bug] 'org-font-lock-extra-keywords' appear next to the parent heading when its subtree is folded.
Date: Tue, 24 Jan 2023 15:13:17 +0100 [thread overview]
Message-ID: <3875d398-9cb1-02a1-4b8d-5f71fcb111fe@gmail.com> (raw)
In-Reply-To: <sdvy1pseg64.fsf@fw.net.yu>
On 24.01.2023 04:52, Ruijie Yu wrote:
> Philipp Kiefer <phil.kiefer@gmail.com> writes:
>
>> Org mode version 9.6.1, GNU Emacs 27.2 (build 1, x86_64-w64-mingw32)
>>
>> Please see the two screenshots here for illustration:
>>
>> https://imgur.com/a/7EuUi0J
>>
>> (I'm assuming it's not a good idea - or not even possible - to send e-mail attachments to the list?)
>>
>> This is the relevant code from my init.el that seems to be causing this issue:
>>
>> (require 'org-habit nil t) ; relevant?
>> (defun org-add-my-extra-fonts ()
>> "Add alert and overdue fonts."
>> (add-to-list 'org-font-lock-extra-keywords '("\\(³\\)\\([^\n\r\t]+\\)\\(³\\)" (1 '(face org-habit-alert-face invisible nil)) (2 'org-habit-alert-face t) (3 '(face
>> org-habit-alert-face invisible nil))) t)
>> (add-to-list 'org-font-lock-extra-keywords '("\\(§\\)\\([^\n\r\t]+\\)\\(§\\)" (1 '(face org-habit-overdue-face invisible nil)) (2 'org-habit-overdue-face t) (3
>> '(face org-habit-overdue-face invisible nil))) t)
>> (add-to-list 'org-font-lock-extra-keywords '("\\(@\\)\\([^\n\r\t]+\\)\\(@\\)" (1 '(face org-habit-clear-face invisible nil)) (2 'org-habit-clear-face t) (3 '(face
>> org-habit-clear-face invisible nil))) t))
>> (add-hook 'org-font-lock-set-keywords-hook #'org-add-my-extra-fonts)
>>
>> Can you reproduce it?
>>
>> Thanks!
> I am in a region where imgur is unavailable -- can you attach a minimal
> org file where the issue manifests, and briefly describe what happens
> and should happen?
Sorry, will attach such an org file in my reply to Ihor later.
> Also, while looking into your init code, I noticed that
> `org-font-lock-extra-keywords' seems to be public-facing (as there is no
> double-dashes in the name), but has no docstring. Either this variable
> was intended to be private, or someone forgot to put a docstring to this
> variable.
Thanks for making me realize that much of what is in my init.el is miles
from 'best practice'. At the time I cobbled it together, I was just
happy when things eventually worked the way I wanted them to and did not
bother overmuch with proper procedure. No surprise then that it is
coming back to bite me.
Will put in a 'defvar' statement with a docstring and rename all my
private functions from 'org-xxx' to 'org--xxx'.
next prev parent reply other threads:[~2023-01-24 17:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 21:58 [Bug] 'org-font-lock-extra-keywords' appear next to the parent heading when its subtree is folded Philipp Kiefer
2023-01-24 3:52 ` Ruijie Yu via General discussions about Org-mode.
2023-01-24 11:36 ` Ihor Radchenko
2023-01-24 14:13 ` Philipp Kiefer [this message]
2023-01-24 11:34 ` Ihor Radchenko
2023-01-24 17:37 ` Philipp Kiefer
2023-01-24 17:56 ` Ihor Radchenko
2023-01-25 10:37 ` Philipp Kiefer
2023-01-24 18:07 ` Ihor Radchenko
[not found] ` <29a87ef7-c094-8885-6ae6-2548563c7583@gmail.com>
[not found] ` <78025786-639a-9ddd-bd7c-400f5e84da53@gmail.com>
[not found] ` <87y1ppwt9v.fsf@localhost>
2023-02-16 21:26 ` Philipp Kiefer
2023-02-17 12:01 ` Ihor Radchenko
2023-02-17 17:55 ` Philipp Kiefer
2023-02-17 18:25 ` Ihor Radchenko
2023-02-17 20:11 ` Philipp Kiefer
2023-02-18 10:41 ` Ihor Radchenko
2023-02-18 11:20 ` Philipp Kiefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3875d398-9cb1-02a1-4b8d-5f71fcb111fe@gmail.com \
--to=phil.kiefer@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=ruijie@netyu.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).