From: Carsten Dominik <carsten.dominik@gmail.com>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: emacs-orgmode@gnu.org, David Edmondson <dme@dme.org>
Subject: Re: Agenda Bulk Scatter bug
Date: Tue, 14 Jun 2011 10:51:54 +0200 [thread overview]
Message-ID: <36CED999-3462-41AA-8A19-6FB41A0F967B@gmail.com> (raw)
In-Reply-To: <41EE7AE4-27D5-4925-A4AF-6B0E93C00164@gmail.com>
On Jun 14, 2011, at 10:41 AM, Carsten Dominik wrote:
> Hi David,
>
> On Jun 10, 2011, at 11:05 AM, David Edmondson wrote:
>
>> * carsten.dominik@gmail.com [2011-06-10 Fri 09:20]
>>> Hi, I need a few testers: Something very strange is going on here.
>>>
>>> When I evaluate this form
>>>
>>> (decode-time (days-to-time (time-to-days (current-time))))
>>>
>>> I get a date in the year 3980. I think this used to work.
>>> Is there anyone who has an idea what is going on here?
>>
>> (decode-time (days-to-time (time-to-days (current-time))))
>> => (0 0 1 10 6 3980 2 t 3600)
>>
>> With "GNU Emacs 24.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 2.20.1) of
>> 2011-02-10 on keller, modified by Debian".
>>
>> (time-to-days) returns the number of days since 0001-12-31bce, which
>> (days-to-time) converts into a time value. That time value is relative
>> to 0001-12-31bce, _not_ relative to 1970-01-01, which is what
>> (decode-time) is expecting.
>>
>> Hence you end up 1970 years out.
>
> Thank you for the analysis - the bulk scattering
> command should now again work as advertised.
OK, only after the git server starts working again.
Until then, here is the patch:
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 65f37d4..b519ff2 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -8199,9 +8199,11 @@ The prefix arg is passed through to the command if possible."
(setq day-of-week 0)))))
;; silently fail when try to replan a sexp entry
(condition-case nil
- (org-agenda-schedule nil
- (days-to-time
- (+ (org-today) distance)))
+ (let* ((date (calendar-gregorian-from-absolute
+ (+ (org-today) distance)))
+ (time (encode-time 0 0 0 (nth 1 date) (nth 0 date)
+ (nth 2 date))))
+ (org-agenda-schedule nil time))
(error nil)))))))
((equal action ?f)
next prev parent reply other threads:[~2011-06-14 8:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-04 4:54 Agenda Bulk Scatter bug Robert Cunningham
2011-06-08 12:33 ` Christian Egli
2011-06-10 8:20 ` Carsten Dominik
2011-06-10 9:05 ` David Edmondson
2011-06-14 8:41 ` Carsten Dominik
2011-06-14 8:51 ` Carsten Dominik [this message]
2011-06-10 19:16 ` Achim Gratz
2011-06-10 19:51 ` Nick Dokos
2011-06-10 21:32 ` Michael Brand
2011-06-11 8:43 ` Robert Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36CED999-3462-41AA-8A19-6FB41A0F967B@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=dme@dme.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).