emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Sébastien Miquel" <sebastien.miquel@posteo.eu>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] tangling seems to have broken today
Date: Thu,  6 May 2021 11:35:05 +0000	[thread overview]
Message-ID: <346c8e9e-8d1d-bf2a-cf24-b1f6a7c804f3@posteo.eu> (raw)
In-Reply-To: <878s4sru5f.fsf@gnu.org>

Hi Bastien,

Bastien writes:
> Also, nitpick: please don't add a full-stop at the end of the first
> line of the commit message (or the subject of your patch).
Unless I misunderstand what you mean, the patch seems to follow this
style.

> I think this should be applied to the maint branch, right?  In this
> case, the patch does not apply.  Can you check and repropose a patch
> against maint?  Or just let me know if I'm mistaken.
It fixes an issue introduced by a commit in master, so it should be
applied to master.

> So we're all set here?
This should be it!


Regards,

-- 
Sébastien Miquel



  reply	other threads:[~2021-05-06 11:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 13:38 Eric S Fraga
2021-05-05 13:41 ` Timothy
2021-05-05 13:45   ` Bastien
2021-05-05 16:22     ` [PATCH] " Sébastien Miquel
2021-05-06 11:14       ` Bastien
2021-05-06 11:35         ` Sébastien Miquel [this message]
2021-05-06 11:38           ` Bastien
2021-05-06 11:19       ` Bastien
2021-05-05 13:54 ` Sébastien Miquel
2021-05-05 14:08   ` Eric S Fraga
2021-05-05 14:17     ` Sébastien Miquel
2021-05-05 14:20       ` Eric S Fraga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=346c8e9e-8d1d-bf2a-cf24-b1f6a7c804f3@posteo.eu \
    --to=sebastien.miquel@posteo.eu \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: [PATCH] tangling seems to have broken today' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).