From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Re: [bug] org-link-escape and (wrong-type-argument stringp nil) Date: Wed, 29 Sep 2010 17:48:04 +0200 Message-ID: <33DDDFB0-E2DF-43CE-B307-85032F92B03A@gmail.com> References: <8739swi0f0.fsf@gmx.de> <1285565761-7558-1-git-send-email-dmaus@ictsoc.de> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable Return-path: Received: from [140.186.70.92] (port=34706 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0yt9-0005DC-Ol for emacs-orgmode@gnu.org; Wed, 29 Sep 2010 11:48:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0yt8-0008OM-Iy for emacs-orgmode@gnu.org; Wed, 29 Sep 2010 11:48:11 -0400 Received: from mail-ew0-f41.google.com ([209.85.215.41]:62290) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0yt8-0008O3-CY for emacs-orgmode@gnu.org; Wed, 29 Sep 2010 11:48:10 -0400 Received: by ewy19 with SMTP id 19so361721ewy.0 for ; Wed, 29 Sep 2010 08:48:09 -0700 (PDT) In-Reply-To: <1285565761-7558-1-git-send-email-dmaus@ictsoc.de> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: David Maus Cc: emacs-orgmode@gnu.org Hi David, I have not have time to follow this in detail, but if you feel =20 confident that this is doing the right thing, pleas go ahead and apply the necessary =20 patches. I am an encoding moron, so I am easily convinced that you =20 and Sebastian together cook up something useful. :-) - Carsten On Sep 27, 2010, at 7:36 AM, David Maus wrote: >> Also I guess the decoding is secure. Means we could change the >> comment of this function: > >> (defun org-protocol-unhex-compound (hex) >> "Unhexify unicode hex-chars. E.g. `%C3%B6' is the German Umlaut `=F6'.= >> Note: this function falls back on single byte decoding if a >> character sequence is not valid utf-8. >> See `org-protocol-unhex-single-byte-sequence'." > > >> Should I send another patch against master? (Too late here... for >> me...) > > Not necessary, following patch removed this sentence and added a > proper commit message (please see: Commit messages and ChangeLog > entries on http://orgmode.org/worg/org-contribute.php). > > I took the new patch "under review" in patchtracker -- If someone else > wants to jump on it, just go ahead. > > Best, > -- David > > Sebastian Rose (1): > Decode single byte sequence if decoding unicode failed. > > lisp/org-protocol.el | 26 +++++++++++++++++++++++--- > 1 files changed, 23 insertions(+), 3 deletions(-) > > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode