From: Axel Kielhorn <org-mode@axelkielhorn.de>
To: Org-Mode Mailing List <emacs-orgmode@gnu.org>
Subject: Re: [DRAFT PATCH v2] Decouple LANG= and testing (was: Test failure due to LANG)
Date: Sat, 22 Apr 2023 16:50:01 +0200 [thread overview]
Message-ID: <32E3D56A-9DDF-4D70-BBA6-2DB71919EC98@axelkielhorn.de> (raw)
In-Reply-To: <sdvedocukz1.fsf@netyu.xyz>
> Am 22.04.2023 um 15:01 schrieb Ruijie Yu via General discussions about Org-mode. <emacs-orgmode@gnu.org>:
>
>
> Ruijie Yu via "General discussions about Org-mode." <emacs-orgmode@gnu.org> writes:
>
>> Ruijie Yu via "General discussions about Org-mode." <emacs-orgmode@gnu.org> writes:
>>
>>> Ruijie Yu via "General discussions about Org-mode." <emacs-orgmode@gnu.org> writes:
>>>
>>>> Axel Kielhorn <org-mode@axelkielhorn.de> writes:
>>>>
>>>>> Hello!
>>>>>
>>>>> I’m building org with LANG=de.
>>>>> As a result I get two failed tests:
>>>>
>>>> Reproducible using "LANG=zh_CN.UTF-8". In fact, I got more failed tests
>>>> in my testing. I think the OP's two test failures are due to hardcoded
>>>> English expected result, whereas the additional test failures on my
>>>> testing are probably due to the fact that each Chinese character is as
>>>> wide as two latin letters, which catches some testing code offguard.
>>>>
>>>> Here are the test names that failed unexpectedly for me. All the
>>>> "should"'s and "should-not"'s are in the attachment below.
>>>>
>>>> --8<---------------cut here---------------start------------->8---
>>>> 8 unexpected results:
>>>> FAILED test-org-clock/clock-drawer-dwim
>>>> FAILED test-org-clock/clocktable/lang
>>>> FAILED test-org-clok/org-clock-timestamps-change
>>>> FAILED test-org-colview/columns-width
>>>> FAILED test-org/add-planning-info
>>>> FAILED test-org/clone-with-time-shift
>>>> FAILED test-org/deadline
>>>> FAILED test-org/schedule
>>>> --8<---------------cut here---------------end--------------->8---
>>>>
>>>> [3. text/plain; lang.txt]...
>>>
>>> Update: interestingly, there is one test error when setting
>>> "LANG=en_US.UTF-8" or "LANG=C".
>>>
>>> [2. text/plain; lang-en-us-utf8.txt]...
>>>
>>>
>>> And, two somewhat different test errors when setting "LANG=fr_FR.UTF-8".
>>>
>>> [4. text/plain; lang-fr-fr-utf8.txt]...
>>
>> Axel, does this patch fix test-org-clock/clock-drawer-dwim on your
>> system?
>>
>> [2. text/x-patch; 0001-testing-lisp-test-org-clock.el.patch]...
>
> Here is an updated patch (replacing the first iteration). This should
> hopefully fix both test failures that Axel found. Once this is
> confirmed good, I will look at the test failures of the other languages
> to see what I can do.
>
> <0001-DRAFT-Fix-dependence-on-locale-in-org-testing-facili.patch>
With this patch I get:
FAILED test-org-clock/clock-drawer-dwim arrayp
FAILED test-org-clok/org-clock-timestamps-change arrayp
Axel
next prev parent reply other threads:[~2023-04-22 14:51 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-22 7:11 Test failure due to LANG Axel Kielhorn
2023-04-22 9:51 ` Ruijie Yu via General discussions about Org-mode.
2023-04-22 10:15 ` Ruijie Yu via General discussions about Org-mode.
2023-04-22 12:37 ` Ruijie Yu via General discussions about Org-mode.
2023-04-22 13:01 ` [DRAFT PATCH v2] Decouple LANG= and testing (was: Test failure due to LANG) Ruijie Yu via General discussions about Org-mode.
2023-04-22 13:51 ` Ruijie Yu via General discussions about Org-mode.
2023-04-23 10:54 ` Ihor Radchenko
[not found] ` <sdvjzy2rhne.fsf@netyu.xyz>
2023-04-23 11:19 ` Ihor Radchenko
2023-04-23 14:30 ` Ruijie Yu via General discussions about Org-mode.
2023-04-23 15:03 ` Ihor Radchenko
2023-04-23 15:15 ` Ruijie Yu via General discussions about Org-mode.
2023-04-25 10:11 ` Ihor Radchenko
2023-04-25 15:14 ` Ruijie Yu via General discussions about Org-mode.
2023-04-22 14:50 ` Axel Kielhorn [this message]
2023-04-22 15:03 ` Ruijie Yu via General discussions about Org-mode.
2023-04-23 1:47 ` [DRAFT PATCH v3] " Ruijie Yu via General discussions about Org-mode.
2023-04-23 5:36 ` Axel Kielhorn
2023-04-23 6:46 ` [DRAFT PATCH v4] " Ruijie Yu via General discussions about Org-mode.
2023-04-23 11:17 ` Ihor Radchenko
2023-04-23 13:57 ` Ruijie Yu via General discussions about Org-mode.
2023-04-23 15:07 ` Ihor Radchenko
2023-04-25 8:02 ` [DRAFT PATCH v5] " Ruijie Yu via General discussions about Org-mode.
2023-04-25 15:19 ` [DRAFT PATCH v6] " Ruijie Yu via General discussions about Org-mode.
2023-04-26 9:05 ` Ihor Radchenko
2023-04-26 8:44 ` [DRAFT PATCH v5] " Ihor Radchenko
2023-07-17 8:58 ` Ihor Radchenko
2023-04-22 14:28 ` Test failure due to LANG Axel Kielhorn
2023-04-22 12:35 ` Ihor Radchenko
2023-04-22 13:00 ` Ruijie Yu via General discussions about Org-mode.
2023-04-22 14:21 ` Max Nikulin
2023-04-22 14:35 ` Ihor Radchenko
2023-04-22 14:40 ` Axel Kielhorn
2023-04-22 16:14 ` Max Nikulin
2023-04-22 14:36 ` Axel Kielhorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32E3D56A-9DDF-4D70-BBA6-2DB71919EC98@axelkielhorn.de \
--to=org-mode@axelkielhorn.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).