From: Carsten Dominik <dominik@science.uva.nl>
To: Peter Jones <mlists@pmade.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Conditionally delete windows in agenda quit
Date: Sun, 1 Mar 2009 17:18:52 +0100 [thread overview]
Message-ID: <3230F90D-55AC-4EE7-A49F-3C72D0411224@uva.nl> (raw)
In-Reply-To: <m2ocwnmmx7.fsf@pmade.com>
I am accepting this patch, thanks.
- Carsten
On Feb 28, 2009, at 1:21 AM, Peter Jones wrote:
> Before this patch, org-agenda-quit would delete the agenda window if
> the frame had more than one window. This patch changes that behavior
> slightly so that if org-agenda-window-setup is 'current-window, the
> agenda window won't be deleted.
>
> Patch also available from:
>
> git://pmade.com/org-mode
> branch: pjones-agenda-quit
>
> From 94a5f5f9487a2ccdd4d38d1b989720a89d1d10b6 Mon Sep 17 00:00:00 2001
> From: Peter Jones <pjones@pmade.com>
> Date: Fri, 27 Feb 2009 17:17:12 -0700
> Subject: [PATCH] Conditionally delete windows in agenda quit
>
> Before this patch, org-agenda-quit would delete the agenda window if
> the frame had more than one window. This patch changes that behavior
> slightly so that if org-agenda-window-setup is 'current-window, the
> agenda window won't be deleted.
> ---
> lisp/org-agenda.el | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 3fb7baf..dbfa5f6 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -4455,7 +4455,9 @@ If ERROR is non-nil, throw an error, otherwise
> just return nil."
> (if org-agenda-columns-active
> (org-columns-quit)
> (let ((buf (current-buffer)))
> - (if (not (one-window-p)) (delete-window))
> + (and (not (eq org-agenda-window-setup 'current-window))
> + (not (one-window-p))
> + (delete-window))
> (kill-buffer buf)
> (org-agenda-reset-markers)
> (org-columns-remove-overlays)
> --
> 1.6.0
>
>
> --
> Peter Jones, http://pmade.com
> pmade inc. Louisville, CO US
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
prev parent reply other threads:[~2009-03-01 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-28 0:21 [PATCH] Conditionally delete windows in agenda quit Peter Jones
2009-03-01 16:18 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3230F90D-55AC-4EE7-A49F-3C72D0411224@uva.nl \
--to=dominik@science.uva.nl \
--cc=emacs-orgmode@gnu.org \
--cc=mlists@pmade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).