Re: [PATCH] Always run org-insert-heading-hook when creating headlines

From: Carsten Dominik <carsten.dominik@gmail.com>
To: Bernt Hansen <bernt@norang.ca>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Always run org-insert-heading-hook when creating headlines
Date: Wed, 29 Sep 2010 16:44:48 +0200	[thread overview]
Message-ID: <30F91C5F-07A4-400F-AA94-60DEB88BD77B@gmail.com> (raw)
In-Reply-To: <1285510512-31684-1-git-send-email-bernt@norang.ca>

Hi Bernt,

this patch does not work, it calls the hook also after inserting a new  
item.

Please fix it by first reverting, and then call the hook also inside  
the if clause, right after (insert "\n") - you need progn then, of  
course.

Thanks.

- Carsten

On Sep 26, 2010, at 4:15 PM, Bernt Hansen wrote:

> * lisp/org.el (org-insert-heading): Run org-insert-heading-hook when  
> creating
> the first heading in a file
>
> The org-insert-heading-hook was skipped when creating the first
> heading in a new org file.
> ---
>
> I use an hook which creates an inactive timestamp for new headings.   
> This was reported
> by k-man on the mailing list stating it doesn't work for empty org  
> files when creating
> the first heading.
>
> I use the following hook:
>
> (defun bh/insert-inactive-timestamp ()
>  (interactive)
>  (org-insert-time-stamp nil t t nil nil nil))
>
> (defun bh/insert-heading-inactive-timestamp ()
>  (save-excursion
>    (org-return)
>    (org-cycle)
>    (bh/insert-inactive-timestamp)))
>
> (add-hook 'org-insert-heading-hook 'bh/insert-heading-inactive- 
> timestamp)
>
> -Bernt
>
> lisp/org.el |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 75ee798..667a4e4 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -6752,8 +6752,8 @@ This is important for non-interactive uses of  
> the command."
>         (when (and org-insert-heading-respect-content hide-previous)
> 	  (save-excursion
> 	    (goto-char previous-pos)
> -	    (hide-subtree)))
> -	(run-hooks 'org-insert-heading-hook)))))
> +	    (hide-subtree))))))
> +  (run-hooks 'org-insert-heading-hook))
>
> (defun org-get-heading (&optional no-tags)
>   "Return the heading of the current entry, without the stars."
> -- 
> 1.7.3
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode