From: Carsten Dominik <carsten.dominik@gmail.com>
To: Stephan Schmitt <drmabuse@cs.tu-berlin.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH 1/2] respect startgroup/endgroup delimiters with description in org-tag-alist
Date: Thu, 5 Nov 2009 16:12:15 +0100 [thread overview]
Message-ID: <30A81012-8AD0-43D1-B5A9-AA0878E033FC@gmail.com> (raw)
In-Reply-To: <1257415055-8120-1-git-send-email-drmabuse@cs.tu-berlin.de>
Applied, thanks.
- Carsten
On Nov 5, 2009, at 10:57 AM, Stephan Schmitt wrote:
> org-agenda-filter-by-tag and org-get-current-options didn't account
> for
> radio group delimiters in org-tag-alist where a description is
> attached
> as second item of the list:
>
> ((:startgroup "context")
> ("Work" . 87)
> ("Home" . 72)
> ("Errand" . 69)
> (:endgroup)
> (:newline)
> (:startgroup "communication")
> ("Mail" . 77)
> ("Call" . 67)
> (:endgroup)
> (:newline)
> ...)
> ---
> lisp/org-agenda.el | 5 ++++-
> lisp/org-exp.el | 5 +++--
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 5e0f4fd..6e90f6f 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -5094,7 +5094,10 @@ to switch to narrowing."
> (interactive "P")
> (let* ((alist org-tag-alist-for-agenda)
> (tag-chars (mapconcat
> - (lambda (x) (if (cdr x) (char-to-string (cdr x)) ""))
> + (lambda (x) (if (and (not (symbolp (car x)))
> + (cdr x))
> + (char-to-string (cdr x))
> + ""))
> alist ""))
> (efforts (org-split-string
> (or (cdr (assoc (concat org-effort-property "_ALL")
> diff --git a/lisp/org-exp.el b/lisp/org-exp.el
> index a71f081..cef29b7 100644
> --- a/lisp/org-exp.el
> +++ b/lisp/org-exp.el
> @@ -2750,8 +2750,9 @@ Does include HTML export options as well as
> TODO and CATEGORY stuff."
> ((not org-log-done) "nologdone"))
> (or (mapconcat (lambda (x)
> (cond
> - ((equal '(:startgroup) x) "{")
> - ((equal '(:endgroup) x) "}")
> + ((equal :startgroup (car x)) "{")
> + ((equal :endgroup (car x)) "}")
> + ((equal :newline (car x)) "")
> ((cdr x) (format "%s(%c)" (car x) (cdr x)))
> (t (car x))))
> (or org-tag-alist (org-get-buffer-tags)) " ") "")
> --
> 1.6.4.4
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
- Carsten
prev parent reply other threads:[~2009-11-05 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 9:57 [PATCH 1/2] respect startgroup/endgroup delimiters with description in org-tag-alist Stephan Schmitt
2009-11-05 9:57 ` [PATCH 2/2] set variables org-timer-timer[123] correctly Stephan Schmitt
2009-11-05 15:12 ` Carsten Dominik
2009-11-05 15:12 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30A81012-8AD0-43D1-B5A9-AA0878E033FC@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=drmabuse@cs.tu-berlin.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).