From: Max Nikulin <manikulin@gmail.com>
To: "Aaron L. Zeng" <me@bcc32.com>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] Make predicates non-interactive
Date: Thu, 23 Mar 2023 22:03:38 +0700 [thread overview]
Message-ID: <2fce5ab6-1a13-a6e8-a124-e77785d8147d@gmail.com> (raw)
In-Reply-To: <20230323042244.3893585-1-me@bcc32.com>
On 23/03/2023 11:22, Aaron L. Zeng wrote:
> +++ b/lisp/org.el
...
> @@ -15475,7 +15474,6 @@ If Org mode thinks that point is actually inside
> an embedded LaTeX environment, return t when the environment is math
> or let `texmathp' do its job otherwise.
> `\\[org-cdlatex-mode-map]'"
> - (interactive)
> (cond
> ((not (derived-mode-p 'org-mode)) (apply orig-fun args))
> ((eq this-command 'cdlatex-math-symbol)
Might it be source of problems since `texmathp' is declared as
interactive and the purpose of this function is to be around advice?
Likely it is a false alarm since the functions have no interactive
arguments.
prev parent reply other threads:[~2023-03-23 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 4:22 [PATCH] Make predicates non-interactive Aaron L. Zeng
2023-03-23 12:01 ` Ihor Radchenko
2023-03-23 15:03 ` Max Nikulin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fce5ab6-1a13-a6e8-a124-e77785d8147d@gmail.com \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=me@bcc32.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).