From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Org-remember-handler fix for empty remember buffer Date: Mon, 8 Jun 2009 22:51:18 +0200 Message-ID: <29B0B664-2969-45BB-8B0D-5CD4DEC6CF0A@gmail.com> References: <4A280827.2070705@virginia.edu> <4A2D6A3E.6000707@virginia.edu> Mime-Version: 1.0 (Apple Message framework v935.3) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MDloZ-0005nb-9c for emacs-orgmode@gnu.org; Mon, 08 Jun 2009 16:51:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MDloU-0005kK-Ei for emacs-orgmode@gnu.org; Mon, 08 Jun 2009 16:51:30 -0400 Received: from [199.232.76.173] (port=46544 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MDloU-0005kD-47 for emacs-orgmode@gnu.org; Mon, 08 Jun 2009 16:51:26 -0400 Received: from mail-ew0-f210.google.com ([209.85.219.210]:45888) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MDloT-0007z3-IG for emacs-orgmode@gnu.org; Mon, 08 Jun 2009 16:51:25 -0400 Received: by ewy6 with SMTP id 6so6762498ewy.42 for ; Mon, 08 Jun 2009 13:51:22 -0700 (PDT) In-Reply-To: <4A2D6A3E.6000707@virginia.edu> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Ryan C. Thompson" Cc: emacs-orgmode@gnu.org Hi Ryan, On Jun 8, 2009, at 9:45 PM, Ryan C. Thompson wrote: > Carsten Dominik wrote: >> Fixed, thanks. >> >> - Carsten >> >> On Jun 4, 2009, at 7:45 PM, Ryan C. Thompson wrote: >> >> > If you used the code I sent in my previous email, I discovered a bug > in it. It would delete the last nonblank line as well. I have fixed > this in my code. I've fixed things by copying the function into > my .emacs and then editing it, so generating a diff -u is > nontrivial. I'll do it now though. Thanks. > > Also, I should mention that I'm not an experienced elisp hacker, so > the solution that I came up with might not be the best. No worry, I do look at every patch beore checking it in. - Carsten > --- /usr/share/emacs/site-lisp/org-mode/org-remember.el 2009-03-13 > 10:00:34.000000000 -0400 > +++ org-remember.el 2009-06-08 15:43:04.708905961 -0400 > @@ -740,10 +740,14 @@ > (replace-match "")) > (goto-char (point-max)) > (beginning-of-line 1) > - (while (looking-at "[ \t]*$\\|##.*") > - (delete-region (1- (point)) (point-max)) > - (beginning-of-line 1)) > (catch 'quit > + (while (looking-at "[ \t]*$\\|##.*") > + ;; Abort on empty buffer > + (if (= (point) (point-min)) > + (throw 'quit nil) > + (previous-line))) > + (end-of-line 1) ; end of last nonblank line > + (delete-region (point) (point-max)) > (if org-note-abort (throw 'quit nil)) > (let* ((visitp (org-bound-and-true-p org-jump-to-target-location)) > (previousp (and (member current-prefix-arg '((16) 0))