From: "Sébastien Miquel" <sebastien.miquel@posteo.eu>
To: Bastien <bzg@gnu.org>
Cc: Tom Gillespie <tgbugs@gmail.com>,
emacs-orgmode@gnu.org, No Wayman <iarchivedmywholelife@gmail.com>
Subject: Re: Bug: org-babel-tangle: persmission denied when tangling [9.4.5 (9.4.5-gbc2659 @ /home/n/.emacs.d/straight/build/org/)]
Date: Tue, 4 May 2021 21:19:06 +0000 [thread overview]
Message-ID: <28c262ba-7816-a38f-8d1d-c4d6d880d2e2@posteo.eu> (raw)
In-Reply-To: <87im3ys0ik.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
Hi Bastien,
Bastien writes:
> I tried to apply this (transitory?) patch against maint and it did not
> apply. It applies okay on master. For bug fixes, please make patches
> againt the maint branch.
This fixes a bug introduced by a commit in master. I've attached the same
patch here, properly formated. I think it should be applied to master.
It reverts a part of a2cb9b853: permissions are no longer set before writing
to the tangled file.
I've CC'd Tom, which made the original suggestion. I guess we could set the
write and execute permissions before writing, and set the read permissions
afterwards.
--
Sébastien Miquel
[-- Attachment #2: 0001-ob-tangle.el-org-babel-tangle-Fix-readonly-tangle.patch --]
[-- Type: text/x-patch, Size: 1283 bytes --]
From e56a05f4f5a3cce9cfdeb71854475e29aac1a6e8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Miquel?= <sebastien.miquel@posteo.eu>
Date: Tue, 4 May 2021 22:59:36 +0200
Subject: [PATCH] ob-tangle.el (org-babel-tangle): Fix readonly tangle
* lisp/ob-tangle.el (org-babel-tangle): Fix readonly tangle.
---
lisp/ob-tangle.el | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lisp/ob-tangle.el b/lisp/ob-tangle.el
index 36144d6ae..96a4ef049 100644
--- a/lisp/ob-tangle.el
+++ b/lisp/ob-tangle.el
@@ -268,11 +268,11 @@ matching a regular expression."
lspecs)
(when make-dir
(make-directory fnd 'parents))
- ;; erase previous file and set permissions on empty
- ;; file before writing
- (write-region "" nil file-name nil 0)
- (mapc (lambda (mode) (set-file-modes file-name mode)) modes)
+ ;; erase previous file
+ (when (file-exists-p file-name)
+ (delete-file file-name))
(write-region nil nil file-name)
+ (mapc (lambda (mode) (set-file-modes file-name mode)) modes)
(push file-name path-collector))))))
(if (equal arg '(4))
(org-babel-tangle-single-block 1 t)
--
2.31.1
next prev parent reply other threads:[~2021-05-04 21:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 18:26 No Wayman
2021-05-04 19:25 ` Sébastien Miquel
2021-05-04 19:33 ` No Wayman
2021-05-04 20:27 ` Sébastien Miquel
2021-05-04 20:32 ` Bastien
2021-05-04 21:19 ` Sébastien Miquel [this message]
2021-05-05 3:15 ` No Wayman
2021-05-05 6:49 ` Bug: [PATCH] " Sébastien Miquel
2021-05-05 7:03 ` Bastien
2021-05-05 13:53 ` No Wayman
2021-05-05 6:43 ` Bug: " Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28c262ba-7816-a38f-8d1d-c4d6d880d2e2@posteo.eu \
--to=sebastien.miquel@posteo.eu \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=iarchivedmywholelife@gmail.com \
--cc=tgbugs@gmail.com \
--subject='Re: Bug: org-babel-tangle: persmission denied when tangling [9.4.5 (9.4.5-gbc2659 @ /home/n/.emacs.d/straight/build/org/)]' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).