From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Bug in subtree narrowing Date: Fri, 18 Sep 2009 07:22:44 +0100 Message-ID: <27719CAA-BA26-4AAC-9DC0-9FF839B49945@gmail.com> References: <20524da70909171609k269b816ev18d1a3f2560c7f76@mail.gmail.com> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MoWru-0007XY-0q for emacs-orgmode@gnu.org; Fri, 18 Sep 2009 02:22:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MoWrp-0007X3-9G for emacs-orgmode@gnu.org; Fri, 18 Sep 2009 02:22:53 -0400 Received: from [199.232.76.173] (port=54365 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoWrp-0007X0-1A for emacs-orgmode@gnu.org; Fri, 18 Sep 2009 02:22:49 -0400 Received: from mail-ew0-f211.google.com ([209.85.219.211]:38938) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MoWro-0003GJ-Mc for emacs-orgmode@gnu.org; Fri, 18 Sep 2009 02:22:48 -0400 Received: by ewy7 with SMTP id 7so1022285ewy.31 for ; Thu, 17 Sep 2009 23:22:47 -0700 (PDT) In-Reply-To: <20524da70909171609k269b816ev18d1a3f2560c7f76@mail.gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Samuel Wales Cc: emacs-orgmode@gnu.org On Sep 18, 2009, at 12:09 AM, Samuel Wales wrote: > Hi Carsten, > > org-tree-to-indirect-buffer does not include the final > newline. This causes sorting to run two lines together. > For example, a headline can get joined to an :END: line. > This can cause a task to not be recognized. Fixed for this case. > > Sorting makes a lot of changes, so some users will not > notice the bug until much later. I do not understand what this has to do with narrowing to a subtree? > > org-narrow-to-subtree appears similar. Fixed for this case as well. > > A lot of user code might assume, as perhaps org-sort does, > that the final line has a newline. > > The choice of solution I will leave to you :). > > My preference is for the final newline to exist. Are you suggesting that I should add the final newline? Under what circumstances? Are you aware of the variable `require-final-newline'? It might be for you? I have turned it on. - Carsten > This is > because it feels normal to me as a user. If I go to the end > of the buffer, then up, I usually expect to be on the last > line. If I manually kill a subtree (or a paragraph) I kill > to the beginning of the next line. m-x mark-paragraph > appears to do this. So does m-x kill-paragraph. > > However, I will not file a bug on outline. > outline-mark-subtree (which org users use also) does not include the > final newline. > outline-end-of-subtree does (forward-char -1), which means > that it is deliberate. There are likely to be factors that > I have not considered. > > "Org-mode version 6.30trans (release_6.30d.814.gdacd)" . > > Thanks. > > > Samuel > > > -- > Myalgic encephalomyelitis causes death (Jason et al. 2006) > and severe suffering. Conflicts of interest are destroying > research. What people "know" is wrong. Silence = death. > http://www.meactionuk.org.uk/What_Is_ME_What_Is_CFS.htm > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode