emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nick Dokos <nicholas.dokos@hp.com>
To: Brian Wightman <MidLifeXis@wightmanfam.org>
Cc: nicholas.dokos@hp.com, emacs-orgmode@gnu.org
Subject: Re: [bug] Org link dialog escapes URL spaces incorrectly
Date: Fri, 04 Nov 2011 14:19:20 -0400	[thread overview]
Message-ID: <26749.1320430760@alphaville.dokosmarshall.org> (raw)
In-Reply-To: Message from Brian Wightman <MidLifeXis@wightmanfam.org> of "Fri, 04 Nov 2011 12:56:29 CDT." <CALbR623mDyhC=LRAQBW9-vJxhsFWR0L+xFOKnE3eq5Wn92y04g@mail.gmail.com>

Brian Wightman <MidLifeXis@wightmanfam.org> wrote:

> On Fri, Nov 4, 2011 at 11:52 AM, Nick Dokos <nicholas.dokos@hp.com> wrote:
> > probably not a problem, since unescaping should be idempotent (in contrast to
> > escaping ;-) ) but why do it twice?
> 
> I am not sure I am reading this correctly - I am reading this as
> unescaping a url-encoded twice should give the same results as
> unescaping the same url-encoded string once.  If that is what you are
> saying, I would disagree.  Taking a string similar to the one provided
> originally:
> 
> Did%2520France%2520Cause%2520the%2520Great%2520Depression.pdf
> 
> would be unescaped as
> 
> Did%20France%20Cause%20the%20Great%20Depression.pdf
> 
> and a second unescape would generate
> 
> Did France Cause the Great Depression.pdf
> 
> Hopefully, I am just reading your statement wrong :-)
> 

Nope - you read it right and it (the statement, not the reading)
is wrong.

But I'm not sure what the implications to the code are: do we
have to unescape repeatedly until there are no more % signs
in there? Then the final call to org-make-link-string would
do one escaping pass and that would be that?

My URL fu is weak. Any help would be appreciated.

Thanks,
Nick


 

  parent reply	other threads:[~2011-11-04 18:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-02  2:02 [bug] Org link dialog escapes URL spaces incorrectly Jeff Horn
2011-11-04 15:59 ` Jeff Horn
2011-11-04 16:14   ` Nick Dokos
2011-11-04 16:33   ` Nick Dokos
2011-11-04 16:52     ` Nick Dokos
     [not found]       ` <CALbR623mDyhC=LRAQBW9-vJxhsFWR0L+xFOKnE3eq5Wn92y04g@mail.gmail.com>
2011-11-04 18:19         ` Nick Dokos [this message]
2011-11-04 18:25       ` Nick Dokos
2011-11-05 14:04         ` David Maus
2011-11-05 15:38           ` Nick Dokos
2011-11-06 14:48             ` David Maus
2011-11-06 22:29               ` Nick Dokos
2011-11-13  9:12                 ` David Maus
2011-11-13 17:32                   ` Nick Dokos
2011-12-15  1:30                     ` Jeff Horn
2011-12-18 17:13                       ` David Maus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26749.1320430760@alphaville.dokosmarshall.org \
    --to=nicholas.dokos@hp.com \
    --cc=MidLifeXis@wightmanfam.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).