From: Nick Dokos <nicholas.dokos@hp.com>
To: =?utf-8?Q?Fran=C3=A7ois?= Pinard <pinard@iro.umontreal.ca>
Cc: nicholas.dokos@hp.com, emacs-orgmode@gnu.org
Subject: Re: Clock time implied as 00:00
Date: Fri, 30 Dec 2011 17:27:47 -0500 [thread overview]
Message-ID: <26531.1325284067@alphaville.dokosmarshall.org> (raw)
In-Reply-To: Message from pinard@iro.umontreal.ca (=?utf-8?Q?Fran=C3=A7ois?= Pinard) of "Thu\, 29 Dec 2011 11\:57\:10 EST." <87pqf7b9jt.fsf@iro.umontreal.ca>
François Pinard <pinard@iro.umontreal.ca> wrote:
> Hi, Org people.
>
> This morning, I just noticed this line:
>
> CLOCK: [2011-12-29 jeu 9:30]--[2011-12-29 jeu 11:44] => 11:44
>
> because of the strange 11:44 total. My error is clear, as I wrote 9:30
> instead of 09:30. Correcting it gives a move reasonable total:
>
> CLOCK: [2011-12-29 jeu 09:30]--[2011-12-29 jeu 11:44] => 2:14
>
> Yet, forgetting a leading 0 is an easy mistake (I know I should not make
> mistakes!), and then, maybe (I'm not sure) Org mode could deliver
> unexpected or misleading statistics out of a silent error. Not such a
> problem for me, yet it could have become one if I missed it.
>
> Would it be reasonable to suggest that Org mode be more lenient about
> missing leading zeroes?
>
There are two regexps that match timestamps, org-ts-regexp0 and
org-ts-regexp1 (and two more, derived from the first two). In each case
the part that matches the HH:MM part is as follows:
"... \\([0-9]\\{2\\}\\):\\([0-9]\\{2\\}\\)..."
in words: "exactly two digits, followed by a colon, followed by exactly
two digits". Modifying them so that the HH part can be "one or two
digits" seems to make org-parse-time-string work correctly with the above
input:
"... \\([0-9]\\{1,2\\}\\):\\([0-9]\\{2\\}\\)..."
Whether this has undesirable consequences[fn:1], I don't know. Actually
it's only regexp0 that is used in org-parse-time-string, so strictly
speaking, only it needs to be modified.
Nick
Footnotes:
[fn:1] In particular, org-ts-regexp0 is explicitly used in org-odt.el, so at least that part
needs to be checked for breakage, something that I have not done.
next prev parent reply other threads:[~2011-12-30 22:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-29 16:57 Clock time implied as 00:00 François Pinard
2011-12-29 19:47 ` Nick Dokos
2011-12-30 22:27 ` Nick Dokos [this message]
2011-12-31 8:42 ` Bastien
2011-12-31 17:01 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26531.1325284067@alphaville.dokosmarshall.org \
--to=nicholas.dokos@hp.com \
--cc=emacs-orgmode@gnu.org \
--cc=pinard@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).