From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Problem with org-mac-message.el Date: Sat, 4 Apr 2009 12:33:16 +0200 Message-ID: <25FA0450-9B9A-42E0-93AF-14E53F3CB076@gmail.com> References: <4DDA3A2E-81DA-4FAE-8D96-68D5E38E6667@gmail.com> <67BED2B7-68AC-4AF5-B4D3-15706A4FE6D5@gmail.com> Mime-Version: 1.0 (Apple Message framework v930.3) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lq3Bl-0004QX-JV for emacs-orgmode@gnu.org; Sat, 04 Apr 2009 06:33:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lq3Bh-0004Q1-56 for emacs-orgmode@gnu.org; Sat, 04 Apr 2009 06:33:25 -0400 Received: from [199.232.76.173] (port=57403 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lq3Bg-0004Pu-Sq for emacs-orgmode@gnu.org; Sat, 04 Apr 2009 06:33:20 -0400 Received: from mail-ew0-f160.google.com ([209.85.219.160]:45522) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lq3Bg-00007a-EX for emacs-orgmode@gnu.org; Sat, 04 Apr 2009 06:33:20 -0400 Received: by ewy4 with SMTP id 4so1430482ewy.42 for ; Sat, 04 Apr 2009 03:33:19 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Christopher Suckling Cc: emacs-orgmode emacs-orgmode Hi Christopher, I have applied the patch, thanks. Also I made the following modification: The new function is defined as org-mac-message-insert-selected, and then the old name org-mac-message-insert-link is introduced as an alias. So you get your consisten function naming, and compatibility as well. I believe the file commentary may not be fully correct anymore, it still mentions the old function names. I have already pushed the new version, if you fix the commentary, please diff against that new version. Thanks. - Carsten On Apr 4, 2009, at 10:52 AM, Christopher Suckling wrote: > On 4 Apr 2009, at 09:25, Carsten Dominik wrote: > >> >> the patch and the abstraction looks good. However, I am sure that >> there are quite a few people who have remember templates which call >> >> %(org-mac-message-insert-link) >> >> Let's not break their setup. Could you modify your patch so that >> this >> function still works? >> > > Here you go. > > Christopher > >