emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: Christopher Suckling <suckling.list@googlemail.com>
Cc: emacs-orgmode emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Problem with org-mac-message.el
Date: Sat, 4 Apr 2009 12:33:16 +0200	[thread overview]
Message-ID: <25FA0450-9B9A-42E0-93AF-14E53F3CB076@gmail.com> (raw)
In-Reply-To: <E428C6A3-6FC0-42AE-A36A-A6A6402B0A5C@gmail.com>

Hi Christopher,

I have applied the patch, thanks.

Also I made the following modification:

The new function is defined as org-mac-message-insert-selected,
and then the old name org-mac-message-insert-link is introduced
as an alias.  So you get your consisten function naming, and
compatibility as well.

I believe the file commentary may not be fully correct anymore,
it still mentions the old function names.  I have already pushed the
new version, if you fix the commentary, please diff against that new  
version.
Thanks.

- Carsten

On Apr 4, 2009, at 10:52 AM, Christopher Suckling wrote:

> On 4 Apr 2009, at 09:25, Carsten Dominik wrote:
>
>>
>> the patch and the abstraction looks good.  However, I am sure that
>> there are quite a few people who have remember templates which call
>>
>> %(org-mac-message-insert-link)
>>
>> Let's not break their setup.  Could you modify your patch so that  
>> this
>> function still works?
>>
>
> Here you go.
>
> Christopher
>
> <org-mac-message.patch>

  reply	other threads:[~2009-04-04 10:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-01 20:21 Ed Hirgelt
2009-04-03 14:49 ` Christopher Suckling
2009-04-03 16:58   ` Carsten Dominik
2009-04-04  7:18     ` Christopher Suckling
2009-04-04  8:25       ` Carsten Dominik
2009-04-04  8:52         ` Christopher Suckling
2009-04-04 10:33           ` Carsten Dominik [this message]
2009-04-05 21:43             ` Christopher Suckling
2009-04-06  4:44               ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25FA0450-9B9A-42E0-93AF-14E53F3CB076@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=suckling.list@googlemail.com \
    --subject='Re: Problem with org-mac-message.el' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).