emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Felipe Lema <felipelema@mortemale.org>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Report error in scheme evaluation
Date: Wed, 22 Dec 2021 13:56:47 -0300	[thread overview]
Message-ID: <2537130.I8pqSgbtkj@felipe-thinkpad-x200> (raw)
In-Reply-To: <87sfuksn9y.fsf@localhost>

On Wednesday, 22 December 2021 11.54.33 -03 Ihor Radchenko wrote:
> Felipe Lema <felipelema@mortemale.org> writes:
> 
> > I started using guile with Org Babel and I was a little confused that errors weren't being reported. The attached patch will report the error the same way as python evaluation does.
> 
> The patch looks fine to me. Though never used scheme...
> 
> The only thing that can be improved is copy-paste from ob-eval.el It
> might be better to split the compile-mode code into separate function
> and reuse it.

I can do that in a separate patch after this one is merged.

> 
> > Let me know if I'm missing anything so this can be merged. It is correct to report errors this way, right?
> 
> Should be. Did you have a chance run the code for some time locally
> while actively playing around with scheme?

yup. Seems to work as I expected 

> 
> Best,
> Ihor
> 
Thanks
Felipe




  reply	other threads:[~2021-12-22 16:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-21 19:58 Felipe Lema
2021-12-21 23:07 ` Rudolf Adamkovič
2021-12-22  5:27   ` Felipe Lema
2021-12-23 21:01     ` Rudolf Adamkovič
2021-12-22 14:54 ` Ihor Radchenko
2021-12-22 16:56   ` Felipe Lema [this message]
2021-12-22 14:58 ` Ihor Radchenko
2021-12-22 16:34 ` Max Nikulin
2021-12-22 17:04   ` Ihor Radchenko
2021-12-28  1:03 Felipe Lema
2022-04-30  8:11 ` Ihor Radchenko
2022-04-30 10:35   ` Neil Jerram
2022-05-04  2:52     ` Felipe Lema

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2537130.I8pqSgbtkj@felipe-thinkpad-x200 \
    --to=felipelema@mortemale.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@gmail.com \
    --subject='Re: Report error in scheme evaluation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).