emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nick Dokos <nicholas.dokos@hp.com>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: nicholas.dokos@hp.com, emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: export to latex broken
Date: Fri, 20 Aug 2010 13:15:42 -0400	[thread overview]
Message-ID: <24853.1282324542@gamaville.dokosmarshall.org> (raw)
In-Reply-To: Message from Carsten Dominik <carsten.dominik@gmail.com> of "Fri, 20 Aug 2010 18:25:16 +0200." <E3D34790-2AB4-4482-B35C-1E39E0E8030E@gmail.com>

Carsten Dominik <carsten.dominik@gmail.com> wrote:

> 
> On Aug 20, 2010, at 4:36 PM, Puneeth wrote:
> 
> > Hi,
> >
> > Exporting from org to LaTeX is broken on the master.
> >
> > Git bisect gives the bad commit as 034dbac3eecd
> > "Search for LaTeX setup case-insensitively"
> 
> OK, I have reverted it.
> 
> Can you please describe what happened?
> 

line 1144 ff in org-latex.el:

                ....
		(and (let ((case-fold-search t))
		       (re-search-forward
			"^#\\+LaTeX_CLASS_OPTIONS:[ \t]*\\(.*?\\)[ \t]*$" nil t)
		       (match-string 1)))))

The and used to check for the match and if the match succeeded it would return
the match string. Now it returns the match string whether the search succeeds or not.
It probably should be:

                 ...
                 (let ((case-fold-search t))
                   (and (re-search-forward
			"^#\\+LaTeX_CLASS_OPTIONS:[ \t]*\\(.*?\\)[ \t]*$" nil t)
		       (match-string 1)))...

Nick

  parent reply	other threads:[~2010-08-20 17:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-20 14:36 export to latex broken Puneeth
2010-08-20 16:24 ` Eric S Fraga
2010-08-20 16:25 ` Carsten Dominik
2010-08-20 17:15   ` Puneeth
2010-08-20 17:15   ` Nick Dokos [this message]
2010-08-20 17:26   ` Eric S Fraga
  -- strict thread matches above, loose matches on Subject: below --
2011-03-01 10:50 suvayu ali
2011-03-01 11:24 ` Nicolas
2011-03-01 11:35   ` Suvayu Ali
2011-03-01 11:42     ` Nicolas
2011-03-01 11:59       ` Suvayu Ali
2011-03-01 11:49     ` Suvayu Ali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24853.1282324542@gamaville.dokosmarshall.org \
    --to=nicholas.dokos@hp.com \
    --cc=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).