emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nick Dokos <nicholas.dokos@hp.com>
Cc: Lawrence Mitchell <wence@gmx.li>,
	nicholas.dokos@hp.com, emacs-orgmode@gnu.org,
	Eden Cardim <edencardim@gmail.com>
Subject: Re: Export options being ignored
Date: Thu, 05 May 2011 01:08:14 -0400	[thread overview]
Message-ID: <24788.1304572094@alphaville.dokosmarshall.org> (raw)
In-Reply-To: Message from Nick Dokos <nicholas.dokos@hp.com> of "Thu, 05 May 2011 00:33:34 EDT." <24377.1304570014@alphaville.dokosmarshall.org>

Nick Dokos <nicholas.dokos@hp.com> wrote:

> ,----
> | aa6dba8a74016587755c250bb8cc4743a4082ea1 is the first bad commit
> `----
> 

Taking a look at the commit:

,----
| commit aa6dba8a74016587755c250bb8cc4743a4082ea1
| Author: Lawrence Mitchell <wence@gmx.li>
| Date:   Thu Jan 20 18:23:22 2011 +0000
| 
|     Only match complete words in org-export-add-options-to-plist
|     
|     * org-exp.el (org-export-add-options-to-plist): Require match to start
|     at a word-boundary.
|     
|     Previously, if an option was the suffix of another option (such as TeX
|     and LaTeX) the setting for the former would propagator to the latter.
|     This seems like an unintended consequence of a lax regexp in
|     org-export-add-options-to-plist.  This patch allows options to share a
|     suffix with another option by requiring that the match against an
|     option starts at a word-boundary.
| 
| diff --git a/lisp/org-exp.el b/lisp/org-exp.el
| index a265c3b..4a10303 100644
| --- a/lisp/org-exp.el
| +++ b/lisp/org-exp.el
| @@ -830,7 +830,7 @@ security risks."
|        (let ((op org-export-plist-vars))
|  	(while (setq o (pop op))
|  	  (if (and (nth 1 o)
| -		   (string-match (concat (regexp-quote (nth 1 o))
| +		   (string-match (concat "\\<" (regexp-quote (nth 1 o))
|  					 ":\\([^ \t\n\r;,.]*\\)")
|  				 options))
|  	      (setq p (plist-put p (car o)
`----

explains the problem: \< matches the empty string at the beginning of a
word (i.e. if the syntax class of the next character is "word") but it
does not at the beginning of a char that is of some other syntax class
(I think it will not match anything in this case).  So Eden diagnosed it
correctly: it *is* a parsing problem and it *does* involve the non-word
options.

At this point, the cure looks worse than the disease, so this commit should
probably be reverted.

Thanks,
Nick

next prev parent reply	other threads:[~2011-05-05  6:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-05  1:15 Export options being ignored Eden Cardim
2011-05-05  4:33 ` Nick Dokos
2011-05-05  5:08   ` Nick Dokos [this message]
2011-05-05  7:09     ` Carsten Dominik
2011-05-05  8:08       ` Lawrence Mitchell
2011-05-05 10:40       ` Eden Cardim
2011-05-05 10:48         ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24788.1304572094@alphaville.dokosmarshall.org \
    --to=nicholas.dokos@hp.com \
    --cc=edencardim@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=wence@gmx.li \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).