From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Re: org-show-effort ideas Date: Wed, 4 Nov 2009 14:19:47 +0100 Message-ID: <2397914D-ECB8-4CC7-A157-FC4C3149FD7D@gmail.com> References: <20091102134924.GC25581@atlantic.linksys.moosehall> <20091103121138.GF32187@atlantic.linksys.moosehall> <87aaz37jqz.fsf@in-ulm.de> <20091104002608.GH32187@atlantic.linksys.moosehall> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N5jwt-0006K7-NI for emacs-orgmode@gnu.org; Wed, 04 Nov 2009 12:47:11 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N5jwp-0006FX-2C for emacs-orgmode@gnu.org; Wed, 04 Nov 2009 12:47:11 -0500 Received: from [199.232.76.173] (port=48193 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N5jwo-0006FP-W1 for emacs-orgmode@gnu.org; Wed, 04 Nov 2009 12:47:07 -0500 Received: from mail-ew0-f228.google.com ([209.85.219.228]:42413) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N5jwo-0008CW-Ii for emacs-orgmode@gnu.org; Wed, 04 Nov 2009 12:47:06 -0500 Received: by mail-ew0-f228.google.com with SMTP id 28so236526ewy.42 for ; Wed, 04 Nov 2009 09:47:06 -0800 (PST) In-Reply-To: <20091104002608.GH32187@atlantic.linksys.moosehall> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Adam Spiers Cc: emacs-orgmode@gnu.org Hi Adam, On Nov 4, 2009, at 1:26 AM, Adam Spiers wrote: > Benjamin Andresen (benny@in-ulm.de) wrote: >> Adam Spiers writes: >> >>> I definitely did try it, and I just did another 'git pull' and tried >>> again, and I still don't see it, so I guess we're talking about >>> different things ;-) >>> >>> To clarify, I'm referring to showing effort via a single keystroke >>> when on a todo line in the *Org Agenda* buffer. Currently, when I >>> hit >>> "e" on a todo which has an existing "Effort" property value set, my >>> minibuffer prompt shows "Value: ". The same applies with C-c C-x >>> e in >>> a normal .org file buffer. >> >> When I press 'e' in an agenda on an item that has the Effort property >> value set, I get a minibuffer prompt that shows "Value [5]: " when >> the >> Effort value is 5. >> >> This is with a git version from Sunday morning. >> >> Check the source of the function org-set-effort, it will show you >> that >> it concats "[" cur "]", where cur is the current Effort prop value. > > Thanks for the pointer - it seems that the "[" cur "]" is only > included when > > (org-property-get-allowed-values nil prop 'table) > > is nil - and in my case I have a global Effort_ALL property set which > means that this is never the case. So I think this is a bug which can > be trivially fixed by assigning the prompt string in the let* variable > list, and then using it in both invocations of org-completing-read. You are right, and it is fixed now. - Carsten