From: Carsten Dominik <carsten.dominik@gmail.com>
To: Nick Dokos <ndokos@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: feature request: reloading settings in an org file should reload file local variables
Date: Tue, 14 Jan 2014 20:49:08 +0100 [thread overview]
Message-ID: <22D334F3-1C94-42E9-9E95-5416734CF948@gmail.com> (raw)
In-Reply-To: <87ppnu60k0.fsf@alphaville.bos.redhat.com>
On 14 Jan 2014, at 16:33, Nick Dokos <ndokos@gmail.com> wrote:
> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> Hi Eric,
>>
>> On Jan 14, 2014, at 3:03 PM, Eric S Fraga <e.fraga@ucl.ac.uk> wrote:
>>
>>> Hello,
>>>
>>> I constantly run into an annoying side effect of org's handling of
>>> settings in a document. When writing a document for export, usually to
>>> LaTeX, I find myself playing around with the document wide
>>> setting variables, e.g.
>>>
>>> #+options: toc:nil
>>> #+latex_header: \usepackage{tikz}
>>>
>>> and similar. Org requires me to re-load the document settings by
>>> hitting C-c C-c on any such document setting line. This is fine.
>>>
>>> The problem is that org appears to reset *all* variables to default
>>> (custom?) settings. This includes variables that have been set using
>>> file local variables in the given document. Of particular note is the
>>> variable ~org-export-allow-bind-keywords~. I normally have this set to
>>> nil for safety reasons but wish to set this to t in some documents. I
>>> use something like this quite often on documents I *know* are safe:
>>>
>>> ,----
>>> | # Local Variables:
>>> | # org-confirm-babel-evaluate: nil
>>> | # org-export-allow-bind-keywords: t
>>> | # End:
>>> `----
>>>
>>> The problem is that hitting C-c C-c on a settings line clears these
>>> variables. Having the bind one reset is particularly confusing at
>>> times. In the end, I have to kill the buffer and re-visit the file to
>>> have things set up properly.
>>>
>>> Is it possible to have org reload the whole file when reloading
>>> settings? Or not reset any variables at all? Either approach would be
>>> exhibit more consistent behaviour possibly? Obviously, the position in
>>> the file would have to be remembered should the file be reloaded
>>> automatically.
>>>
>>> This is not a major issue but a niggly one...
>>
>> Could you try the following patch?
>>
>> - Carsten
>>
>> diff --git a/lisp/org.el b/lisp/org.el
>> index 549f1f8..6fca255 100644
>> --- a/lisp/org.el
>> +++ b/lisp/org.el
>> @@ -20482,11 +20482,9 @@ This command does many different things, depending on context:
>> Also updates the keyword regular expressions."
>> (interactive)
>> ;; this will set the mode *and* set file local variables.
>> - (normal-mode)
>> - ;; but it may leave us in some unrelated mode
>> - (unless (derived-mode-p "org-mode")
>> - (org-mode))
>> - (message "Org-mode restarted"))
>> + (funcall major-mode)
>> + (hack-local-variables)
>> + (message "Mode restarted"))
>
>
> I thought this was fixed, originally with commit 5ea0228
> and after York Zhao found a problem (see the thread at
> http://thread.gmane.org/gmane.emacs.orgmode/79187)
> with commit 0911edfac881ab17a2cd1670f169ff4bdf1ac486
> and two subsequent commits by Achim to fix some problems:
>
> commit e655e664bff9fb6e98478682f03e713f990acba5
> commit f2483ec4bbe196ab29ef6312b0d7c1c179a9eafe
>
> Is this another maint vs master issue perhaps?
>
> Nick
>
>
Indeed, there were differences between maint and master. Now fixed in both.
- Carsten
next prev parent reply other threads:[~2014-01-14 19:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 14:03 feature request: reloading settings in an org file should reload file local variables Eric S Fraga
2014-01-14 14:49 ` Carsten Dominik
2014-01-14 15:33 ` Nick Dokos
2014-01-14 19:49 ` Carsten Dominik [this message]
2014-01-14 16:12 ` Bastien
2014-01-14 19:57 ` Eric S Fraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22D334F3-1C94-42E9-9E95-5416734CF948@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=ndokos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).