From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Cc: Hugo Heagren <hugo@heagren.com>
Subject: [PATCH] org-test: Run all ol tests on make test
Date: Tue, 26 Jul 2022 22:27:19 +0700 [thread overview]
Message-ID: <218fded4-485e-d34e-4f9e-68f4eff8ae81@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 242 bytes --]
Hi,
I figured out why "make test" is passing successfully while the same
with BTEST_RE="test-ol/insert-link-insert-description" is failing for a
proposed patch. Default selection pattern is ignoring most test-ol
cases. See the attachment.
[-- Attachment #2: 0001-org-test-Run-all-ol-tests-on-make-test.patch --]
[-- Type: text/x-patch, Size: 1983 bytes --]
From 0cb30c77d888a38360f11657f7a391ab72fa312e Mon Sep 17 00:00:00 2001
From: Max Nikulin <manikulin@gmail.com>
Date: Tue, 26 Jul 2022 22:11:40 +0700
Subject: [PATCH] org-test: Run all ol tests on make test
* mk/default.mk (BTEST_RE): Add -ol to the default pattern.
* testing/org-test.el (org-test-run-batch-tests): Update default regexp
for test selection in the docstring.
Only `test-ol/org-toggle-link-display' from test-ol.el was executed
since it is matched by "org" part of the pattern. The leading dash is
added to make tests a bit more specific. Reported in:
Ihor Radchenko to emacs-orgmode. Re [PATCH v7] ol.el: add
description format parameter to org-link-parameters.
Sun, 24 Jul 2022 21:15:31 +0800.
https://list.orgmode.org/87v8rmd53g.fsf@localhost/
---
mk/default.mk | 2 +-
testing/org-test.el | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mk/default.mk b/mk/default.mk
index 33e737da3..7371d3a99 100644
--- a/mk/default.mk
+++ b/mk/default.mk
@@ -72,7 +72,7 @@ REPRO_ARGS ?=
req-ob-lang = --eval '(require '"'"'ob-$(ob-lang))'
lst-ob-lang = ($(ob-lang) . t)
req-extra = --eval '(require '"'"'$(req))'
-BTEST_RE ?= \\(org\\|ob\\)
+BTEST_RE ?= \\(org\\|ob\\|-ol\\)
BTEST_LOAD = \
--eval '(add-to-list '"'"'load-path (concat default-directory "lisp"))' \
--eval '(add-to-list '"'"'load-path (concat default-directory "testing"))'
diff --git a/testing/org-test.el b/testing/org-test.el
index 0520e82f9..6defa9cc9 100644
--- a/testing/org-test.el
+++ b/testing/org-test.el
@@ -424,7 +424,7 @@ setting `pp-escape-newlines' to nil manually."
"^\\([^.]\\|\\.\\([^.]\\|\\..\\)\\).*\\.org$")))
(defun org-test-run-batch-tests (&optional org-test-selector)
- "Run all tests matching an optional regex which defaults to \"\\(org\\|ob\\)\".
+ "Run all tests matching an optional regex which defaults to \"\\(org\\|ob\\|-ol\\)\".
Load all test files first."
(interactive)
(let ((org-id-track-globally t)
--
2.25.1
next reply other threads:[~2022-07-26 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 15:27 Max Nikulin [this message]
2022-07-27 3:49 ` [PATCH] org-test: Run all ol tests on make test Ihor Radchenko
2022-07-27 15:43 ` Max Nikulin
2022-07-28 14:31 ` Ihor Radchenko
2022-07-28 15:14 ` [PATCH v2] " Max Nikulin
2022-07-29 13:06 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=218fded4-485e-d34e-4f9e-68f4eff8ae81@gmail.com \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=hugo@heagren.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).